patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH v2] app/test-fib: fix possible division by zero
@ 2021-12-23 15:37 Vladimir Medvedkin
  0 siblings, 0 replies; only message in thread
From: Vladimir Medvedkin @ 2021-12-23 15:37 UTC (permalink / raw)
  To: dev; +Cc: stable

This patch fixes the division by 0, which occurs if
the number of routes is less than 10.
Can be triggered by passing -n argument with value < 10:

./dpdk-test-fib -- -n 9
...
Floating point exception (core dumped)

Fixes: 103809d032cd ("app/test-fib: add test application for FIB")
Cc: stable@dpdk.org

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 app/test-fib/main.c | 40 ++++++++++++++++++++++++----------------
 1 file changed, 24 insertions(+), 16 deletions(-)

diff --git a/app/test-fib/main.c b/app/test-fib/main.c
index ecd420116a..9bc8b8a7ca 100644
--- a/app/test-fib/main.c
+++ b/app/test-fib/main.c
@@ -902,8 +902,9 @@ run_v4(void)
 				return -ret;
 			}
 		}
-		printf("AVG FIB add %"PRIu64"\n",
-			(rte_rdtsc_precise() - start) / j);
+		if (j != 0)
+			printf("AVG FIB add %"PRIu64"\n",
+				(rte_rdtsc_precise() - start) / j);
 		i += j;
 	}
 
@@ -930,8 +931,9 @@ run_v4(void)
 					return -ret;
 				}
 			}
-			printf("AVG LPM add %"PRIu64"\n",
-				(rte_rdtsc_precise() - start) / j);
+			if (j != 0)
+				printf("AVG LPM add %"PRIu64"\n",
+					(rte_rdtsc_precise() - start) / j);
 			i += j;
 		}
 	}
@@ -984,8 +986,9 @@ run_v4(void)
 		for (j = 0; j < (config.nb_routes - i) / k; j++)
 			rte_fib_delete(fib, rt[i + j].addr, rt[i + j].depth);
 
-		printf("AVG FIB delete %"PRIu64"\n",
-			(rte_rdtsc_precise() - start) / j);
+		if (j != 0)
+			printf("AVG FIB delete %"PRIu64"\n",
+				(rte_rdtsc_precise() - start) / j);
 		i += j;
 	}
 
@@ -996,8 +999,9 @@ run_v4(void)
 				rte_lpm_delete(lpm, rt[i + j].addr,
 					rt[i + j].depth);
 
-			printf("AVG LPM delete %"PRIu64"\n",
-				(rte_rdtsc_precise() - start) / j);
+			if (j != 0)
+				printf("AVG LPM delete %"PRIu64"\n",
+					(rte_rdtsc_precise() - start) / j);
 			i += j;
 		}
 	}
@@ -1097,8 +1101,9 @@ run_v6(void)
 				return -ret;
 			}
 		}
-		printf("AVG FIB add %"PRIu64"\n",
-			(rte_rdtsc_precise() - start) / j);
+		if (j != 0)
+			printf("AVG FIB add %"PRIu64"\n",
+				(rte_rdtsc_precise() - start) / j);
 		i += j;
 	}
 
@@ -1125,8 +1130,9 @@ run_v6(void)
 					return -ret;
 				}
 			}
-			printf("AVG LPM add %"PRIu64"\n",
-				(rte_rdtsc_precise() - start) / j);
+			if (j != 0)
+				printf("AVG LPM add %"PRIu64"\n",
+					(rte_rdtsc_precise() - start) / j);
 			i += j;
 		}
 	}
@@ -1183,8 +1189,9 @@ run_v6(void)
 		for (j = 0; j < (config.nb_routes - i) / k; j++)
 			rte_fib6_delete(fib, rt[i + j].addr, rt[i + j].depth);
 
-		printf("AVG FIB delete %"PRIu64"\n",
-			(rte_rdtsc_precise() - start) / j);
+		if (j != 0)
+			printf("AVG FIB delete %"PRIu64"\n",
+				(rte_rdtsc_precise() - start) / j);
 		i += j;
 	}
 
@@ -1195,8 +1202,9 @@ run_v6(void)
 				rte_lpm6_delete(lpm, rt[i + j].addr,
 					rt[i + j].depth);
 
-			printf("AVG LPM delete %"PRIu64"\n",
-				(rte_rdtsc_precise() - start) / j);
+			if (j != 0)
+				printf("AVG LPM delete %"PRIu64"\n",
+					(rte_rdtsc_precise() - start) / j);
 			i += j;
 		}
 	}
-- 
2.25.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-12-23 15:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-23 15:37 [PATCH v2] app/test-fib: fix possible division by zero Vladimir Medvedkin

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git