From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5D5EA00C2 for ; Thu, 10 Feb 2022 10:13:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD5EA40041; Thu, 10 Feb 2022 10:13:23 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C8A1A41143 for ; Wed, 9 Feb 2022 11:39:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644403156; x=1675939156; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=07P0/rbQKaWlVg0T/EF+JQxJ/4bZXNhrplah0gPbg1I=; b=HgxGvRgAXgVbMtx/qZvetBjX7SIG1SoKmTVkOPQVFlfHwKbEWeC9niRt uSwi7k4Ve198grqMEhdkxTg+w6/0uldBF7ZRKaQCi4/w2n00VS85U30ZT /e+JWw7WdEFf13bK7yXh9dK5CRURJYqS27wquQnYH31NzKGZA1IOsk/4B yZq+3Wzvg+IKyz3GCKDpJ4yUCgrssALegGiVcWNKXwit9D5RKA9IwJsiT wfwFutApt/c/gC24WI+pv2xxob2BxWrAWTDAbuNPDIIaJntxTjF0ExMB3 jLzVOFJpq1P6/SsmDTvaKbq3mO3GluuibJGDx0WIYoir/pcBjrEjqXSUe g==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="236583004" X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="236583004" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 02:39:14 -0800 X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="541039073" Received: from unknown (HELO localhost.localdomain) ([10.239.251.3]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 02:39:13 -0800 From: wenxuanx.wu@intel.com To: build_sh@intel.com Cc: Wenxuan Wu , stable@dpdk.org Subject: [DPDK] app/testpmd : fix testpmd quit error Date: Wed, 9 Feb 2022 18:19:22 +0800 Message-Id: <20220209101922.114958-1-wenxuanx.wu@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 10 Feb 2022 10:13:22 +0100 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org From: Wenxuan Wu when testpmd starup with pf and vfs, it is ok when running, while exiting, it will result in heap-free-after-use which means pf is released but vf is still accessing. Change the logic of func port_is_bonding_slave ,this func eth_dev_info_get_print_err while pf is released would result in this error. Fixes: 0a0821bcf312 ("app/testpmd: remove most uses of internal ethdev array") Cc: stable@dpdk.org Signed-off-by: Wenxuan Wu --- app/test-pmd/testpmd.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index e1da961311..7fa1944d78 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3824,19 +3824,10 @@ void clear_port_slave_flag(portid_t slave_pid) uint8_t port_is_bonding_slave(portid_t slave_pid) { struct rte_port *port; - struct rte_eth_dev_info dev_info; - int ret; port = &ports[slave_pid]; - ret = eth_dev_info_get_print_err(slave_pid, &dev_info); - if (ret != 0) { - TESTPMD_LOG(ERR, - "Failed to get device info for port id %d," - "cannot determine if the port is a bonded slave", - slave_pid); - return 0; - } - if ((*dev_info.dev_flags & RTE_ETH_DEV_BONDED_SLAVE) || (port->slave_flag == 1)) + + if (port->slave_flag == 1) return 1; return 0; } -- 2.25.1