From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E4D1A034C for ; Tue, 15 Feb 2022 11:11:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0CE141144; Tue, 15 Feb 2022 11:11:13 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2057.outbound.protection.outlook.com [40.107.94.57]) by mails.dpdk.org (Postfix) with ESMTP id 2A33640E78; Tue, 15 Feb 2022 11:11:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxcVCCcXVJFEzBcO8MrpyXiaEl+28V6eUxM6mJTgBJquiiK8wfQLmsPpxBWSdam/OIGFbsfEOk9MLNLHHFUzEgG4R4JCvijTs6CnCnyjDnEcJ470DOelXOhi+xaiMgkr0DdV49t4qqyYSpOUoEJJ3EdnvcVKe0r++MaMIySoMG8tul/oX6jra/WBQIS8unRxQ4ErRxyc4oYXwSr4pNRwh4ODsA1t4c6NRtdDS0tEBUjVuRPPnnjVZAJeBbIM+S5UKwPWtiIJFCwnsy0Mpkzob7MH7V2JvYWW56SY51XhxgOk+diTC0paJ2whgfqfdOnFAEru02uoeO0ku8PoRa3a+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P//wJmyCLwGD37IGDPATiLfDiASDGgFKu1ul2wAuSAI=; b=n+3dgnYBBQ872avs5dxdIn9+A0/WHSuYNsPCqoQU+IouJGMWdF6Qg93pRQ/U0uPQxDVcxwuNBnSfZYoRykV7CUISLQ0ZchSjQx1bWVHlYp2MdbsDgKJYzWsAjnpQsILXpU52ROyv/FCJLBKN74FlE6MDkCRGHyV0hPkA0EqF6ZFQlqdqrIxp0fKaOZrWb7LUF9OKIeNKi9U8taNTsQ+nWcT73rCJ6Dp5WdLiWijugufwUHop7ZdcU0WohopvFTNMIkgIQcGXLwfPk1GbG11bbjj0QgOB4hEYl180KxnNbuqTREdZYwM1azzmMCji0MN6nAMBvs/O1IOmB+NIXcukXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.235) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P//wJmyCLwGD37IGDPATiLfDiASDGgFKu1ul2wAuSAI=; b=jfSYjamslmsnKVlOFf/mPPiv1hm+xrp5TvbTYAMONU2+TMstqLH80nKFdIu3soM0SOJlKK76tNpA/EfLmYlZ0kh5KBQqECO2nvUbVi4bXVkbRZz64MvFR0K/BWSO5ovjMPeKRvPbTE/bI4FC+ygKkh2oJa0mLrUNq3WKjPPNpl69PUUyBp6+pkn864YHWVZUTq1891wFRWDYwfMQDjPYKoFiZWu3cy+++0/0jNqlskWgHN0jPPKAyWLIX2ESpcZwutX9vDVKWb4NsnvS/BR+ij1BKMqjaJUXETd1vGQGFbmFaJ0rbqBx20D1Jc4tg8NZRQMaaXE/OMAHkpCMi9BiKA== Received: from DM5PR16CA0022.namprd16.prod.outlook.com (2603:10b6:3:c0::32) by BYAPR12MB2919.namprd12.prod.outlook.com (2603:10b6:a03:12c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.19; Tue, 15 Feb 2022 10:11:10 +0000 Received: from DM6NAM11FT058.eop-nam11.prod.protection.outlook.com (2603:10b6:3:c0:cafe::c2) by DM5PR16CA0022.outlook.office365.com (2603:10b6:3:c0::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11 via Frontend Transport; Tue, 15 Feb 2022 10:11:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.235) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.235 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.235; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.235) by DM6NAM11FT058.mail.protection.outlook.com (10.13.172.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4975.11 via Frontend Transport; Tue, 15 Feb 2022 10:11:09 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 15 Feb 2022 10:11:09 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Tue, 15 Feb 2022 02:11:07 -0800 From: Suanming Mou To: , CC: , , Subject: [PATCH] net/mlx5: fix error infomation missing Date: Tue, 15 Feb 2022 12:10:52 +0200 Message-ID: <20220215101052.1268-1-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b6406a42-a531-40df-a0a7-08d9f06b7d13 X-MS-TrafficTypeDiagnostic: BYAPR12MB2919:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:473; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jFCcuZbUtvoLsxKS+c2k9cy6V7iac2xdF+5wbX/EjU80/bPG9UUfSPLGBpcizGksiaYNEMwtIWM1xSLqUWATJcZ0b/l8TurOQUsZU7DVnGyCPY673dpgClZlRjXnvcMCbfIjdJOsZ2AnsRl0B6ubFVoGAQHA+qG4R/2+ndEhCB/BIq1KN3uv8lWy2F1YgRWNo1OCUu8s+U2XWt+TH7+Ip9K/zh/h9EI9Y1fjwb3UmicKTx0GD1zLq7udIBK+ng8lSoD2K76qliY9czbl2Qzx66MefZJzIpsL597fI8sO3sHEEkN2OHYU+ksMQWcMVlJFg8iFGA6KTzy1KdIsn3HQo1jbrXcSVh3bsO+3a6Lyvg+NjC3zWOopZOLRXzvajaf5FuBIkuCS+GHCwndAHXeTxL2uUY42HMhh57lbJwPphCy2wr57PQ2+PzHNIivIBTcb8XOnspf206Py7Ug9dZyXMR9UG1PrFfQ4JKtemf/meg3aNlkbDlG7SgLV0TRbEb7eInz5fr+oGvqfqSj7qoGMeAVgIFy+iMprxxlA3S6MK5RZ9CS+fCcopzm/vuwXxOZ4NRP2V/l6pJj2YhF6+8LETG2p4wyj6VW3INAYvPEQ1PxSaR66yLj/gvxL5ZiLk7Aj4FaWeA2O3THuFqiZQJOIQvlhdrVJMXVUgdt0Tb6q3suYyjtULiRS7+oSZYHHiC5SIACIu+H1aQMViG9cBejnpw== X-Forefront-Antispam-Report: CIP:12.22.5.235; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(54906003)(110136005)(450100002)(7696005)(316002)(508600001)(82310400004)(336012)(426003)(86362001)(83380400001)(36860700001)(6666004)(47076005)(6636002)(40460700003)(26005)(1076003)(6286002)(186003)(2906002)(36756003)(5660300002)(55016003)(2616005)(8676002)(4326008)(70206006)(81166007)(8936002)(356005)(70586007)(16526019)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 10:11:09.8991 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6406a42-a531-40df-a0a7-08d9f06b7d13 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.235]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT058.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2919 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org While mlx5_hlist_create() failed, the rte_flow_error was not filled with the corresponding error information. This commit adds the missing rte_flow_error_set() for the failure case. Fixes: f3020a331dca ("net/mlx5: optimize hash list table allocate on demand") Cc: stable@dpdk.org Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index ef9c66eddf..05456ff196 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -312,7 +312,8 @@ flow_dv_hlist_prepare(struct mlx5_dev_ctx_shared *sh, struct mlx5_hlist **phl, mlx5_list_match_cb cb_match, mlx5_list_remove_cb cb_remove, mlx5_list_clone_cb cb_clone, - mlx5_list_clone_free_cb cb_clone_free) + mlx5_list_clone_free_cb cb_clone_free, + struct rte_flow_error *error) { struct mlx5_hlist *hl; struct mlx5_hlist *expected = NULL; @@ -327,7 +328,9 @@ flow_dv_hlist_prepare(struct mlx5_dev_ctx_shared *sh, struct mlx5_hlist **phl, cb_clone_free); if (!hl) { DRV_LOG(ERR, "%s hash creation failed", name); - rte_errno = ENOMEM; + rte_flow_error_set(error, ENOMEM, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, + "cannot allocate resource memory"); return NULL; } if (!__atomic_compare_exchange_n(phl, &expected, hl, false, @@ -3725,7 +3728,8 @@ flow_dv_encap_decap_resource_register flow_dv_encap_decap_match_cb, flow_dv_encap_decap_remove_cb, flow_dv_encap_decap_clone_cb, - flow_dv_encap_decap_clone_free_cb); + flow_dv_encap_decap_clone_free_cb, + error); if (unlikely(!encaps_decaps)) return -rte_errno; resource->flags = dev_flow->dv.group ? 0 : 1; @@ -5821,7 +5825,8 @@ flow_dv_modify_hdr_resource_register flow_dv_modify_match_cb, flow_dv_modify_remove_cb, flow_dv_modify_clone_cb, - flow_dv_modify_clone_free_cb); + flow_dv_modify_clone_free_cb, + error); if (unlikely(!modify_cmds)) return -rte_errno; resource->root = !dev_flow->dv.group; @@ -10758,7 +10763,8 @@ flow_dv_tag_resource_register flow_dv_tag_match_cb, flow_dv_tag_remove_cb, flow_dv_tag_clone_cb, - flow_dv_tag_clone_free_cb); + flow_dv_tag_clone_free_cb, + error); if (unlikely(!tag_table)) return -rte_errno; entry = mlx5_hlist_register(tag_table, tag_be24, &ctx); -- 2.25.1