* [PATCH] crypto/ipsec_mb: fix qp cleanup unreachable code
@ 2022-02-15 11:07 Ciara Power
2022-02-17 18:22 ` [EXT] " Akhil Goyal
0 siblings, 1 reply; 2+ messages in thread
From: Ciara Power @ 2022-02-15 11:07 UTC (permalink / raw)
To: dev; +Cc: stable, john.mcnamara, roy.fan.zhang, Ciara Power, Pablo de Lara
The qp is never NULL when it reaches the qp_setup_cleanup error handling
code. This is due to checks earlier in the function that return an error
if qp is NULL.
Coverity issue: 375013
Fixes: 581c39b1cb7d ("crypto/ipsec_mb: fix queue cleanup null pointer dereference")
Cc: stable@dpdk.org
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
index 1cf37e9836..7e8396b4a3 100644
--- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
+++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
@@ -284,8 +284,6 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return 0;
qp_setup_cleanup:
- if (qp == NULL)
- return ret;
#if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM
if (qp->mb_mgr)
free_mb_mgr(qp->mb_mgr);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [EXT] [PATCH] crypto/ipsec_mb: fix qp cleanup unreachable code
2022-02-15 11:07 [PATCH] crypto/ipsec_mb: fix qp cleanup unreachable code Ciara Power
@ 2022-02-17 18:22 ` Akhil Goyal
0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2022-02-17 18:22 UTC (permalink / raw)
To: Ciara Power, dev; +Cc: stable, john.mcnamara, roy.fan.zhang, Pablo de Lara
> The qp is never NULL when it reaches the qp_setup_cleanup error handling
> code. This is due to checks earlier in the function that return an error
> if qp is NULL.
>
> Coverity issue: 375013
> Fixes: 581c39b1cb7d ("crypto/ipsec_mb: fix queue cleanup null pointer
> dereference")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
Applied to dpdk-next-crypto
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-17 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15 11:07 [PATCH] crypto/ipsec_mb: fix qp cleanup unreachable code Ciara Power
2022-02-17 18:22 ` [EXT] " Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).