From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94C78A0032 for ; Fri, 18 Feb 2022 13:45:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FF0840141; Fri, 18 Feb 2022 13:45:52 +0100 (CET) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by mails.dpdk.org (Postfix) with ESMTP id 9433E40141 for ; Fri, 18 Feb 2022 13:45:51 +0100 (CET) Received: by mail-ej1-f48.google.com with SMTP id d10so14731703eje.10 for ; Fri, 18 Feb 2022 04:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q+rj4ajDwJQkf9G3PuFVO07+uJCxZPj6fjVdzIyhYLs=; b=GND+nM5LNZXN4kEmAeTJTJMzYw63MXhW57MRhdP6fa7XA8mVR5f7dG2gLvmFlb9jYw LM+2grBuQmaosJ6dKXZwYGiKHONxsu3ZoMxxSu1Qm715mBpjmySMsaHzIbmhQIWLNdFO T/4wpizYU1jH4lbTyS78YYzHJYMH6GLT19o08fMjvlToinOsG+0+ZtpNT4/PzShh2+fL wv5DWYIARB2wE2+9G5A6HkWCLqx+XYa3g1Ak9FEQlHSD3xhLb121ybWsAotWzmIsFJvd 71abZWk8Z5WYv3kofVxKT97iJX/vWfhflyLBfcEeRoSiZ92o24hnweCma59ExANf+h7L LSkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q+rj4ajDwJQkf9G3PuFVO07+uJCxZPj6fjVdzIyhYLs=; b=etZt0gwoaB+HbfFNzx0vMOgEQ777yt/kV3d6VTdJsS+u8jvdFe4MoZ8p52JecZ4MRp y9JOEMV7GIy9KhmZ6ueF0zIIZyM+iJTbbET0rXhe0j9BPpPC598bPgdAhRARFoIIUOpd qioEoam3W77Gy8Uw9f8MaoH9nBS5Pd95VBxSzwUuSP8yYVmA58ICAGIaJJElEaikT+fZ ROjX8oCw/j4nFq8AN7rT5kyRTPBDgBoj+DANMIuHc5IvLEE84ANQMNfhalKymMdM543r mgIoi727dzn64H66I27VKR7ngHHDSOOzLn/sDBRPYsFLfH+YucZltGFLYXuUC4ibIZNP wn+g== X-Gm-Message-State: AOAM530um5Hv69WsmvC3OnRSGnLywCRHg7nUc0anRLYEHmQyQAhIU9nQ sVUDiKWQ1rAPCUj3a+1DlaZnXk8VfRNMfOEi X-Google-Smtp-Source: ABdhPJzphIYcmPIGM8rm+0gza/LftL4BPk3Cv6wdWi2PQZSBBDj4YtrTKzVDXOW8CquJTwwWRElUww== X-Received: by 2002:a17:906:2811:b0:6ce:eacf:5210 with SMTP id r17-20020a170906281100b006ceeacf5210mr6602698ejc.618.1645188351341; Fri, 18 Feb 2022 04:45:51 -0800 (PST) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id i9sm4775017edc.56.2022.02.18.04.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 04:45:50 -0800 (PST) From: luca.boccassi@gmail.com To: Junfeng Guo Cc: Jingjing Wu , dpdk stable Subject: patch 'raw/ntb: clear all valid doorbell bits on init' has been queued to stable release 20.11.5 Date: Fri, 18 Feb 2022 12:39:30 +0000 Message-Id: <20220218123931.1749595-121-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218123931.1749595-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/105b5a413059ab8b134858be1b8d7fe53847bb44 Thanks. Luca Boccassi --- >From 105b5a413059ab8b134858be1b8d7fe53847bb44 Mon Sep 17 00:00:00 2001 From: Junfeng Guo Date: Thu, 10 Feb 2022 15:06:34 +0800 Subject: [PATCH] raw/ntb: clear all valid doorbell bits on init [ upstream commit 3bc814fc555d8c7d1c7c63e1e831e9c34679837f ] Before registering the doorbell interrupt handler callback function, all the valid doorbell bits within the NTB private data struct should be cleared to avoid the confusion of the handshake timing sequence diagram when setting up the NTB connection in back-to-back mode. Fixes: 62012a76811e ("raw/ntb: add handshake process") Signed-off-by: Junfeng Guo Acked-by: Jingjing Wu --- drivers/raw/ntb/ntb.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c index 6703bb5d08..4e22fb3733 100644 --- a/drivers/raw/ntb/ntb.c +++ b/drivers/raw/ntb/ntb.c @@ -1401,6 +1401,10 @@ ntb_init_hw(struct rte_rawdev *dev, struct rte_pci_device *pci_dev) /* Init doorbell. */ hw->db_valid_mask = RTE_LEN2MASK(hw->db_cnt, uint64_t); + /* Clear all valid doorbell bits before registering intr handler */ + if (hw->ntb_ops->db_clear == NULL) + return -ENOTSUP; + (*hw->ntb_ops->db_clear)(dev, hw->db_valid_mask); intr_handle = &pci_dev->intr_handle; /* Register callback func to eal lib */ -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-18 12:37:42.363815423 +0000 +++ 0121-raw-ntb-clear-all-valid-doorbell-bits-on-init.patch 2022-02-18 12:37:37.886796297 +0000 @@ -1 +1 @@ -From 3bc814fc555d8c7d1c7c63e1e831e9c34679837f Mon Sep 17 00:00:00 2001 +From 105b5a413059ab8b134858be1b8d7fe53847bb44 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3bc814fc555d8c7d1c7c63e1e831e9c34679837f ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 46ac02e5ab..f5e773c53b 100644 +index 6703bb5d08..4e22fb3733 100644 @@ -24 +25 @@ -@@ -1398,6 +1398,10 @@ ntb_init_hw(struct rte_rawdev *dev, struct rte_pci_device *pci_dev) +@@ -1401,6 +1401,10 @@ ntb_init_hw(struct rte_rawdev *dev, struct rte_pci_device *pci_dev) @@ -33 +34 @@ - intr_handle = pci_dev->intr_handle; + intr_handle = &pci_dev->intr_handle;