From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 314E2A0032 for ; Fri, 18 Feb 2022 13:41:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C52C40141; Fri, 18 Feb 2022 13:41:18 +0100 (CET) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mails.dpdk.org (Postfix) with ESMTP id B87E840E2D for ; Fri, 18 Feb 2022 13:41:16 +0100 (CET) Received: by mail-wm1-f49.google.com with SMTP id w13so4673142wmi.2 for ; Fri, 18 Feb 2022 04:41:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=944Foh+9MlBZ6SVB3na7xcYM7GVZxxL5qKlhOoAf8PQ=; b=ZatqwC2j+GIVLXRyRFmQ4hyhoae1XIYmeiin5K5OztLJWPft8zuPifzK0iyp8+Qtrl BwCjNTNniiogh2Bm6FDSyP07EMNe10g9BCcGyclYv50TG/616xbUdPzd/BYGrQngHXc9 mIteNE0GBK7TaSrW0kdC8vQsPH+729utGbXVXoRpVbQnVAMPdIiCL7E/oT3b1TMUHIN6 8MysiTHJ4EoW/YJL8w+He2le9beMWHoLt1Ng5va9Ws1OcdI7PeFCSEWpu5MfvjFeB+S9 aH2pUmzs9FYDIautrdlnPfCEs/szMHpS/ZdDK3BuAI2ExPmitmVhWk+hJ94419UKK7+9 mu7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=944Foh+9MlBZ6SVB3na7xcYM7GVZxxL5qKlhOoAf8PQ=; b=CNFr43jn2YfWmv+JUzH0O7Kh+bUk671738nvdMslMir0ziAXMzxsbQGCTTyEh93Rl+ MjGAjOxv5W010BA1RsdfzV0IR3PU7VzfnkqHiSl0i6vzM9uagi/3A5MKCtS5+DjKmTKh iIZtT6BmZBv53rWKKjYA3ae8IHI31lLPneqtT10KBqjkdRNDZwAghIrTBPoYg4dSG7rN /VbS44IVT7oaUiVWsgJmoKifVdPdP/qjoGF8gktxMkjVx9IDSS7ghCQD8PkmYjsNyC92 mVC8T6kU6fLGHo9rrN3Ks/BBWM3VLZAcdsVa69JFyXKeP2cvHK04T8SUGxRg+3VAiMKH sOyg== X-Gm-Message-State: AOAM531vdLVSvrAFX39Vzh3i0zYCd3DRvq2ocgXVH/jkY9rWzDymgA75 b591baJCoDVGSecGo0joXLyG35Jt97Bf/7Lf X-Google-Smtp-Source: ABdhPJwyVzIEK6A/09zkbmUXTKcN+TWQn16raEqpwgL2tBmb/9x4KVy/ws/yyicI4USSA0MqeCiwbw== X-Received: by 2002:a1c:a942:0:b0:37b:e02c:5ac2 with SMTP id s63-20020a1ca942000000b0037be02c5ac2mr10562695wme.12.1645188076416; Fri, 18 Feb 2022 04:41:16 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id q13sm42039103wrd.78.2022.02.18.04.41.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 04:41:15 -0800 (PST) From: luca.boccassi@gmail.com To: Kalesh AP Cc: Ajit Khaparde , Somnath Kotur , dpdk stable Subject: patch 'net/bnxt: fix xstats query' has been queued to stable release 20.11.5 Date: Fri, 18 Feb 2022 12:38:02 +0000 Message-Id: <20220218123931.1749595-33-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218123931.1749595-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/31080d4c6216c9f8abfe6107235324a878c01eb2 Thanks. Luca Boccassi --- >From 31080d4c6216c9f8abfe6107235324a878c01eb2 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 4 Jan 2022 14:08:23 +0530 Subject: [PATCH] net/bnxt: fix xstats query [ upstream commit c05c22f9b8032c2974de7042ba8c38fb42ed7c82 ] Fix incorrect memset in bnxt_dev_xstats_get_op. In bnxt_dev_xstats_get_op(), the PMD is not zeroing the whole buffer supplied by the application. This can end up passing junk statistics values to the application when the FW does not support extended stats on a function. Fixed to call memset() with correct size. Fixes: f55e12f33416 ("net/bnxt: support extended port counters") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index a35461677c..41997fcaa5 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -735,7 +735,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, (bp->fw_tx_port_stats_ext_size / stat_size)); - memset(xstats, 0, sizeof(*xstats)); + memset(xstats, 0, sizeof(*xstats) * n); count = 0; for (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) { -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-18 12:37:39.406020210 +0000 +++ 0033-net-bnxt-fix-xstats-query.patch 2022-02-18 12:37:37.618790312 +0000 @@ -1 +1 @@ -From c05c22f9b8032c2974de7042ba8c38fb42ed7c82 Mon Sep 17 00:00:00 2001 +From 31080d4c6216c9f8abfe6107235324a878c01eb2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c05c22f9b8032c2974de7042ba8c38fb42ed7c82 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 197fd7c02b..208aa5616d 100644 +index a35461677c..41997fcaa5 100644 @@ -27 +28 @@ -@@ -741,7 +741,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, +@@ -735,7 +735,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,