From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9325FA0032 for ; Fri, 18 Feb 2022 13:41:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E6C440141; Fri, 18 Feb 2022 13:41:51 +0100 (CET) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mails.dpdk.org (Postfix) with ESMTP id 5CD7140E2D for ; Fri, 18 Feb 2022 13:41:50 +0100 (CET) Received: by mail-wr1-f41.google.com with SMTP id e3so14457921wra.0 for ; Fri, 18 Feb 2022 04:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2twaUiQy/pL0Id/pI2kYHGodGHBY9ow/9nRAqGeKifs=; b=UTnt4NTIyK2rfoZDl0DVLbIYLUssgei003k0GMoyeNkKxNSXhOAxPUn9/Eg4sK0svA TeSvS7hAcLfSjgzwuQYBgIe+V8YZEe0EZC47Lo9KLs6l2xLLYNEtWPi6FBowsiFXDTy8 hY9lmnFNqSzgkmqb5c9/g/QqUUUHqvzOjWNsjVl4AlcdPgGSGibvSRyrhlZwaBTYVGYE AjE/DbJ+jUp/7tsCyYmzCOdwZoOuTR9uALnUtasfLR1bzOOFgfO/JvpswqnWSBJtSHVp uJy+XkbSXG/9AaNWJeF+zcvrLZIXb+ID5bFM0g6lmpXSjeDvZ5qL8fEPfK+YlS0cNyZX hKhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2twaUiQy/pL0Id/pI2kYHGodGHBY9ow/9nRAqGeKifs=; b=OgPfIGMZkkO0+8ZgTJ8LVRzbJyPGDFcAk/yXIQh6ywwjACsCwADaWtCiGgBTA8mFte 1nN6qu42RcM4LrgWx44DjW1AAE0ReB21zbXQokUWize311dwElqPMGJcrBcyCiEQhaWA NqMWrTQSV3511ShOyMpWHmoGknehDzWHLUD4OXK71V7eCfXXWVYknzy3Nq72rhacXcEI Fnq1j6800nfnvixj8gvsmr3XUl+Morbh88k8MHZZe+AMC7GS1r6NmUDlQgvbth0sp4rK tt4Knimg52i+5E1yGk5hg/god5URjyZDNDE1Dp3mMEfnfeknExE9RcJjFRA1TT+VFAyE 1OXg== X-Gm-Message-State: AOAM533hRtSK1Z31ZobvYG+8i+jC49hiBf9B1ERRR6qguBqUJ34YjQbW vD7tuLOfNAv4xq3TkVvfUI2gOCcWOzwtNn/h X-Google-Smtp-Source: ABdhPJzwTeDWSwBZF7BvnP2phGpfFcTEeFvhHKsHJoG6rHV5KP6Y2fbCNv9R87rGV23yoBXQAgKXNA== X-Received: by 2002:a5d:6b4c:0:b0:1e6:8ece:62e8 with SMTP id x12-20020a5d6b4c000000b001e68ece62e8mr6052121wrw.201.1645188110038; Fri, 18 Feb 2022 04:41:50 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id r2sm31215411wrt.65.2022.02.18.04.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 04:41:49 -0800 (PST) From: luca.boccassi@gmail.com To: Alexander Kozyrev Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix maximum packet headers size for TSO' has been queued to stable release 20.11.5 Date: Fri, 18 Feb 2022 12:38:14 +0000 Message-Id: <20220218123931.1749595-45-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218123931.1749595-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/f06710409fe86576476b94e40b86348ed4ff241c Thanks. Luca Boccassi --- >From f06710409fe86576476b94e40b86348ed4ff241c Mon Sep 17 00:00:00 2001 From: Alexander Kozyrev Date: Thu, 13 Jan 2022 16:32:29 +0200 Subject: [PATCH] net/mlx5: fix maximum packet headers size for TSO [ upstream commit 9701034faab0f84ba42e1f5343afda5464b11ca3 ] The maximum packet headers size for TSO is calculated as a sum of Ethernet, VLAN, IPv6 and TCP headers (plus inner headers). The rationale behind choosing IPv6 and TCP is their headers are bigger than IPv4 and UDP respectively, giving us the maximum possible headers size. But it is not true for L3 headers. IPv4 header size (20 bytes) is smaller than IPv6 header size (40 bytes) only in the default case. There are up to 10 optional header fields called Options in case IHL > 5. This means that the maximum size of the IPv4 header is 60 bytes. Choosing the wrong maximum packets headers size causes inability to transmit multi-segment TSO packets with IPv4 Options present. PMD check that it is possible to inline all the packet headers and the packet headers size exceeds the expected maximum size. The maximum packet headers size was set to 192 bytes before, but its value has been reduced during Tx path refactor activity. Restore the proper maximum packet headers size for TSO. Fixes: 50724e1bba76 ("net/mlx5: update Tx definitions") Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h index aa55db3750..db6f128f62 100644 --- a/drivers/net/mlx5/mlx5_defs.h +++ b/drivers/net/mlx5/mlx5_defs.h @@ -59,7 +59,7 @@ #define MLX5_MAX_XSTATS 32 /* Maximum Packet headers size (L2+L3+L4) for TSO. */ -#define MLX5_MAX_TSO_HEADER (128u + 34u) +#define MLX5_MAX_TSO_HEADER 192U /* Inline data size required by NICs. */ #define MLX5_INLINE_HSIZE_NONE 0 -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-18 12:37:39.813506739 +0000 +++ 0045-net-mlx5-fix-maximum-packet-headers-size-for-TSO.patch 2022-02-18 12:37:37.658791205 +0000 @@ -1 +1 @@ -From 9701034faab0f84ba42e1f5343afda5464b11ca3 Mon Sep 17 00:00:00 2001 +From f06710409fe86576476b94e40b86348ed4ff241c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9701034faab0f84ba42e1f5343afda5464b11ca3 ] + @@ -25 +26,0 @@ -Cc: stable@dpdk.org @@ -34 +35 @@ -index 36b384fa08..2d48fde010 100644 +index aa55db3750..db6f128f62 100644 @@ -37 +38 @@ -@@ -50,7 +50,7 @@ +@@ -59,7 +59,7 @@