From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4650AA0032 for ; Fri, 18 Feb 2022 13:42:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40A6F41140; Fri, 18 Feb 2022 13:42:38 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id C52B840395 for ; Fri, 18 Feb 2022 13:42:36 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id k41so5182421wms.0 for ; Fri, 18 Feb 2022 04:42:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O4tBL9pC+BLFpKAU/DH3xZWpd7+KUiFV8RYpdX+K35M=; b=B0HUbOCtKmi59nozLGdHXE3bHKbBeuywvTctNmtFjCwoAPr6YfIS5egRRpTNzII2KK C9fGRMXKeqNFM7uwgYn3Hm+7d2GvhWiWCmyYil63MpbM49/0Y08VseyOr/v9ByThzATQ nIO2gb5KH/IV0G8A5H+EPHj15kLWN1Lkx4p7kC9D1RFShYTzCwKmEQgzXo2oCvj2RJhS /gwtHoEtm1d4VPYjgKGLrWOqrf3N0v+4CONkrIO7JNu3JA650Unj/Q9HZ0Vb8r5KH7rr S4VFt6sVwJ1wRINSUoTrRwBL6EvW+PQQLXSNWdZqU8iNqJ+NsKPzWheExZqA6W7IeiQi 4K/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O4tBL9pC+BLFpKAU/DH3xZWpd7+KUiFV8RYpdX+K35M=; b=lqBoEytu0pSc5hw5dwoeelsFtnKVJVuN3+yvmdeFKOXQaulXLlr8vuGlANkXFlrGLJ g7Q4gvW8W90z0sk4ERWhKOTEx70V7uxnhjUHQEGiADkU+IDUEPOzcaHy0RDDyTw/hUe3 yyU6ism7PeU6fTcJgM3jHXYrfKfyYSm8+xM6sZin6qB6eMZAJx1HIx3/vygQ5d5pxZxA rJME23IMLaPHeEVW6FOGdW2enq9NbdpilBLtZC6L4KR/wZNbaPXj118myf+v6CYvIWuH NyXQ7mRg4CClyRN8wGyCRrGbBpYtvVuyasoW+vcNdN+1AB/oQCzO40ewDVYGYFY+l2FW aGfw== X-Gm-Message-State: AOAM533zPhvpU87TvWlntpITvZNxAcIFEgy0EP7A3s+sbo9xsSvk2pqg ZHgRWhmkgEzqL6SxNowLIbalazo8vT+d+er1 X-Google-Smtp-Source: ABdhPJx3Kru+pR657jBTxlDWhhf8L/U51/Bcl+O2ixLsp6P2hj08ssziGpO28SJ/ZdDi3NyPKZCPOw== X-Received: by 2002:a05:600c:1e0e:b0:37c:6c82:72a6 with SMTP id ay14-20020a05600c1e0e00b0037c6c8272a6mr10432551wmb.35.1645188156476; Fri, 18 Feb 2022 04:42:36 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id k28sm4751213wms.23.2022.02.18.04.42.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 04:42:35 -0800 (PST) From: luca.boccassi@gmail.com To: Matan Azrad Cc: Xueming Li , Maxime Coquelin , dpdk stable Subject: patch 'vdpa/mlx5: workaround queue stop with traffic' has been queued to stable release 20.11.5 Date: Fri, 18 Feb 2022 12:38:29 +0000 Message-Id: <20220218123931.1749595-60-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218123931.1749595-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/16ba91d4f3c0bd6d03b2ed5a4f09842ec8b0de73 Thanks. Luca Boccassi --- >From 16ba91d4f3c0bd6d03b2ed5a4f09842ec8b0de73 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Mon, 22 Nov 2021 15:12:35 +0200 Subject: [PATCH] vdpa/mlx5: workaround queue stop with traffic [ upstream commit b5e51edfbe18ee30b8fed5efdb09f2ab4c8a05a0 ] When the event thread polls traffic and a virtq is stopping, the FW loses synchronization in the virtq indexes. It causes LM failure on synchronization between the HOST indexes to the GUEST indexes. Unset the event thread before the queue stop in the LM process. Fixes: 31b9c29c86af ("vdpa/mlx5: support close and config operations") Signed-off-by: Matan Azrad Acked-by: Xueming Li Reviewed-by: Maxime Coquelin --- drivers/vdpa/mlx5/mlx5_vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index 38a93d041d..06e602e72a 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c @@ -281,10 +281,10 @@ mlx5_vdpa_dev_close(int vid) DRV_LOG(ERR, "Invalid vDPA device: %s.", vdev->device->name); return -1; } - if (priv->configured) - ret |= mlx5_vdpa_lm_log(priv); mlx5_vdpa_err_event_unset(priv); mlx5_vdpa_cqe_event_unset(priv); + if (priv->configured) + ret |= mlx5_vdpa_lm_log(priv); mlx5_vdpa_steer_unset(priv); mlx5_vdpa_virtqs_release(priv); mlx5_vdpa_event_qp_global_release(priv); -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-18 12:37:40.310942302 +0000 +++ 0060-vdpa-mlx5-workaround-queue-stop-with-traffic.patch 2022-02-18 12:37:37.694792009 +0000 @@ -1 +1 @@ -From b5e51edfbe18ee30b8fed5efdb09f2ab4c8a05a0 Mon Sep 17 00:00:00 2001 +From 16ba91d4f3c0bd6d03b2ed5a4f09842ec8b0de73 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b5e51edfbe18ee30b8fed5efdb09f2ab4c8a05a0 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index b9e84dd9bf..8dfaba791d 100644 +index 38a93d041d..06e602e72a 100644 @@ -28 +29 @@ -@@ -250,10 +250,10 @@ mlx5_vdpa_dev_close(int vid) +@@ -281,10 +281,10 @@ mlx5_vdpa_dev_close(int vid)