From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD3D6A0032 for ; Fri, 18 Feb 2022 13:39:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D82F741143; Fri, 18 Feb 2022 13:39:57 +0100 (CET) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id 9FB5F40141 for ; Fri, 18 Feb 2022 13:39:56 +0100 (CET) Received: by mail-wr1-f46.google.com with SMTP id e3so14449079wra.0 for ; Fri, 18 Feb 2022 04:39:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RuE6TQBQOOGipYcYVKI4r1qCX85921AQ8RKay5ZyqsI=; b=X/kQHzm3JaJ1Dd8wFpVIgB6OhU8pVsp8vTuAhr2a3GrruOiMTm5FimwGq1DihpSa6C GThGZHmSyqpBEJuNYhsqYRX0lltDxiMQ2D3Xe8y1q7BPlKzLIHKFKECUYP2LiKbMOCdQ +KbIu/8BhXT8geXS9LBjQwc5scAElAO2xRE+ZcqUVwXgKqIm8CcLqApNM00RbjoCk7pY U+INLtuKaIDDfCKO7m1tDIhMTSGtLKS4b0WWyNgKXkfNzVsTzYu1eSd4QkpmIXNMxnhp UrcUeuUrIyRLd54sffSYLPoJX10/nJvr3yN9vRXDMq5KObDOigUBr/iVAsqxIP5NZIcr 6zIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RuE6TQBQOOGipYcYVKI4r1qCX85921AQ8RKay5ZyqsI=; b=AXmN9fRxm65nIQQ1pU0Sm8eXBbMUxeq2REj81+cdPcv0aUO/YBTReGKA5tSNXJlJU2 oQB+8gl1fccAPsQb0DWvvM/Rvo5bXnxT65X6mychWz6Ugkww6YjRlOX2ih9eNzkptaW2 TxWmTvL4Dt5VImz54rJKFIExn0mNaXuzeIYVJW2lBwniR2etJRaKdSfdTom+VOiFtbWN XXKfqh59fHLkoQnNb36vKnM8uqJP4ZUJ+HzG+OP1QQJz0kNVV4C4q8f3IEKIHmLQRXsi nlpMC5ZVEfVTfqUqmeOD6TnLVApAYT1CnM+PvaaL8vENMc9QvDDdXVQAUubXbJFy21jC yu3w== X-Gm-Message-State: AOAM530NXOZ/ebyHyKv/d8vJqkEgkRnJ0O2m9xtP+vHaYhfKpbzj5ifS 1OuEQiB4tx5bdcth3BNMijg= X-Google-Smtp-Source: ABdhPJy/W9nEJRzKAHllr0vjrAU3fkumcUjXmHlBGDkamCrvkMwM4jbyJhP4rYcaRqTwnGO5pUo9Hw== X-Received: by 2002:a5d:6951:0:b0:1e3:fc3:4275 with SMTP id r17-20020a5d6951000000b001e30fc34275mr5860269wrw.449.1645187996369; Fri, 18 Feb 2022 04:39:56 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id y4sm21692207wrd.54.2022.02.18.04.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 04:39:55 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Bruce Richardson , dpdk stable Subject: patch 'eal/linux: log hugepage create errors with filename' has been queued to stable release 20.11.5 Date: Fri, 18 Feb 2022 12:37:36 +0000 Message-Id: <20220218123931.1749595-7-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218123931.1749595-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/eb5a21b54a56616dff895ba2b9fa9f61cf76e1af Thanks. Luca Boccassi --- >From eb5a21b54a56616dff895ba2b9fa9f61cf76e1af Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 23 Dec 2021 11:21:58 -0800 Subject: [PATCH] eal/linux: log hugepage create errors with filename [ upstream commit 8a5a91401dc23ddab1ddea3667a17a615a25077f ] While debugging running DPDK service in a container, it is useful to see which file creation failed. Don't hide this failure with DEBUG. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/librte_eal/linux/eal_memalloc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/linux/eal_memalloc.c b/lib/librte_eal/linux/eal_memalloc.c index fa73468285..93e21f1321 100644 --- a/lib/librte_eal/linux/eal_memalloc.c +++ b/lib/librte_eal/linux/eal_memalloc.c @@ -308,8 +308,8 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi, if (fd < 0) { fd = open(path, O_CREAT | O_RDWR, 0600); if (fd < 0) { - RTE_LOG(ERR, EAL, "%s(): open failed: %s\n", - __func__, strerror(errno)); + RTE_LOG(ERR, EAL, "%s(): open '%s' failed: %s\n", + __func__, path, strerror(errno)); return -1; } /* take out a read lock and keep it indefinitely */ @@ -346,8 +346,8 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi, fd = open(path, O_CREAT | O_RDWR, 0600); if (fd < 0) { - RTE_LOG(DEBUG, EAL, "%s(): open failed: %s\n", - __func__, strerror(errno)); + RTE_LOG(ERR, EAL, "%s(): open '%s' failed: %s\n", + __func__, path, strerror(errno)); return -1; } /* take out a read lock */ -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-18 12:37:38.489585320 +0000 +++ 0007-eal-linux-log-hugepage-create-errors-with-filename.patch 2022-02-18 12:37:37.502787721 +0000 @@ -1 +1 @@ -From 8a5a91401dc23ddab1ddea3667a17a615a25077f Mon Sep 17 00:00:00 2001 +From eb5a21b54a56616dff895ba2b9fa9f61cf76e1af Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8a5a91401dc23ddab1ddea3667a17a615a25077f ] + @@ -10,2 +11,0 @@ -Cc: stable@dpdk.org - @@ -15 +15 @@ - lib/eal/linux/eal_memalloc.c | 8 ++++---- + lib/librte_eal/linux/eal_memalloc.c | 8 ++++---- @@ -18,4 +18,4 @@ -diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c -index 337f2bc739..16b58d861b 100644 ---- a/lib/eal/linux/eal_memalloc.c -+++ b/lib/eal/linux/eal_memalloc.c +diff --git a/lib/librte_eal/linux/eal_memalloc.c b/lib/librte_eal/linux/eal_memalloc.c +index fa73468285..93e21f1321 100644 +--- a/lib/librte_eal/linux/eal_memalloc.c ++++ b/lib/librte_eal/linux/eal_memalloc.c