From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0711AA0032 for ; Fri, 18 Feb 2022 13:39:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01DCC40141; Fri, 18 Feb 2022 13:39:59 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id BDE3141142 for ; Fri, 18 Feb 2022 13:39:57 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id x3-20020a05600c21c300b0037c01ad715bso6330510wmj.2 for ; Fri, 18 Feb 2022 04:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R1OMbKVYCcUrsS2hecIkoZ5lrPVUs4Pc5DUCZ3xNZEM=; b=S57mJIMDe1ad0DfOysV7xrQICZ8WEUabe8Jm90Yk0NPJXwfykF4AgyhmJCCEYa9HF3 cU4wq6ytI11w2KTEbvOt9RkX22gBIwBtZdX7uWy4oFWMnkx79Uc2NrzKoKAQ/K0xHf0Z cxKtUM7Mq9WDwg38spxW9edsJ+S5xrGowU0sABBAqx6+6COfGyBwEBjSppbA/MwHjVxY uOM/aIflybr3iOHX+GXpFnLoobluh4oi+QceDBV6BCd0YCRptVQvNnaISsKELRXkcSM8 CcaC+JkoaVw3Frdcr6zJgfbJpTcaNyxCyEg//aq2hNZU//5hJeEM4+tZpGo4vwbi6gLG kJsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R1OMbKVYCcUrsS2hecIkoZ5lrPVUs4Pc5DUCZ3xNZEM=; b=tv5jcOyD9kuPOtMyJLj9NRurUNSn69hj/woggs9EYLrY/cQoX0VDsPXCr+OFyMjl/a gDXq3+PtlYw7OpG73GTAPqdzJk1bjoFtBQhp2Qw+HICKsOrOcJ1HJYJFtcw55CjGRXiq ihb7WkzT195bmKqepa8iAi57zmTH2AvkdS8hyoUbLBBhCxbgA9WHdGNbupG0cLunB2OG GSmTPactJHEE5tHzAlHqfCvNea8ZlIx0928U13zeiOf5OqVFeDGWnljgQTXX4DlgzYH4 QDpLGODRN+0dETyvD7J8Gl9wLzjXC3wG/fh93Cqy4H5dRZeOYBTwR3Yc7ptMHG+he+RD pIkw== X-Gm-Message-State: AOAM53255GAO2i5giaFirGfiUcH0eH8c2iyvtdJMSTJ429y1FubljQkK g3h99VpQUgvjux7UIPcdBUVn0rEfhNItig== X-Google-Smtp-Source: ABdhPJySxxhf0uKxsw8JqcNNYdqfOrOmmW1R6HjXzZY8NBhwEGqIgrFSKceLek1EUzTuakKQxnHNqQ== X-Received: by 2002:a7b:c742:0:b0:37b:dea5:3539 with SMTP id w2-20020a7bc742000000b0037bdea53539mr6996220wmk.38.1645187997484; Fri, 18 Feb 2022 04:39:57 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id r2sm6084021wmq.0.2022.02.18.04.39.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 04:39:56 -0800 (PST) From: luca.boccassi@gmail.com To: Rashmi Shetty Cc: Timothy McDaniel , dpdk stable Subject: patch 'doc: fix dlb2 guide' has been queued to stable release 20.11.5 Date: Fri, 18 Feb 2022 12:37:37 +0000 Message-Id: <20220218123931.1749595-8-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218123931.1749595-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/6bfaf85e5bcd99e4225fe1f721cec27c5c4120c3 Thanks. Luca Boccassi --- >From 6bfaf85e5bcd99e4225fe1f721cec27c5c4120c3 Mon Sep 17 00:00:00 2001 From: Rashmi Shetty Date: Tue, 7 Dec 2021 17:01:51 -0600 Subject: [PATCH] doc: fix dlb2 guide [ upstream commit 7fe2d346af2f3cae0e94347861cdfa412af39fc2 ] Number of direct credits, atomic inflight and history list are updated to DLB2.0 supported sizes. As DLB2.0 does not provide dev arg to override the default per-queue atomic inflight allocation, it is removed from the documentation. Fixes: f3cad285bb88 ("event/dlb2: add infos get and configure") Signed-off-by: Rashmi Shetty Reviewed-by: Timothy McDaniel --- doc/guides/eventdevs/dlb2.rst | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/doc/guides/eventdevs/dlb2.rst b/doc/guides/eventdevs/dlb2.rst index 1223219cf7..834e2242a9 100644 --- a/doc/guides/eventdevs/dlb2.rst +++ b/doc/guides/eventdevs/dlb2.rst @@ -178,7 +178,7 @@ A DLB2 eventdev contains one load-balanced and one directed credit pool. These pools' sizes are controlled by the nb_events_limit field in struct rte_event_dev_config. The load-balanced pool is sized to contain nb_events_limit credits, and the directed pool is sized to contain -nb_events_limit/4 credits. The directed pool size can be overridden with the +nb_events_limit/2 credits. The directed pool size can be overridden with the num_dir_credits devargs argument, like so: .. code-block:: console @@ -266,8 +266,8 @@ queue A. Due to this, workers should stop retrying after a time, release the events it is attempting to enqueue, and dequeue more events. It is important that the worker release the events and don't simply set them aside to retry the enqueue -again later, because the port has limited history list size (by default, twice -the port's dequeue_depth). +again later, because the port has limited history list size (by default, same +as port's dequeue_depth). Priority ~~~~~~~~ @@ -330,18 +330,11 @@ scheduled. The likelihood of this case depends on the eventdev configuration, traffic behavior, event processing latency, potential for a worker to be interrupted or otherwise delayed, etc. -By default, the PMD allocates 16 buffer entries for each load-balanced queue, -which provides an even division across all 128 queues but potentially wastes +By default, the PMD allocates 64 buffer entries for each load-balanced queue, +which provides an even division across all 32 queues but potentially wastes buffer space (e.g. if not all queues are used, or aren't used for atomic scheduling). -The PMD provides a dev arg to override the default per-queue allocation. To -increase per-queue atomic-inflight allocation to (for example) 64: - - .. code-block:: console - - --allow ea:00.0,atm_inflights=64 - QID Depth Threshold ~~~~~~~~~~~~~~~~~~~ @@ -358,7 +351,7 @@ Per queue threshold metrics are tracked in the DLB2 xstats, and are also returned in the impl_opaque field of each received event. The per qid threshold can be specified as part of the device args, and -can be applied to all queue, a range of queues, or a single queue, as +can be applied to all queues, a range of queues, or a single queue, as shown below. .. code-block:: console -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-18 12:37:38.521402437 +0000 +++ 0008-doc-fix-dlb2-guide.patch 2022-02-18 12:37:37.502787721 +0000 @@ -1 +1 @@ -From 7fe2d346af2f3cae0e94347861cdfa412af39fc2 Mon Sep 17 00:00:00 2001 +From 6bfaf85e5bcd99e4225fe1f721cec27c5c4120c3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7fe2d346af2f3cae0e94347861cdfa412af39fc2 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index bce984ca08..bc53618b53 100644 +index 1223219cf7..834e2242a9 100644 @@ -24,2 +25,2 @@ -@@ -151,7 +151,7 @@ load-balanced queues, and directed credits are used for directed queues. - These pools' sizes are controlled by the nb_events_limit field in struct +@@ -178,7 +178,7 @@ A DLB2 eventdev contains one load-balanced and one directed credit pool. These + pools' sizes are controlled by the nb_events_limit field in struct @@ -33 +34 @@ -@@ -239,8 +239,8 @@ queue A. +@@ -266,8 +266,8 @@ queue A. @@ -44 +45 @@ -@@ -309,18 +309,11 @@ scheduled. The likelihood of this case depends on the eventdev configuration, +@@ -330,18 +330,11 @@ scheduled. The likelihood of this case depends on the eventdev configuration, @@ -65 +66 @@ -@@ -337,7 +330,7 @@ Per queue threshold metrics are tracked in the DLB xstats, and are also +@@ -358,7 +351,7 @@ Per queue threshold metrics are tracked in the DLB2 xstats, and are also