From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8E8CA0032 for ; Fri, 18 Feb 2022 13:44:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF6CC41142; Fri, 18 Feb 2022 13:44:09 +0100 (CET) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id 7F76C40141 for ; Fri, 18 Feb 2022 13:44:08 +0100 (CET) Received: by mail-wr1-f53.google.com with SMTP id f3so14244907wrh.7 for ; Fri, 18 Feb 2022 04:44:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cyn4cofWL5kBMLtglRH+jnsIwAKGecIMQ56Mg6Ff0fQ=; b=VL43z7sVaxRYDOZ0FkzzyuxPvq5d49EuwEmRPzZ/EMpEkVNZs/0GsYx35VYW5j2ZfI i8mFNf3bazwTTFKnqwBmH/Hu3Fau885L5rQxO6mlvwOIRPwB+kddZ2y6mMnSVqa+Kot9 ZKBtLAC5xyvKVUNtMvvB9/AC4RAycO8ap7TgTjxGZcRlyLceE4iSyfssGKXLsFri3z5P FcswcBgQiNhMzhO7aXsb+r/BZ0NpXuxjKuYpmxMKkj2T6vk0Xkc3sq566oMO1dUx0fJC TEG95IhAq9t+a9OQgbgGETRMIVftMSHtNpMwRNYU0eRMVdZzZzpNj9DKmS7+3cAtJL5N QtZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cyn4cofWL5kBMLtglRH+jnsIwAKGecIMQ56Mg6Ff0fQ=; b=Ods12GrFQUJdgqqW/qDgwWdPPetRNKkbs8AAuNpIJR7k1SyZbUz5Cj7L5kiVVdj4KA 6A1Kq0Y5ey75wkoAhv0sMnQq6CpqV/Cn5uavzSpi2KPcFlpTmgPwq7En4oty1FLf8R+Y 3X9esE5TNXzLopacXLVamePHYHeVj+wBGOEpJ7tkixQa3jCl3td8oBU+wReSdGF1/IVF tZXFq/tdwoBH7DlqCpvAEtqbJXfeaqrLUjRPXbZ81/KLWIUPl2eCnldBSGsTGo7DaJbh uVRqOct1vXe1jb3cMCmSnM0cClQSy0n5d/zoZUl6umONu4Aivg7rDN7TrbOMmSwWhkp2 7eeg== X-Gm-Message-State: AOAM532TVeZPRiPncPUYvIgIrNQeEqHdioyZGbtjjKncoVlk3ruhKFyo qn1iBZ40NS7pIGHG6aniLwAXh26YaEK15Z5Z X-Google-Smtp-Source: ABdhPJzRccBdHFb/fshhlaDGlTt/BsJkUcUErXv9hs7p9AtntTEq68hdSi7vbloLysuHltRb1sj35Q== X-Received: by 2002:a5d:4989:0:b0:1e3:1d25:528 with SMTP id r9-20020a5d4989000000b001e31d250528mr5937884wrq.472.1645188248235; Fri, 18 Feb 2022 04:44:08 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id v5sm21492474wrr.7.2022.02.18.04.44.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 04:44:07 -0800 (PST) From: luca.boccassi@gmail.com To: "Min Hu (Connor)" Cc: dpdk stable Subject: patch 'net/bonding: fix reference count on mbufs' has been queued to stable release 20.11.5 Date: Fri, 18 Feb 2022 12:38:59 +0000 Message-Id: <20220218123931.1749595-90-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218123931.1749595-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/c4a4ba788f6369745ca3a5aa70a7c3f1f8d69be0 Thanks. Luca Boccassi --- >From c4a4ba788f6369745ca3a5aa70a7c3f1f8d69be0 Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Fri, 28 Jan 2022 10:25:33 +0800 Subject: [PATCH] net/bonding: fix reference count on mbufs [ upstream commit 814e79f3afad8c45c6922617f26292af3221ae2b ] In bonding Tx broadcast mode, Packets should be sent by every slave, but only one mbuf exits. The solution is to increment reference count on mbufs, but it ignores multi segments. This patch fixed it by adding reference for every segment in multi segments Tx scenario. Fixes: 2efb58cbab6e ("bond: new link bonding library") Signed-off-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 6857b474af..d7bc0f0875 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1322,7 +1322,7 @@ bond_ethdev_tx_burst_broadcast(void *queue, struct rte_mbuf **bufs, /* Increment reference count on mbufs */ for (i = 0; i < nb_pkts; i++) - rte_mbuf_refcnt_update(bufs[i], num_of_slaves - 1); + rte_pktmbuf_refcnt_update(bufs[i], num_of_slaves - 1); /* Transmit burst on each active slave */ for (i = 0; i < num_of_slaves; i++) { -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-18 12:37:41.329766748 +0000 +++ 0090-net-bonding-fix-reference-count-on-mbufs.patch 2022-02-18 12:37:37.798794333 +0000 @@ -1 +1 @@ -From 814e79f3afad8c45c6922617f26292af3221ae2b Mon Sep 17 00:00:00 2001 +From c4a4ba788f6369745ca3a5aa70a7c3f1f8d69be0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 814e79f3afad8c45c6922617f26292af3221ae2b ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index d2fcfad676..bfa931098e 100644 +index 6857b474af..d7bc0f0875 100644 @@ -25 +26 @@ -@@ -1318,7 +1318,7 @@ bond_ethdev_tx_burst_broadcast(void *queue, struct rte_mbuf **bufs, +@@ -1322,7 +1322,7 @@ bond_ethdev_tx_burst_broadcast(void *queue, struct rte_mbuf **bufs,