From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3927A0350 for ; Mon, 21 Feb 2022 16:39:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED9284013F; Mon, 21 Feb 2022 16:39:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1236A410F3 for ; Mon, 21 Feb 2022 16:39:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645457986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0MDcu1BADdApbBI7id0MCNwyRJVTXYsmfly/ZD0ujZI=; b=SwnFXfxJtALLWNBg0+Ypf/sqSMl1/FBda0d2TkElU4uA3LBb29j5vVTwrzADsLBKWsy7sE 1hSYmwjBq96G1Mp9+XEN1f6xkIxPrAfkvCSiem3PfjF6A/fgdkXO7Fk+2o43Of7Q1k/WPK aV6qWP/EIEfuPizuboEWJ0ykG6z5I84= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-_dOZg3QUMLOD3v-oy_AMTQ-1; Mon, 21 Feb 2022 10:39:43 -0500 X-MC-Unique: _dOZg3QUMLOD3v-oy_AMTQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5468F100C660; Mon, 21 Feb 2022 15:39:42 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id E79817B9D9; Mon, 21 Feb 2022 15:39:40 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , Ferruh Yigit , dpdk stable Subject: patch 'net/memif: remove unnecessary Rx interrupt stub' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:34:49 +0000 Message-Id: <20220221153625.152324-100-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/581e547a6fb5b8bc874d0abc60c6d4feb97a8082 Thanks. Kevin --- >From 581e547a6fb5b8bc874d0abc60c6d4feb97a8082 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 14 Jan 2022 12:46:44 -0800 Subject: [PATCH] net/memif: remove unnecessary Rx interrupt stub MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit d6dccbd76692c64cff79a821bc73069dc5b043e4 ] The code in memif driver to stub out rx_irq_enable is unnecessary and causes different error returns than other drivers. The core ethdev code will return -ENOTSUP if the driver has a null rx_queue_intr_enable callback. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Reviewed-by: Ferruh Yigit --- drivers/net/memif/rte_eth_memif.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 59cb5a82a2..d3459c5007 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -1501,21 +1501,4 @@ memif_stats_reset(struct rte_eth_dev *dev) } -static int -memif_rx_queue_intr_enable(struct rte_eth_dev *dev __rte_unused, - uint16_t qid __rte_unused) -{ - MIF_LOG(WARNING, "Interrupt mode not supported."); - - return -1; -} - -static int -memif_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t qid __rte_unused) -{ - struct pmd_internals *pmd __rte_unused = dev->data->dev_private; - - return 0; -} - static const struct eth_dev_ops ops = { .dev_start = memif_dev_start, @@ -1528,6 +1511,4 @@ static const struct eth_dev_ops ops = { .rx_queue_release = memif_rx_queue_release, .tx_queue_release = memif_tx_queue_release, - .rx_queue_intr_enable = memif_rx_queue_intr_enable, - .rx_queue_intr_disable = memif_rx_queue_intr_disable, .link_update = memif_link_update, .stats_get = memif_stats_get, -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:46.781078889 +0000 +++ 0100-net-memif-remove-unnecessary-Rx-interrupt-stub.patch 2022-02-21 15:22:44.200704371 +0000 @@ -1 +1 @@ -From d6dccbd76692c64cff79a821bc73069dc5b043e4 Mon Sep 17 00:00:00 2001 +From 581e547a6fb5b8bc874d0abc60c6d4feb97a8082 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit d6dccbd76692c64cff79a821bc73069dc5b043e4 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org