From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CFC8A0350 for ; Mon, 21 Feb 2022 16:39:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 480E8410F2; Mon, 21 Feb 2022 16:39:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 607D841147 for ; Mon, 21 Feb 2022 16:39:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645457988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FC/7da5ZB+cE+X5gDON/jOB3Qp2vhIdfe/wJ7kShTH4=; b=Ko72ltQI28/dVgpHCPwASirLz5H3nH6sY3g/d/8f6K/ixVs0WrfEPJfdcPrChB9AUflw1m lwn5JtygeZLFKGKgxpVfMaDxIoKDRAqWQtOA56wjcq51RRUESfZ10y/UvAVla6JQLOj0rn Hbz44bqbTt9jOdL4qxxJ3B+TOpHP+NQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-211-zkZxqSMOMSuHIHiJDaLPzg-1; Mon, 21 Feb 2022 10:39:45 -0500 X-MC-Unique: zkZxqSMOMSuHIHiJDaLPzg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B989E801AC5; Mon, 21 Feb 2022 15:39:44 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0E337B9D9; Mon, 21 Feb 2022 15:39:43 +0000 (UTC) From: Kevin Traynor To: Huisong Li Cc: dpdk stable Subject: patch 'net/hns3: fix mailbox wait time' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:34:51 +0000 Message-Id: <20220221153625.152324-102-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/9c10b251a11f4842109a1bb59ad08bd78d89831c Thanks. Kevin --- >From 9c10b251a11f4842109a1bb59ad08bd78d89831c Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Mon, 17 Jan 2022 10:43:01 +0800 Subject: [PATCH] net/hns3: fix mailbox wait time [ upstream commit 5a2b22b40f3052a8898194fd8c235440ad1d85d8 ] The mailbox wait time can be specified at runtime. But the variable that controls this time are not initialized when the variable isn't designated or is specified as an invalid value, which will fail to initialize device in the case where no device is bound to initialize the device. Fixes: 2fc3e696a7f1 ("net/hns3: add runtime config for mailbox limit time") Signed-off-by: Huisong Li --- drivers/net/hns3/hns3_common.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c index 0bb552ea3e..78158401f2 100644 --- a/drivers/net/hns3/hns3_common.c +++ b/drivers/net/hns3/hns3_common.c @@ -217,5 +217,5 @@ hns3_parse_mbx_time_limit(const char *key, const char *value, void *extra_args) /* * 500ms is empirical value in process of mailbox communication. If - * the delay value is set to one lower thanthe empirical value, mailbox + * the delay value is set to one lower than the empirical value, mailbox * communication may fail. */ @@ -237,4 +237,10 @@ hns3_parse_devargs(struct rte_eth_dev *dev) struct rte_kvargs *kvlist; + /* Set default value of runtime config parameters. */ + hns->rx_func_hint = HNS3_IO_FUNC_HINT_NONE; + hns->tx_func_hint = HNS3_IO_FUNC_HINT_NONE; + hns->dev_caps_mask = 0; + hns->mbx_time_limit_ms = HNS3_MBX_DEF_TIME_LIMIT_MS; + if (dev->device->devargs == NULL) return; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:46.823343567 +0000 +++ 0102-net-hns3-fix-mailbox-wait-time.patch 2022-02-21 15:22:44.203704378 +0000 @@ -1 +1 @@ -From 5a2b22b40f3052a8898194fd8c235440ad1d85d8 Mon Sep 17 00:00:00 2001 +From 9c10b251a11f4842109a1bb59ad08bd78d89831c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5a2b22b40f3052a8898194fd8c235440ad1d85d8 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org