From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 538FCA034E for ; Mon, 21 Feb 2022 16:37:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D86E41145; Mon, 21 Feb 2022 16:37:28 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0FB8D4013F for ; Mon, 21 Feb 2022 16:37:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645457846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UkTTjiK6jras1OhpWrF7e18ATWAF42T2kKuyFzbKYYs=; b=iA77GQCGLTWdSZlMDNhvhVcbYYYoYds0+FpLTcxDpELnWrk7dLj899wI8qLqNewrzusLMQ A6A/iwiQ/XrC9FCuvXp7/yX5gG7NeQwBQpQ19eb+je/VYiPHJkD4gvrXeYGU7qv98yexxR sGXeA9t3Uj5/1dHoH8DNiBHfUmtD68Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-526-td9okRi-Pqe3mk78Z37kGg-1; Mon, 21 Feb 2022 10:37:23 -0500 X-MC-Unique: td9okRi-Pqe3mk78Z37kGg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 34C88100C662; Mon, 21 Feb 2022 15:37:22 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 298A97E131; Mon, 21 Feb 2022 15:37:20 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Bruce Richardson , dpdk stable Subject: patch 'eal/linux: log hugepage create errors with filename' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:33:21 +0000 Message-Id: <20220221153625.152324-12-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/19c6e95cd6dd1876f807836ffcd2f98c2110bb1b Thanks. Kevin --- >From 19c6e95cd6dd1876f807836ffcd2f98c2110bb1b Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 23 Dec 2021 11:21:58 -0800 Subject: [PATCH] eal/linux: log hugepage create errors with filename [ upstream commit 8a5a91401dc23ddab1ddea3667a17a615a25077f ] While debugging running DPDK service in a container, it is useful to see which file creation failed. Don't hide this failure with DEBUG. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/eal/linux/eal_memalloc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c index 337f2bc739..16b58d861b 100644 --- a/lib/eal/linux/eal_memalloc.c +++ b/lib/eal/linux/eal_memalloc.c @@ -309,6 +309,6 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi, fd = open(path, O_CREAT | O_RDWR, 0600); if (fd < 0) { - RTE_LOG(ERR, EAL, "%s(): open failed: %s\n", - __func__, strerror(errno)); + RTE_LOG(ERR, EAL, "%s(): open '%s' failed: %s\n", + __func__, path, strerror(errno)); return -1; } @@ -347,6 +347,6 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi, fd = open(path, O_CREAT | O_RDWR, 0600); if (fd < 0) { - RTE_LOG(DEBUG, EAL, "%s(): open failed: %s\n", - __func__, strerror(errno)); + RTE_LOG(ERR, EAL, "%s(): open '%s' failed: %s\n", + __func__, path, strerror(errno)); return -1; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:44.946445113 +0000 +++ 0012-eal-linux-log-hugepage-create-errors-with-filename.patch 2022-02-21 15:22:44.038704006 +0000 @@ -1 +1 @@ -From 8a5a91401dc23ddab1ddea3667a17a615a25077f Mon Sep 17 00:00:00 2001 +From 19c6e95cd6dd1876f807836ffcd2f98c2110bb1b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8a5a91401dc23ddab1ddea3667a17a615a25077f ] + @@ -9,2 +10,0 @@ - -Cc: stable@dpdk.org