From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDC1EA0350 for ; Mon, 21 Feb 2022 16:40:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7570410F7; Mon, 21 Feb 2022 16:40:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3436F410F2 for ; Mon, 21 Feb 2022 16:40:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645458056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2R1t4pIial/s2bn/7jW2FIaeA2Og8IL/MrYzOg1eFm4=; b=D1obmt5Ox+QQhZScJUPD8ewixpYXRwJf36WE+7HNp6lunoZAnyg2m9LMm26V0XoEl3gK6W T7jRv+bnxmXNkP7+F7C7ZivSqAxJmABweK0z5N8sphvE5BhrBtPNZbGTti2CLmOBjySWGd uPeEx5+LRZr8mwOtf9s82UvECaR/690= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-590-uCInDdilMqeM5noHFIzlAA-1; Mon, 21 Feb 2022 10:40:53 -0500 X-MC-Unique: uCInDdilMqeM5noHFIzlAA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7CF98343CA; Mon, 21 Feb 2022 15:40:52 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 48AF57E2E8; Mon, 21 Feb 2022 15:40:51 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: Yu Jiang , Min Hu , dpdk stable Subject: patch 'net/bonding: fix MTU set for slaves' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:35:17 +0000 Message-Id: <20220221153625.152324-128-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2c27da1e514f9a1b3d033880c8601639242253c5 Thanks. Kevin --- >From 2c27da1e514f9a1b3d033880c8601639242253c5 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Wed, 26 Jan 2022 13:10:37 +0000 Subject: [PATCH] net/bonding: fix MTU set for slaves [ upstream commit 20a53b1927da67f62366752ae2d737cb4ded9b6e ] ethdev requires device to be configured before setting MTU. In bonding PMD, while configuring slaves, bonding first sets MTU later configures them, which causes failure if slaves are not configured in advance. Fixing by changing the order in slave configure as requested in ethdev layer, configure first and set MTU later. Bugzilla ID: 864 Fixes: b26bee10ee37 ("ethdev: forbid MTU set before device configure") Signed-off-by: Ferruh Yigit Tested-by: Yu Jiang Acked-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_pmd.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index c72fc64806..e5abe90e07 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1742,12 +1742,4 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, } - errval = rte_eth_dev_set_mtu(slave_eth_dev->data->port_id, - bonded_eth_dev->data->mtu); - if (errval != 0 && errval != -ENOTSUP) { - RTE_BOND_LOG(ERR, "rte_eth_dev_set_mtu: port %u, err (%d)", - slave_eth_dev->data->port_id, errval); - return errval; - } - /* Configure device */ errval = rte_eth_dev_configure(slave_eth_dev->data->port_id, @@ -1760,4 +1752,12 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, } + errval = rte_eth_dev_set_mtu(slave_eth_dev->data->port_id, + bonded_eth_dev->data->mtu); + if (errval != 0 && errval != -ENOTSUP) { + RTE_BOND_LOG(ERR, "rte_eth_dev_set_mtu: port %u, err (%d)", + slave_eth_dev->data->port_id, errval); + return errval; + } + /* Setup Rx Queues */ for (q_id = 0; q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) { -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:47.368271262 +0000 +++ 0128-net-bonding-fix-MTU-set-for-slaves.patch 2022-02-21 15:22:44.256704497 +0000 @@ -1 +1 @@ -From 20a53b1927da67f62366752ae2d737cb4ded9b6e Mon Sep 17 00:00:00 2001 +From 2c27da1e514f9a1b3d033880c8601639242253c5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 20a53b1927da67f62366752ae2d737cb4ded9b6e ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org