From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5D15A0350 for ; Mon, 21 Feb 2022 16:41:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2316410F2; Mon, 21 Feb 2022 16:41:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3A67B4068C for ; Mon, 21 Feb 2022 16:41:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645458068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uev555+5XlIxBg2MKf7I0YGtJjnvyAWtchT4E0KYIeM=; b=AaRx9y3Z9fhyhVD7sHT8Xy6hm9woopjrqTw/SAB+O054sN0j5itdlFe5WM3Me82bBjPjrv yF+ZLN+8KackoTbbiQ7TVw4ZXV7ijLtiLykqbbH0abHLfIB9PFJnvNc61JhK7Dsy5mIHjw e8/2QFrw1razoJmQdmqTRQvm0ML22mA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-132-7EqrRDQAPaWLD3UAkF50BQ-1; Mon, 21 Feb 2022 10:41:05 -0500 X-MC-Unique: 7EqrRDQAPaWLD3UAkF50BQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5435100C662; Mon, 21 Feb 2022 15:41:04 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 177F77E2E8; Mon, 21 Feb 2022 15:41:03 +0000 (UTC) From: Kevin Traynor To: "Min Hu (Connor)" Cc: dpdk stable Subject: patch 'net/bonding: fix reference count on mbufs' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:35:26 +0000 Message-Id: <20220221153625.152324-137-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/7b71bc2d00f8fcddd22ea80422ad1ee49ff83397 Thanks. Kevin --- >From 7b71bc2d00f8fcddd22ea80422ad1ee49ff83397 Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Fri, 28 Jan 2022 10:25:33 +0800 Subject: [PATCH] net/bonding: fix reference count on mbufs [ upstream commit 814e79f3afad8c45c6922617f26292af3221ae2b ] In bonding Tx broadcast mode, Packets should be sent by every slave, but only one mbuf exits. The solution is to increment reference count on mbufs, but it ignores multi segments. This patch fixed it by adding reference for every segment in multi segments Tx scenario. Fixes: 2efb58cbab6e ("bond: new link bonding library") Signed-off-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index d2fcfad676..bfa931098e 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1319,5 +1319,5 @@ bond_ethdev_tx_burst_broadcast(void *queue, struct rte_mbuf **bufs, /* Increment reference count on mbufs */ for (i = 0; i < nb_pkts; i++) - rte_mbuf_refcnt_update(bufs[i], num_of_slaves - 1); + rte_pktmbuf_refcnt_update(bufs[i], num_of_slaves - 1); /* Transmit burst on each active slave */ -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:47.561420491 +0000 +++ 0137-net-bonding-fix-reference-count-on-mbufs.patch 2022-02-21 15:22:44.279704549 +0000 @@ -1 +1 @@ -From 814e79f3afad8c45c6922617f26292af3221ae2b Mon Sep 17 00:00:00 2001 +From 7b71bc2d00f8fcddd22ea80422ad1ee49ff83397 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 814e79f3afad8c45c6922617f26292af3221ae2b ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org