From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAC18A0350 for ; Mon, 21 Feb 2022 16:41:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 897284013F; Mon, 21 Feb 2022 16:41:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 326844013F for ; Mon, 21 Feb 2022 16:41:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645458091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OTEAEPkaUBbZNopfppW73kNOd/HjS56yqXM+E0J2VRM=; b=GP0jKVuOFeBdgQcpTa0fHgcmEyDdpqde1WChONR0bAtJx/VFxxOxZHZT9K+BQvOYZJ9jGm 91AhrN8yCosnK6mDQh+oI8cAr4z+1cUlm8KRrvbWXq/RgcyWL3IF9CyRoiCLEYId18HUkT jcvLulMkM5GTHhkE59w4KqP8zkzgkOI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-664-Ye4Is520OLShT_nmG8-ETA-1; Mon, 21 Feb 2022 10:41:28 -0500 X-MC-Unique: Ye4Is520OLShT_nmG8-ETA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CD15E1091DA1; Mon, 21 Feb 2022 15:41:27 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 918A77E2E8; Mon, 21 Feb 2022 15:41:12 +0000 (UTC) From: Kevin Traynor To: Yuan Wang Cc: Maxime Coquelin , dpdk stable Subject: patch 'vhost: fix guest to host physical address mapping' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:35:32 +0000 Message-Id: <20220221153625.152324-143-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/160769f6486d584468ebcf4d50abf1ee9d4378ab Thanks. Kevin --- >From 160769f6486d584468ebcf4d50abf1ee9d4378ab Mon Sep 17 00:00:00 2001 From: Yuan Wang Date: Mon, 17 Jan 2022 16:20:27 +0000 Subject: [PATCH] vhost: fix guest to host physical address mapping [ upstream commit 8b764f460f168505b9335bdbd0e0fead8edbc188 ] Async copy fails when looking up hpa in the gpa to hpa mapping table. This happens because the gpa is matched exactly in the merged mapping table, and the merge loses the mapping entries. A new range comparison method is introduced to solve this issue. Fixes: 6563cf92380a ("vhost: fix async copy on multi-page buffers") Signed-off-by: Yuan Wang Reviewed-by: Maxime Coquelin --- lib/vhost/vhost.h | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h index 7085e0885c..b3f0c1d07c 100644 --- a/lib/vhost/vhost.h +++ b/lib/vhost/vhost.h @@ -588,4 +588,18 @@ static __rte_always_inline int guest_page_addrcmp(const void *p1, } +static __rte_always_inline int guest_page_rangecmp(const void *p1, const void *p2) +{ + const struct guest_page *page1 = (const struct guest_page *)p1; + const struct guest_page *page2 = (const struct guest_page *)p2; + + if (page1->guest_phys_addr >= page2->guest_phys_addr) { + if (page1->guest_phys_addr < page2->guest_phys_addr + page2->size) + return 0; + else + return 1; + } else + return -1; +} + static __rte_always_inline rte_iova_t gpa_to_first_hpa(struct virtio_net *dev, uint64_t gpa, @@ -598,7 +612,7 @@ gpa_to_first_hpa(struct virtio_net *dev, uint64_t gpa, *hpa_size = gpa_size; if (dev->nr_guest_pages >= VHOST_BINARY_SEARCH_THRESH) { - key.guest_phys_addr = gpa & ~(dev->guest_pages[0].size - 1); + key.guest_phys_addr = gpa; page = bsearch(&key, dev->guest_pages, dev->nr_guest_pages, - sizeof(struct guest_page), guest_page_addrcmp); + sizeof(struct guest_page), guest_page_rangecmp); if (page) { if (gpa + gpa_size <= -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:47.696029239 +0000 +++ 0143-vhost-fix-guest-to-host-physical-address-mapping.patch 2022-02-21 15:22:44.298704592 +0000 @@ -1 +1 @@ -From 8b764f460f168505b9335bdbd0e0fead8edbc188 Mon Sep 17 00:00:00 2001 +From 160769f6486d584468ebcf4d50abf1ee9d4378ab Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8b764f460f168505b9335bdbd0e0fead8edbc188 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org