From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E309A0350 for ; Mon, 21 Feb 2022 16:42:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B31E4013F; Mon, 21 Feb 2022 16:42:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A1637410E0 for ; Mon, 21 Feb 2022 16:42:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645458135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/hI4Umcj3Wr6812y7m3TLhx8QEy4CPiVNXDmurTVwAI=; b=BoFoUiYQxNT1ZXt7SwgHTvlODHmOmAyI4IXRJ3Ba7plVjnRoWXqbHWqSagXxls/QUwWIB6 jJAPeXlID9dtsw96woodqFNXZ2hDeK8AoLE4OYH8OHaFtTramJ6+9tzMNY25OlcodvkqiF XcMR/zhauW0OL1r1udN90G7R/WWJG3I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-82-C22-OrjLNWeG35cUrBQIJQ-1; Mon, 21 Feb 2022 10:42:11 -0500 X-MC-Unique: C22-OrjLNWeG35cUrBQIJQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0C9B4100C660; Mon, 21 Feb 2022 15:42:11 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A43F7E2FF; Mon, 21 Feb 2022 15:42:09 +0000 (UTC) From: Kevin Traynor To: Vladimir Medvedkin Cc: Kevin Traynor , dpdk stable Subject: patch 'app/fib: fix division by zero' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:35:44 +0000 Message-Id: <20220221153625.152324-155-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/472f790f95a44cf13259dfdc1f44cf5259e1773b Thanks. Kevin --- >From 472f790f95a44cf13259dfdc1f44cf5259e1773b Mon Sep 17 00:00:00 2001 From: Vladimir Medvedkin Date: Thu, 27 Jan 2022 18:08:53 +0000 Subject: [PATCH] app/fib: fix division by zero [ upstream commit a01070dac90b76f735e3c8805c3b78357b078518 ] This patch fixes the division by 0, which occurs if the number of routes is less than 10. Can be triggered by passing -n argument with value < 10: ./dpdk-test-fib -- -n 9 ... Floating point exception (core dumped) Fixes: 103809d032cd ("app/test-fib: add test application for FIB") Signed-off-by: Vladimir Medvedkin Acked-by: Kevin Traynor --- app/test-fib/main.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/app/test-fib/main.c b/app/test-fib/main.c index 622703dce8..830c32cc44 100644 --- a/app/test-fib/main.c +++ b/app/test-fib/main.c @@ -712,4 +712,8 @@ parse_opts(int argc, char **argv) rte_exit(-EINVAL, "Invalid option -n\n"); } + + if (config.nb_routes < config.print_fract) + config.print_fract = config.nb_routes; + break; case 'd': @@ -1243,4 +1247,8 @@ main(int argc, char **argv) while (fgets(line, sizeof(line), fr) != NULL) config.nb_routes++; + + if (config.nb_routes < config.print_fract) + config.print_fract = config.nb_routes; + rewind(fr); } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:47.923319273 +0000 +++ 0155-app-fib-fix-division-by-zero.patch 2022-02-21 15:22:44.305704608 +0000 @@ -1 +1 @@ -From a01070dac90b76f735e3c8805c3b78357b078518 Mon Sep 17 00:00:00 2001 +From 472f790f95a44cf13259dfdc1f44cf5259e1773b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a01070dac90b76f735e3c8805c3b78357b078518 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org