From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 764A1A0350 for ; Mon, 21 Feb 2022 16:42:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 711514013F; Mon, 21 Feb 2022 16:42:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 22217410F6 for ; Mon, 21 Feb 2022 16:42:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645458147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SJKNYMnoXgEIdY4j1VMbNZunQi4hEiBKV/UYJAS1Fpw=; b=JhTKR/AkfR90ROxFl/Kz0vU0WRIantCzQ2a4+T9Bq6NDA8Gx2JLTJ83BpByGskvel3v+F5 ePJdlDKIj9Q8R7jkICZArpiKd4C/HbqbbWL+/CZRw/r2hlBOhfpUdGmAbeythhPIyC5lEH Go+dF4yw5NA6vwa8aNsi9EktVmuwdiM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-8-necik8byNy2XvgeiX-c3EQ-1; Mon, 21 Feb 2022 10:42:24 -0500 X-MC-Unique: necik8byNy2XvgeiX-c3EQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B6551091DA3; Mon, 21 Feb 2022 15:42:23 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1EA497E2C5; Mon, 21 Feb 2022 15:42:21 +0000 (UTC) From: Kevin Traynor To: Ivan Malov Cc: Andrew Rybchenko , Andy Moreton , dpdk stable Subject: patch 'net/sfc: do not push fast free offload to default TxQ config' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:35:52 +0000 Message-Id: <20220221153625.152324-163-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/915b0b0b9fb3eb0e1f233a3dab2cf3bf999a0f46 Thanks. Kevin --- >From 915b0b0b9fb3eb0e1f233a3dab2cf3bf999a0f46 Mon Sep 17 00:00:00 2001 From: Ivan Malov Date: Wed, 9 Feb 2022 02:26:47 +0300 Subject: [PATCH] net/sfc: do not push fast free offload to default TxQ config [ upstream commit f67615ea626e23e61b71d27f894fe9a4ef716df3 ] Doing so is wrong since fast free is an adapter-wide offload. Technically, the offending commit (see "Fixes" tag) does not induce failures, however, such started to occur after commit a4996bd89c42 ("ethdev: new Rx/Tx offloads API") had shown up, because of the strict offload validation in the generic code. Fixes: c78d280e88ef ("net/sfc: convert to new Tx offload API") Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_ethdev.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index d4210b63dd..184f6e7c67 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -95,5 +95,4 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) struct sfc_rss *rss = &sas->rss; struct sfc_mae *mae = &sa->mae; - uint64_t txq_offloads_def = 0; sfc_log_init(sa, "entry"); @@ -147,9 +146,4 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->tx_queue_offload_capa; - if (dev_info->tx_offload_capa & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) - txq_offloads_def |= RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE; - - dev_info->default_txconf.offloads |= txq_offloads_def; - if (rss->context_type != EFX_RX_SCALE_UNAVAILABLE) { uint64_t rte_hf = 0; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:48.079229622 +0000 +++ 0163-net-sfc-do-not-push-fast-free-offload-to-default-TxQ.patch 2022-02-21 15:22:44.315704630 +0000 @@ -1 +1 @@ -From f67615ea626e23e61b71d27f894fe9a4ef716df3 Mon Sep 17 00:00:00 2001 +From 915b0b0b9fb3eb0e1f233a3dab2cf3bf999a0f46 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f67615ea626e23e61b71d27f894fe9a4ef716df3 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index abf7b8d287..b04a05bd9f 100644 +index d4210b63dd..184f6e7c67 100644