From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 949F5A0350 for ; Mon, 21 Feb 2022 16:42:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E0A4410F6; Mon, 21 Feb 2022 16:42:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 065634013F for ; Mon, 21 Feb 2022 16:42:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645458148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T5XZyDaWwcbzu+o/gjkSMHOg5+ImfqecegKR8mmdzew=; b=EKK/DwhlZl8U1Wti2rMPjYDuG157Fx7svN9DqItbU3CXCxA4665KpiZw/w73Fsdj7pdgux ++ldtXW4fv0LYGWiiB1r+gUO3GP6eVhHTM1IKdWc6CFo107rEW0NtCjYqS4nVTRyOyrZJj KbFmdl8zNddyfRqIpZb4MooHJslL2Gs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-b99PjTfxN-y8QCOfumztSg-1; Mon, 21 Feb 2022 10:42:26 -0500 X-MC-Unique: b99PjTfxN-y8QCOfumztSg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1B837343CA; Mon, 21 Feb 2022 15:42:25 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3F0B7E133; Mon, 21 Feb 2022 15:42:23 +0000 (UTC) From: Kevin Traynor To: Ivan Malov Cc: Andrew Rybchenko , Andy Moreton , dpdk stable Subject: patch 'net/sfc: demand Tx fast free offload on EF10 simple datapath' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:35:53 +0000 Message-Id: <20220221153625.152324-164-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b832a197fa479f429d869f94b6999b561c6616c6 Thanks. Kevin --- >From b832a197fa479f429d869f94b6999b561c6616c6 Mon Sep 17 00:00:00 2001 From: Ivan Malov Date: Wed, 9 Feb 2022 02:26:48 +0300 Subject: [PATCH] net/sfc: demand Tx fast free offload on EF10 simple datapath [ upstream commit 24a491bb882a3269b9b4e2754e1d5b43d83b9821 ] Enforce this offload as it is immutable on the said datapath. Fixes: c78d280e88ef ("net/sfc: convert to new Tx offload API") Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_tx.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c index cd927cf2f7..f376f24f7b 100644 --- a/drivers/net/sfc/sfc_tx.c +++ b/drivers/net/sfc/sfc_tx.c @@ -309,4 +309,5 @@ static int sfc_tx_check_mode(struct sfc_adapter *sa, const struct rte_eth_txmode *txmode) { + uint64_t dev_tx_offload_cap = sfc_tx_get_dev_offload_caps(sa); int rc = 0; @@ -320,4 +321,11 @@ sfc_tx_check_mode(struct sfc_adapter *sa, const struct rte_eth_txmode *txmode) } + if ((dev_tx_offload_cap & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) != 0 && + (txmode->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) == 0) { + sfc_err(sa, "There is no FAST_FREE flag in the attempted Tx mode configuration"); + sfc_err(sa, "FAST_FREE is always active as per the current Tx datapath variant"); + rc = EINVAL; + } + /* * These features are claimed to be i40e-specific, -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:48.100226569 +0000 +++ 0164-net-sfc-demand-Tx-fast-free-offload-on-EF10-simple-d.patch 2022-02-21 15:22:44.316704633 +0000 @@ -1 +1 @@ -From 24a491bb882a3269b9b4e2754e1d5b43d83b9821 Mon Sep 17 00:00:00 2001 +From b832a197fa479f429d869f94b6999b561c6616c6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 24a491bb882a3269b9b4e2754e1d5b43d83b9821 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org