From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EB21A0352 for ; Mon, 21 Feb 2022 16:43:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E772A41153; Mon, 21 Feb 2022 16:43:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 997F741154 for ; Mon, 21 Feb 2022 16:43:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645458196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DXMzC4pHKRH77d0mGHIl8xMZrZYwsKYcydq4vgG7Dpo=; b=ODQAnTXztwaUkjYCc3kM+LSX3eib6aT6n2Mamx4i2oZY4TdzEpgmNj27ICQ2vgxpO1qlIo eAu8SosxpFMMnXgdOLUGukr9gkpxBjODH954geTz5uUefnRTb6YPDsJYIsDgByUhL8EX8O tFd+/OqKc5Hu6WY1Z64c5CTNvmrUQ4Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-30-k2PiRPZbMHu96Ww9bFScXQ-1; Mon, 21 Feb 2022 10:43:12 -0500 X-MC-Unique: k2PiRPZbMHu96Ww9bFScXQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AD954801B24; Mon, 21 Feb 2022 15:43:11 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD1F87E2E8; Mon, 21 Feb 2022 15:43:10 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: fix link up and down' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:36:12 +0000 Message-Id: <20220221153625.152324-183-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/42960ce4089d65aec41400db7c73a333a62e4c22 Thanks. Kevin --- >From 42960ce4089d65aec41400db7c73a333a62e4c22 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Wed, 9 Feb 2022 18:42:12 +0800 Subject: [PATCH] net/txgbe: fix link up and down [ upstream commit 2e1ecb460db92bc9dcd2350ed48dfe0b504f380f ] Add hw->dev_start status in the flow of setting link up/down, to avoid obtaining link status inconsistent with the settings. Fixes: 12a653eb53e1 ("net/txgbe: fix link status when device stopped") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index ac4d4e08f4..e2fcf87fe7 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -1938,4 +1938,5 @@ txgbe_dev_set_link_up(struct rte_eth_dev *dev) /* Turn on the laser */ hw->mac.enable_tx_laser(hw); + hw->dev_start = true; txgbe_dev_link_update(dev, 0); } @@ -1958,4 +1959,5 @@ txgbe_dev_set_link_down(struct rte_eth_dev *dev) /* Turn off the laser */ hw->mac.disable_tx_laser(hw); + hw->dev_start = false; txgbe_dev_link_update(dev, 0); } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:48.503443377 +0000 +++ 0183-net-txgbe-fix-link-up-and-down.patch 2022-02-21 15:22:44.362704737 +0000 @@ -1 +1 @@ -From 2e1ecb460db92bc9dcd2350ed48dfe0b504f380f Mon Sep 17 00:00:00 2001 +From 42960ce4089d65aec41400db7c73a333a62e4c22 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2e1ecb460db92bc9dcd2350ed48dfe0b504f380f ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index b756ea5e6c..7b42285b9e 100644 +index ac4d4e08f4..e2fcf87fe7 100644 @@ -21 +22 @@ -@@ -1934,4 +1934,5 @@ txgbe_dev_set_link_up(struct rte_eth_dev *dev) +@@ -1938,4 +1938,5 @@ txgbe_dev_set_link_up(struct rte_eth_dev *dev) @@ -27 +28 @@ -@@ -1954,4 +1955,5 @@ txgbe_dev_set_link_down(struct rte_eth_dev *dev) +@@ -1958,4 +1959,5 @@ txgbe_dev_set_link_down(struct rte_eth_dev *dev)