From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55172A0351 for ; Mon, 21 Feb 2022 16:43:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 379CB410F6; Mon, 21 Feb 2022 16:43:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4180F410F2 for ; Mon, 21 Feb 2022 16:43:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645458201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M0EJN4qADMJm9yO1HiiGjrjVLbPTEtDyHMEO1Pe4puA=; b=dBcevswIHgZsksOyK90Z68OR6Y/up7wJUxi7zuXqZRVxbdz42VLLzh/zgErukiQvINFq5w SmeYb6L6slxEW5BrgwhsAKi/ZSnkLGAqRqRKtVNj7XDRQyP6oS2mx0AzgBafcJGPjw+yjE 5BKwh/0a04hiIh819RjsmYoPclWhTGw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-193-ZZTKhFVxOtS6YrOeZgx0iw-1; Mon, 21 Feb 2022 10:43:18 -0500 X-MC-Unique: ZZTKhFVxOtS6YrOeZgx0iw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 856D1801AC5; Mon, 21 Feb 2022 15:43:17 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9DDEB7E2E8; Mon, 21 Feb 2022 15:43:16 +0000 (UTC) From: Kevin Traynor To: Piotr Bronowski Cc: dpdk stable Subject: patch 'crypto/ipsec_mb: fix premature dereference' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:36:16 +0000 Message-Id: <20220221153625.152324-187-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/13aab9f4938569a1f9283d74e6bf7acdcad4290b Thanks. Kevin --- >From 13aab9f4938569a1f9283d74e6bf7acdcad4290b Mon Sep 17 00:00:00 2001 From: Piotr Bronowski Date: Sun, 16 Jan 2022 19:40:43 +0000 Subject: [PATCH] crypto/ipsec_mb: fix premature dereference [ upstream commit 8c60a04985e7fbee288e780c8d50373d3e1ec678 ] This patch removes coverity defect CID 374380: Null pointer dereferences (REVERSE_INULL) Coverity issue: CID 374380 Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD") Signed-off-by: Piotr Bronowski --- drivers/crypto/ipsec_mb/ipsec_mb_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.h b/drivers/crypto/ipsec_mb/ipsec_mb_private.h index 866722d6f4..e53101acf1 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_private.h +++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.h @@ -192,6 +192,4 @@ ipsec_mb_parse_xform(const struct rte_crypto_sym_xform *xform, const struct rte_crypto_sym_xform **aead_xform) { - const struct rte_crypto_sym_xform *next = xform->next; - if (xform == NULL) { *mode = IPSEC_MB_OP_NOT_SUPPORTED; @@ -199,4 +197,6 @@ ipsec_mb_parse_xform(const struct rte_crypto_sym_xform *xform, } + const struct rte_crypto_sym_xform *next = xform->next; + if (xform->type == RTE_CRYPTO_SYM_XFORM_CIPHER) { if (next == NULL) { -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:48.591718834 +0000 +++ 0187-crypto-ipsec_mb-fix-premature-dereference.patch 2022-02-21 15:22:44.374704764 +0000 @@ -1 +1 @@ -From 8c60a04985e7fbee288e780c8d50373d3e1ec678 Mon Sep 17 00:00:00 2001 +From 13aab9f4938569a1f9283d74e6bf7acdcad4290b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8c60a04985e7fbee288e780c8d50373d3e1ec678 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org