From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0645AA0350 for ; Mon, 21 Feb 2022 16:43:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3E6D410F3; Mon, 21 Feb 2022 16:43:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EB46F410F2 for ; Mon, 21 Feb 2022 16:43:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645458210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=idUVo7RSRavY8Oi3ne/n1xO72yhpn/9BH7+01hEpyzo=; b=OCE0gi96wp18SRAmQ2mCMwg74Yz4YDn+PV9YthqyNFe2TOz8G47xzanaj+8xq4/worFhbX wjiRXcXgGgESAV4eEvYqBiIEVy4+ESCtyBllAV759ICwnYHeqBb1z6Wn1xtzPnIemw7+oR p8v2/H/Zxa4OaKNJcMeyRst56eFRXQU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-214-sLyh4XoWOFaUOeYeqGuxIw-1; Mon, 21 Feb 2022 10:43:27 -0500 X-MC-Unique: sLyh4XoWOFaUOeYeqGuxIw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55770100C663; Mon, 21 Feb 2022 15:43:26 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B4F07E131; Mon, 21 Feb 2022 15:43:25 +0000 (UTC) From: Kevin Traynor To: Junfeng Guo Cc: Jingjing Wu , dpdk stable Subject: patch 'raw/ntb: clear all valid doorbell bits on init' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:36:22 +0000 Message-Id: <20220221153625.152324-193-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/13ddcf9dee6d72e6b61529c8254a717a01e086bb Thanks. Kevin --- >From 13ddcf9dee6d72e6b61529c8254a717a01e086bb Mon Sep 17 00:00:00 2001 From: Junfeng Guo Date: Thu, 10 Feb 2022 15:06:34 +0800 Subject: [PATCH] raw/ntb: clear all valid doorbell bits on init [ upstream commit 3bc814fc555d8c7d1c7c63e1e831e9c34679837f ] Before registering the doorbell interrupt handler callback function, all the valid doorbell bits within the NTB private data struct should be cleared to avoid the confusion of the handshake timing sequence diagram when setting up the NTB connection in back-to-back mode. Fixes: 62012a76811e ("raw/ntb: add handshake process") Signed-off-by: Junfeng Guo Acked-by: Jingjing Wu --- drivers/raw/ntb/ntb.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c index 46ac02e5ab..f5e773c53b 100644 --- a/drivers/raw/ntb/ntb.c +++ b/drivers/raw/ntb/ntb.c @@ -1399,4 +1399,8 @@ ntb_init_hw(struct rte_rawdev *dev, struct rte_pci_device *pci_dev) /* Init doorbell. */ hw->db_valid_mask = RTE_LEN2MASK(hw->db_cnt, uint64_t); + /* Clear all valid doorbell bits before registering intr handler */ + if (hw->ntb_ops->db_clear == NULL) + return -ENOTSUP; + (*hw->ntb_ops->db_clear)(dev, hw->db_valid_mask); intr_handle = pci_dev->intr_handle; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:48.828802136 +0000 +++ 0193-raw-ntb-clear-all-valid-doorbell-bits-on-init.patch 2022-02-21 15:22:44.382704782 +0000 @@ -1 +1 @@ -From 3bc814fc555d8c7d1c7c63e1e831e9c34679837f Mon Sep 17 00:00:00 2001 +From 13ddcf9dee6d72e6b61529c8254a717a01e086bb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3bc814fc555d8c7d1c7c63e1e831e9c34679837f ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org