From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE71DA034E for ; Mon, 21 Feb 2022 16:37:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9DF24013F; Mon, 21 Feb 2022 16:37:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 28C094013F for ; Mon, 21 Feb 2022 16:37:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645457863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vKud0C80ZeV9UbxndstNetZ/Q3GHtdrWlYEJGMyADN8=; b=LQSjM3sSbO50llUbR7BIUpdSEM8KOU/GVK4R9cEg8DJIOfEd1DvoZBUlnRJL7eWaJPKF/f DUwme3PQLEpfKc2Y4yH9BFAvdHc8+YrjpkTQsJgQx0rJqvaOyRYr52moKe+iI48NNsZSxG 13wHjy3iKNSfNrLk0ld1UklW6Qpk4Cs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-264-1VBYa2i8NnSieKHbl9IMyg-1; Mon, 21 Feb 2022 10:37:40 -0500 X-MC-Unique: 1VBYa2i8NnSieKHbl9IMyg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 73E65180FD62; Mon, 21 Feb 2022 15:37:39 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C5017E131; Mon, 21 Feb 2022 15:37:38 +0000 (UTC) From: Kevin Traynor To: Ciara Power Cc: Fan Zhang , dpdk stable Subject: patch 'crypto/ipsec_mb: fix tainted data for session' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:33:33 +0000 Message-Id: <20220221153625.152324-24-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5831db3bab8267894558c1a74f4fb42747fba5e8 Thanks. Kevin --- >From 5831db3bab8267894558c1a74f4fb42747fba5e8 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Fri, 10 Dec 2021 14:09:52 +0000 Subject: [PATCH] crypto/ipsec_mb: fix tainted data for session [ upstream commit 21bdbf24321de9f0336a0e6e0bc618a1e094aa4c ] Downcasting a void * to struct aesni_gcm_session * caused the session data to be treated as tainted. Removing the void * temporary variable and adding a cast avoids this issue. Coverity issue: 374377 Fixes: 746825e5c0ea ("crypto/ipsec_mb: move aesni_gcm PMD") Signed-off-by: Ciara Power Acked-by: Fan Zhang --- drivers/crypto/ipsec_mb/pmd_aesni_gcm.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c b/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c index 2c203795ab..e5ad629fe5 100644 --- a/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c +++ b/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c @@ -714,17 +714,15 @@ aesni_gcm_process_bulk(struct rte_cryptodev *dev, struct rte_crypto_sym_vec *vec) { - void *sess_priv; struct aesni_gcm_session *s; struct gcm_context_data gdata_ctx; IMB_MGR *mb_mgr; - sess_priv = get_sym_session_private_data(sess, dev->driver_id); - if (unlikely(sess_priv == NULL)) { + s = (struct aesni_gcm_session *) get_sym_session_private_data(sess, + dev->driver_id); + if (unlikely(s == NULL)) { aesni_gcm_fill_error_code(vec, EINVAL); return 0; } - s = sess_priv; - /* get per-thread MB MGR, create one if needed */ mb_mgr = get_per_thread_mb_mgr(); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:45.176424548 +0000 +++ 0024-crypto-ipsec_mb-fix-tainted-data-for-session.patch 2022-02-21 15:22:44.045704022 +0000 @@ -1 +1 @@ -From 21bdbf24321de9f0336a0e6e0bc618a1e094aa4c Mon Sep 17 00:00:00 2001 +From 5831db3bab8267894558c1a74f4fb42747fba5e8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 21bdbf24321de9f0336a0e6e0bc618a1e094aa4c ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org