From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E99D1A034F for ; Mon, 21 Feb 2022 16:37:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D65F0410F7; Mon, 21 Feb 2022 16:37:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4CE7D410F2 for ; Mon, 21 Feb 2022 16:37:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645457851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=csXPQVqgSK472067h2jda19TghuXjk7cBgTxVjhobIQ=; b=aTeBf07Xj3CxE1UIUpk8oyd57yFcQP7nEN1IUAcUsfPF4nP9pwONt3C534XkrO+1bP3bR6 R2OF45v5VqhrNbs/IQm7XjBkrL5+dkbSAuwxGcDQs/A2VscH7KEAwNXh/O3Jk5qtial1Vb hsbeNfIrs4+Wf8g8NYnaTpmtPU3Ci/w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-427-Rvssb6tYMvuoUf1fHWaFVw-1; Mon, 21 Feb 2022 10:37:14 -0500 X-MC-Unique: Rvssb6tYMvuoUf1fHWaFVw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B006180FD62; Mon, 21 Feb 2022 15:37:13 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 935EC7E131; Mon, 21 Feb 2022 15:37:11 +0000 (UTC) From: Kevin Traynor To: Maxime Gouin Cc: Olivier Matz , Kevin Traynor , Rosen Xu , dpdk stable Subject: patch 'bus/ifpga: remove useless check while browsing devices' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:33:15 +0000 Message-Id: <20220221153625.152324-6-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/572305874ac4e3d6f6d4b992135ca0bb2cc52f71 Thanks. Kevin --- >From 572305874ac4e3d6f6d4b992135ca0bb2cc52f71 Mon Sep 17 00:00:00 2001 From: Maxime Gouin Date: Wed, 5 Jan 2022 11:26:52 +0100 Subject: [PATCH] bus/ifpga: remove useless check while browsing devices [ upstream commit 62c21c38a26e654bba09be147ea2d61c2e699a13 ] reported by code analysis tool C++test (version 10.4): /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c 67 Condition "afu_dev" is always evaluated to true 81 Condition "afu_dev" is always evaluated to true The "for" loop already checks that afu_dev is not NULL. Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Signed-off-by: Maxime Gouin Reviewed-by: Olivier Matz Acked-by: Kevin Traynor Acked-by: Rosen Xu --- drivers/bus/ifpga/ifpga_bus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c index cbc6809284..c5c8bbd572 100644 --- a/drivers/bus/ifpga/ifpga_bus.c +++ b/drivers/bus/ifpga/ifpga_bus.c @@ -65,6 +65,5 @@ ifpga_find_afu_dev(const struct rte_rawdev *rdev, TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) { - if (afu_dev && - afu_dev->rawdev == rdev && + if (afu_dev->rawdev == rdev && !ifpga_afu_id_cmp(&afu_dev->id, afu_id)) return afu_dev; @@ -79,6 +78,5 @@ rte_ifpga_find_afu_by_name(const char *name) TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) { - if (afu_dev && - !strcmp(afu_dev->device.name, name)) + if (!strcmp(afu_dev->device.name, name)) return afu_dev; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:44.833066499 +0000 +++ 0006-bus-ifpga-remove-useless-check-while-browsing-device.patch 2022-02-21 15:22:44.035703999 +0000 @@ -1 +1 @@ -From 62c21c38a26e654bba09be147ea2d61c2e699a13 Mon Sep 17 00:00:00 2001 +From 572305874ac4e3d6f6d4b992135ca0bb2cc52f71 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 62c21c38a26e654bba09be147ea2d61c2e699a13 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org