From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32B7BA034E for ; Mon, 21 Feb 2022 16:38:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DEB64013F; Mon, 21 Feb 2022 16:38:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B1068410F3 for ; Mon, 21 Feb 2022 16:38:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645457925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=74Yo14UBEpTSaXF3BZKxAA7QRx+WMoRiXSTduslbPRY=; b=QRv+bvLjZr3XQD9HfS9/DaBz1TJqQVjTlG5viG7wXLK1aermptyP2Ix/agXwa/Dyd17KH3 aQ0wFuDfbxD2Dd5vZ9jQxggkQya5CmIOMdOY5+UmjPNQ8VFnaVrcZk0SyqrCOu8iBMAiza emqz/+PX7vQa7h7qbV3bLXj2W/e134M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-547-1tqH3GZGMA2j0qSD1nEadQ-1; Mon, 21 Feb 2022 10:38:42 -0500 X-MC-Unique: 1tqH3GZGMA2j0qSD1nEadQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1BE21842BE3; Mon, 21 Feb 2022 15:38:40 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94B2978DDE; Mon, 21 Feb 2022 15:38:39 +0000 (UTC) From: Kevin Traynor To: Ajit Khaparde Cc: Kalesh AP , Somnath Kotur , dpdk stable Subject: patch 'net/bnxt: fix crash by validating pointer' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:34:12 +0000 Message-Id: <20220221153625.152324-63-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b74a60df81cdcf29eabb9596d4a000769d6b041e Thanks. Kevin --- >From b74a60df81cdcf29eabb9596d4a000769d6b041e Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Tue, 4 Jan 2022 14:08:22 +0530 Subject: [PATCH] net/bnxt: fix crash by validating pointer [ upstream commit 79fc1c531e0ae8a1f750639c82f7272d3117a220 ] Validate the pointers in rxq before accessing them. Otherwise it can cause a segfault. Fixes: 657c2a7f1dd4 ("net/bnxt: create aggregation rings when needed") Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_rxq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 9f1d1d4dba..cd3bb1446f 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -215,5 +215,7 @@ void bnxt_rx_queue_release_mbufs(struct bnxt_rx_queue *rxq) } /* Free up mbufs in Agg ring */ - if (!bnxt_need_agg_ring(rxq->bp->eth_dev)) + if (rxq->bp == NULL || + rxq->bp->eth_dev == NULL || + !bnxt_need_agg_ring(rxq->bp->eth_dev)) return; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:46.030714711 +0000 +++ 0063-net-bnxt-fix-crash-by-validating-pointer.patch 2022-02-21 15:22:44.143704243 +0000 @@ -1 +1 @@ -From 79fc1c531e0ae8a1f750639c82f7272d3117a220 Mon Sep 17 00:00:00 2001 +From b74a60df81cdcf29eabb9596d4a000769d6b041e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 79fc1c531e0ae8a1f750639c82f7272d3117a220 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org