From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D97AA034E for ; Mon, 21 Feb 2022 16:38:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6886B410F3; Mon, 21 Feb 2022 16:38:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A3FF14013F for ; Mon, 21 Feb 2022 16:38:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645457929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rZCFcdZfj3znFL9idofkPk0e0F9LVUSjrzVCRtOLy4Q=; b=U2kLGMTdYvuxbpy1y1h8Bo9D3kpt6u0lNZhWiAWQxylpKD1ok9p7B249kCnd57NLYOkTbb a06ATQyw7ChbvLeGgNBLoQWNJmKiKYcCm/PDvZeoKO1t++MJ+avz6CZYCxJ209dJZcXjp2 OzFm6zzC9ELqHUxtRvz8/OcyzfYV3dw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-453-w4hNLjuTPT-0KF2TSbnJpQ-1; Mon, 21 Feb 2022 10:38:43 -0500 X-MC-Unique: w4hNLjuTPT-0KF2TSbnJpQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78831100C663; Mon, 21 Feb 2022 15:38:42 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C6A978DDE; Mon, 21 Feb 2022 15:38:41 +0000 (UTC) From: Kevin Traynor To: Kalesh AP Cc: Ajit Khaparde , Somnath Kotur , dpdk stable Subject: patch 'net/bnxt: fix xstats query' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:34:13 +0000 Message-Id: <20220221153625.152324-64-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2f9df1413c69ef2a5f8ff0f0889f9f735c0270d7 Thanks. Kevin --- >From 2f9df1413c69ef2a5f8ff0f0889f9f735c0270d7 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 4 Jan 2022 14:08:23 +0530 Subject: [PATCH] net/bnxt: fix xstats query [ upstream commit c05c22f9b8032c2974de7042ba8c38fb42ed7c82 ] Fix incorrect memset in bnxt_dev_xstats_get_op. In bnxt_dev_xstats_get_op(), the PMD is not zeroing the whole buffer supplied by the application. This can end up passing junk statistics values to the application when the FW does not support extended stats on a function. Fixed to call memset() with correct size. Fixes: f55e12f33416 ("net/bnxt: support extended port counters") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index 197fd7c02b..208aa5616d 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -742,5 +742,5 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, stat_size)); - memset(xstats, 0, sizeof(*xstats)); + memset(xstats, 0, sizeof(*xstats) * n); count = 0; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:46.050277378 +0000 +++ 0064-net-bnxt-fix-xstats-query.patch 2022-02-21 15:22:44.143704243 +0000 @@ -1 +1 @@ -From c05c22f9b8032c2974de7042ba8c38fb42ed7c82 Mon Sep 17 00:00:00 2001 +From 2f9df1413c69ef2a5f8ff0f0889f9f735c0270d7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c05c22f9b8032c2974de7042ba8c38fb42ed7c82 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org