From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56E8BA034E for ; Mon, 21 Feb 2022 16:39:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 506134013F; Mon, 21 Feb 2022 16:39:02 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 48BBC410F6 for ; Mon, 21 Feb 2022 16:39:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645457939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uttSYBTq+D6+e597VKSq33TbN/wDJEAy5JWuCQLY3YQ=; b=QvT7rnU+80s6L842mUZiQNB6sHrOikcDR5NKNjD6KR66wh25W6n3fewz7lSTCyXwShniLR 29cM5qDiBPmU7LlyiyiFy9LU1yPuSJxE72D9a7zNcOahj05tM22XXHXr8wcuSRzRBP0SSi tlVHdpzmlnxyLAe9BXoyO6LeBvVB+Og= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-264-ll2sSpPWO1-iXRUuZ4klSw-1; Mon, 21 Feb 2022 10:38:55 -0500 X-MC-Unique: ll2sSpPWO1-iXRUuZ4klSw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BFCD915720; Mon, 21 Feb 2022 15:38:54 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id B51157E2EA; Mon, 21 Feb 2022 15:38:53 +0000 (UTC) From: Kevin Traynor To: Sean Morrissey Cc: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: fix dereference before null check' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:34:21 +0000 Message-Id: <20220221153625.152324-72-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/6d5f3984dcbf23d861c3d892c603472a53b92621 Thanks. Kevin --- >From 6d5f3984dcbf23d861c3d892c603472a53b92621 Mon Sep 17 00:00:00 2001 From: Sean Morrissey Date: Tue, 18 Jan 2022 10:53:09 +0000 Subject: [PATCH] app/testpmd: fix dereference before null check [ upstream commit f924a8d3bb838bffbaf2c2d47bada952e45b475f ] Assign 'left' variable only after null check on 'size' as function returns if 'size' is null. Coverity issue: 374381 Fixes: 169a9fed1f4c ("app/testpmd: fix hex string parser support for flow API") Signed-off-by: Sean Morrissey Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 5c2bba48ad..bbaf18d76e 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -7703,6 +7703,6 @@ static int parse_hex_string(const char *src, uint8_t *dst, uint32_t *size) { - uint32_t left = *size; const uint8_t *head = dst; + uint32_t left; /* Check input parameters */ @@ -7713,4 +7713,6 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size) return -1; + left = *size; + /* Convert chars to bytes */ while (left) { -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:46.208436662 +0000 +++ 0072-app-testpmd-fix-dereference-before-null-check.patch 2022-02-21 15:22:44.157704274 +0000 @@ -1 +1 @@ -From f924a8d3bb838bffbaf2c2d47bada952e45b475f Mon Sep 17 00:00:00 2001 +From 6d5f3984dcbf23d861c3d892c603472a53b92621 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f924a8d3bb838bffbaf2c2d47bada952e45b475f ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org