From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F322A034F for ; Mon, 21 Feb 2022 16:39:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03916410F3; Mon, 21 Feb 2022 16:39:09 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2E6884013F for ; Mon, 21 Feb 2022 16:39:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645457947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yVLRyAE3a/ATvMElOcMeF9qPZfzzF9TpfIBoQhqR0wo=; b=AhmGrA/zbfbPvNUv4dFvz4fnCirh06WnvITR13w60KDy2cl7sRaCAZjUn2qWqS/qD2gVXL F3KWdWjCjAmDbwk0NychOp+crEtUxp5cW4h5ZdS8E2MC6RHLoL7kwNPhKS9eJKxpQLDc3b 0QeUw29QTtOl9tu4/sQXvSUTMYYA+cA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-144-AcGzu5h2OCywHsqlAfu4Ig-1; Mon, 21 Feb 2022 10:39:04 -0500 X-MC-Unique: AcGzu5h2OCywHsqlAfu4Ig-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4DBFB8143EB; Mon, 21 Feb 2022 15:39:03 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3A81B78DDE; Mon, 21 Feb 2022 15:39:02 +0000 (UTC) From: Kevin Traynor To: Alexander Kozyrev Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix maximum packet headers size for TSO' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:34:27 +0000 Message-Id: <20220221153625.152324-78-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a9bc2a46c239d922a5d091ff38b7024645fdc6c0 Thanks. Kevin --- >From a9bc2a46c239d922a5d091ff38b7024645fdc6c0 Mon Sep 17 00:00:00 2001 From: Alexander Kozyrev Date: Thu, 13 Jan 2022 16:32:29 +0200 Subject: [PATCH] net/mlx5: fix maximum packet headers size for TSO [ upstream commit 9701034faab0f84ba42e1f5343afda5464b11ca3 ] The maximum packet headers size for TSO is calculated as a sum of Ethernet, VLAN, IPv6 and TCP headers (plus inner headers). The rationale behind choosing IPv6 and TCP is their headers are bigger than IPv4 and UDP respectively, giving us the maximum possible headers size. But it is not true for L3 headers. IPv4 header size (20 bytes) is smaller than IPv6 header size (40 bytes) only in the default case. There are up to 10 optional header fields called Options in case IHL > 5. This means that the maximum size of the IPv4 header is 60 bytes. Choosing the wrong maximum packets headers size causes inability to transmit multi-segment TSO packets with IPv4 Options present. PMD check that it is possible to inline all the packet headers and the packet headers size exceeds the expected maximum size. The maximum packet headers size was set to 192 bytes before, but its value has been reduced during Tx path refactor activity. Restore the proper maximum packet headers size for TSO. Fixes: 50724e1bba76 ("net/mlx5: update Tx definitions") Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h index 36b384fa08..2d48fde010 100644 --- a/drivers/net/mlx5/mlx5_defs.h +++ b/drivers/net/mlx5/mlx5_defs.h @@ -51,5 +51,5 @@ /* Maximum Packet headers size (L2+L3+L4) for TSO. */ -#define MLX5_MAX_TSO_HEADER (128u + 34u) +#define MLX5_MAX_TSO_HEADER 192U /* Inline data size required by NICs. */ -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:46.339994280 +0000 +++ 0078-net-mlx5-fix-maximum-packet-headers-size-for-TSO.patch 2022-02-21 15:22:44.170704303 +0000 @@ -1 +1 @@ -From 9701034faab0f84ba42e1f5343afda5464b11ca3 Mon Sep 17 00:00:00 2001 +From a9bc2a46c239d922a5d091ff38b7024645fdc6c0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9701034faab0f84ba42e1f5343afda5464b11ca3 ] + @@ -25 +26,0 @@ -Cc: stable@dpdk.org