From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF1E4A0350 for ; Mon, 21 Feb 2022 16:39:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABD18410F3; Mon, 21 Feb 2022 16:39:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 15B8D410F3 for ; Mon, 21 Feb 2022 16:39:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645457960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bzXrh25BiLgcSIheva1/YNGPRjS+4mKavHmpAPevo+4=; b=M9VNKsQUn/M65cMCCnVD7juhEjVyXZkMo9lhlbzNVD1Br7mR7CD5/RMg81KNfEmdVJFwLi aYtOAc2QIuFfL5rC0DOsGjL+kYxsgSOaR16354WlR3uO7bcCiBESBoquurhTjI5f1LvxO+ fEs/MbV9iJdhezH3DzvGExBAMxikiU8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-156-HQXFYh_1MHK-vnYORFZRuA-1; Mon, 21 Feb 2022 10:39:17 -0500 X-MC-Unique: HQXFYh_1MHK-vnYORFZRuA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA83B801ADA; Mon, 21 Feb 2022 15:39:16 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id B943F7B9D9; Mon, 21 Feb 2022 15:39:15 +0000 (UTC) From: Kevin Traynor To: Harman Kalra Cc: Jerin Jacob , dpdk stable Subject: patch 'common/cnxk: reset stale values on error debug registers' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:34:33 +0000 Message-Id: <20220221153625.152324-84-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/cfcdf00068b3c0740908af4ae1e5f7af8fc8a90e Thanks. Kevin --- >From cfcdf00068b3c0740908af4ae1e5f7af8fc8a90e Mon Sep 17 00:00:00 2001 From: Harman Kalra Date: Fri, 21 Jan 2022 17:34:18 +0530 Subject: [PATCH] common/cnxk: reset stale values on error debug registers [ upstream commit 9b7198ea6d2c9b141b92e11c296f156678e1a781 ] LF's error debug registers like NIX_LF_SQ_OP_ERR_DBG, NIX_LF_MNQ_ERR_DBG, NIX_LF_SEND_ERR_DBG captures debug info for an error detected during LMT operation or meta enqueue or after meta enqueue granted respectively. HW sets a valid bit when info is captured and SW is expected to clear this valid bit by writing 1, else these registers will show stale values of first interrupt when occurred and will never update with subsequent interrupts. Fixes: f6d567b03d28 ("common/cnxk: support NIX IRQ") Signed-off-by: Harman Kalra Acked-by: Jerin Jacob --- drivers/common/cnxk/roc_nix_irq.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_nix_irq.c b/drivers/common/cnxk/roc_nix_irq.c index a5cd9d4b02..7dcd533ea9 100644 --- a/drivers/common/cnxk/roc_nix_irq.c +++ b/drivers/common/cnxk/roc_nix_irq.c @@ -203,7 +203,10 @@ nix_lf_sq_debug_reg(struct nix *nix, uint32_t off) reg = plt_read64(nix->base + off); - if (reg & BIT_ULL(44)) + if (reg & BIT_ULL(44)) { plt_err("SQ=%d err_code=0x%x", (int)((reg >> 8) & 0xfffff), (uint8_t)(reg & 0xff)); + /* Clear valid bit */ + plt_write64(BIT_ULL(44), nix->base + off); + } } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:46.455044239 +0000 +++ 0084-common-cnxk-reset-stale-values-on-error-debug-regist.patch 2022-02-21 15:22:44.174704312 +0000 @@ -1 +1 @@ -From 9b7198ea6d2c9b141b92e11c296f156678e1a781 Mon Sep 17 00:00:00 2001 +From cfcdf00068b3c0740908af4ae1e5f7af8fc8a90e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9b7198ea6d2c9b141b92e11c296f156678e1a781 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org