From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39A4BA0350 for ; Mon, 21 Feb 2022 16:39:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34C4C410F3; Mon, 21 Feb 2022 16:39:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8E899410F7 for ; Mon, 21 Feb 2022 16:39:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645457966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rlihTk7oWybBPmQ88rPJF7oyckBk5cE0SjctV3tUm24=; b=EC2uDeGbQbZTHXKaXL2voZiTGUewX0e6w6IZukMziyd+rSZH1oALAabAFgFHtg2JKQx8l7 /aBNUw/SUF6tzqV48WFfRepsIiPQ3rlbpVvQzmsrV5JeMBFbO63xLB3MCJDC2sej6iB0bH fz3fn//EDx2hkKL8jNEQE3gdp44eJNs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-665-vDCyO5sPPoqD2F_nNyA5Ig-1; Mon, 21 Feb 2022 10:39:22 -0500 X-MC-Unique: vDCyO5sPPoqD2F_nNyA5Ig-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7FC3C100C666; Mon, 21 Feb 2022 15:39:21 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4100B7E133; Mon, 21 Feb 2022 15:39:20 +0000 (UTC) From: Kevin Traynor To: Nithin Dabilpuram Cc: Gowrishankar Muthukrishnan , Jerin Jacob , dpdk stable Subject: patch 'common/cnxk: fix uninitialized variables' has been queued to stable release 21.11.1 Date: Mon, 21 Feb 2022 15:34:36 +0000 Message-Id: <20220221153625.152324-87-ktraynor@redhat.com> In-Reply-To: <20220221153625.152324-1-ktraynor@redhat.com> References: <20220221153625.152324-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/26/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2253ed93c3baf5674c869f91f74ec033cceb85f4 Thanks. Kevin --- >From 2253ed93c3baf5674c869f91f74ec033cceb85f4 Mon Sep 17 00:00:00 2001 From: Nithin Dabilpuram Date: Fri, 21 Jan 2022 17:34:21 +0530 Subject: [PATCH] common/cnxk: fix uninitialized variables [ upstream commit a3b4864251ea8c77de1bbb7e2a1a570a253ce339 ] Fix uninitialized variable issues reported by klockwork(static analysis tool). Fixes: ed135040f0ab ("common/cnxk: add CPT LF configuration") Fixes: 585bb3e538f9 ("common/cnxk: add VF support to base device class") Fixes: 58debb813a8d ("common/cnxk: enable TM to listen on Rx pause frames") Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Nithin Dabilpuram Acked-by: Jerin Jacob --- drivers/common/cnxk/roc_cpt.c | 4 ++-- drivers/common/cnxk/roc_dev.c | 2 +- drivers/common/cnxk/roc_nix_tm.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c index 84cc5f05d7..0e2dc45ad8 100644 --- a/drivers/common/cnxk/roc_cpt.c +++ b/drivers/common/cnxk/roc_cpt.c @@ -816,7 +816,7 @@ void roc_cpt_iq_disable(struct roc_cpt_lf *lf) { + volatile union cpt_lf_q_grp_ptr grp_ptr = {.u = 0x0}; + volatile union cpt_lf_inprog lf_inprog = {.u = 0x0}; union cpt_lf_ctl lf_ctl = {.u = 0x0}; - union cpt_lf_q_grp_ptr grp_ptr; - union cpt_lf_inprog lf_inprog; int timeout = 20; int cnt; diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c index 0ac50cab59..9a869698c4 100644 --- a/drivers/common/cnxk/roc_dev.c +++ b/drivers/common/cnxk/roc_dev.c @@ -58,5 +58,5 @@ pf_af_sync_msg(struct dev *dev, struct mbox_msghdr **rsp) struct mbox_dev *mdev = &mbox->dev[0]; - volatile uint64_t int_status; + volatile uint64_t int_status = 0; struct mbox_msghdr *msghdr; uint64_t off; diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c index 21533b5cae..ebb27a3106 100644 --- a/drivers/common/cnxk/roc_nix_tm.c +++ b/drivers/common/cnxk/roc_nix_tm.c @@ -425,5 +425,5 @@ nix_tm_bp_config_get(struct roc_nix *roc_nix, bool *is_enabled) if (req) { req->num_regs = k; - rc = mbox_process(mbox); + rc = mbox_process_msg(mbox, (void **)&rsp); if (rc) goto err; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-21 15:22:46.516205459 +0000 +++ 0087-common-cnxk-fix-uninitialized-variables.patch 2022-02-21 15:22:44.180704326 +0000 @@ -1 +1 @@ -From a3b4864251ea8c77de1bbb7e2a1a570a253ce339 Mon Sep 17 00:00:00 2001 +From 2253ed93c3baf5674c869f91f74ec033cceb85f4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a3b4864251ea8c77de1bbb7e2a1a570a253ce339 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 3f3d28196b..89877d1b28 100644 +index 84cc5f05d7..0e2dc45ad8 100644 @@ -27 +28 @@ -@@ -818,7 +818,7 @@ void +@@ -816,7 +816,7 @@ void @@ -49 +50 @@ -index 3b38cc087b..a0448bec61 100644 +index 21533b5cae..ebb27a3106 100644