From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAF48A00C4 for ; Wed, 23 Feb 2022 17:43:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFA57426D3; Wed, 23 Feb 2022 17:43:49 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2089.outbound.protection.outlook.com [40.107.212.89]) by mails.dpdk.org (Postfix) with ESMTP id 0115F411CB; Wed, 23 Feb 2022 17:43:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GcQ2KM4CqorJc7hR4h3jq1NAB5OQPW5wzgFZLmXoCwakErm4MrPxAvKi+CQbdO2uNU3l+qCqJ+6YzVy8f1OaPEnsu682ouEAhAAYKJtxDObzL1kB0+1BOYYF2XcBu8OoIGumK0HM275bUIZoTKRtDC2usTIOLAxWDZR/SO1og+HioF/WrkcbcWQoSKjgjgsBCvZcoENq186DwAu2eIts+tZyCxcTZFnhqJb6gzgWuiCCgmSVegA3s1uUAhGXbsoukyTkvVT549EP+wq/Zk59TRT2zskU5+BXrT3s0Fr753uNlqM7Mf0kI9S+po2oYNoNQmwdZ82MTd2XYtJxw30KRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MDUZYGtXq/rql85GBM7MQUoynqkhn9CuOgMWEJ6uwI8=; b=Uk6XA1p8DAXKq7r5EkOOnfqbygxxazKtF+1iiT8iOOxtu1ldwUAkeSOoapBT8VyeGmYtSGeCeFo919mNpryTX9AztNZCG7sjZECE+R4yfLMYGCAMppLgpC8Wwyh4PnrkIlA4tF39Jh7w2qteghNyW5deMwpclEIw9n3zz0ryzD2hs0HPWlFVtapyuKlVV0gjOqHC7dZnZEQlXF5kozTn0oP6K7Y7tp9GzbnXN0esvR8XmDm6P3cTFbxL1HmbZ9SH24wS7Ak1qJ5/UF4ODl3toLAB8uQO92+vMMzuV07VpNP7lw+MFSOAFo5SETWfZsqUk+6VuPj+63+XglbK8S9hoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.236) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MDUZYGtXq/rql85GBM7MQUoynqkhn9CuOgMWEJ6uwI8=; b=tPsx4VjZRpJSj2VMCefGJQ22s9Jhp/9wSqe9VxMRUNgG8MKkrR8WrbMQPkRF8QxBF/IjXZYmZ5l/24v5wXXpaDqqTLM8+/oBuZwM9Wxm81kC3MbsqSyqAi3a5OnnavtQBliD71dLHm2R8UhQ6pYhsdvX/l+ytoOqKpgyKyljjEGyogePfFscR0hzfgXNiicBlVxHkC9rP5hP+dunCWcBywJO3SyaAkXe93MeWSaEhPu/um8SGbrSJChpL1mFihpva7Z2YlQ3qDgGnHH+KhTpuxFp4WZfyUetNqerpnvRbrPGLDnhLbr3mFwL8N/KNe7Qy/kb7vYf74ETgtH0rMrZyg== Received: from MWHPR2001CA0015.namprd20.prod.outlook.com (2603:10b6:301:15::25) by CH2PR12MB4908.namprd12.prod.outlook.com (2603:10b6:610:6b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb 2022 16:43:45 +0000 Received: from CO1NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:301:15:cafe::4f) by MWHPR2001CA0015.outlook.office365.com (2603:10b6:301:15::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24 via Frontend Transport; Wed, 23 Feb 2022 16:43:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.236 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.236; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.236) by CO1NAM11FT061.mail.protection.outlook.com (10.13.175.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5017.22 via Frontend Transport; Wed, 23 Feb 2022 16:43:44 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by DRHQMAIL109.nvidia.com (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 23 Feb 2022 16:43:44 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Wed, 23 Feb 2022 08:43:42 -0800 Received: from nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.986.9 via Frontend Transport; Wed, 23 Feb 2022 08:43:41 -0800 From: Dmitry Kozlyuk To: CC: , Viacheslav Ovsiienko , "Matan Azrad" Subject: [PATCH 3/3] net/mlx5: fix initial link status detection Date: Wed, 23 Feb 2022 18:43:33 +0200 Message-ID: <20220223164333.3834590-4-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220223164333.3834590-1-dkozlyuk@nvidia.com> References: <20220223164333.3834590-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9ee06f37-dd97-4827-012d-08d9f6eba844 X-MS-TrafficTypeDiagnostic: CH2PR12MB4908:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: etTyVMrFzzvF7x0gNTlMg5rNvnSIwgyTLLRvs+pB/gxdulJrO04EpMpdthiqynmh8bVKicLR3Xfx2OP6lcc2WSyt8hHUAvPSjX0IeCYPuutgw+ipcSk1S4bcg7lv6gH4u2G8KvhjRbIqUCcR9YANUFAi5G1qBXnAeY6fv6UYQAAhfFZt0mZYFq80x8FE5ZSGLqFaTKJsgG/ArXDETxa/E4xtaKyC1MhuHdyZkfzBwhXBK05YYQb/5i6z8FoX2zcZGCmRSSGkS9+X3xbx7RmadK7kdRoFNB4g1TNO0y9GijWVHJTxw8NpsK2R/QmRz+nUroYFBjAAsdWXqy2XAjC252zqvB/NXBuJjyIsik/GBdbt+6SYIi7LCl5JxosTBGk0K+zXd7qcyDDNfV3IhZdHsdfVQDGppHy0TJezFgq8SCpBXA8mTKkOho+2qP4sOlhIo0Dl5NaHm8v7ixmMgj3CHjUlfZ14EkCV3qyOvYhZ9KiNZw1zm2zcwDb3gznDEjdnuHCO1mtDBXUmbHrDx2XqXZ4koy3wQGkgVUirt9V+VSf09sstwnmEg0zwvxEuC04gdVQTRw9EUB2dZt54SCYQEtVmLY3RSzkpwUPZSKX2rXjueMQxpyFtAoQ9RoSpJMiMzKOt2eJkjikqEdI9doIE5lD/+GBY0Oi2iTw15nskoWFgydmryvLLf/8UjapfstrzcnQTk9gm8gOrqbWSx1dntQ== X-Forefront-Antispam-Report: CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(2906002)(26005)(1076003)(82310400004)(107886003)(81166007)(356005)(2616005)(55016003)(6286002)(36860700001)(83380400001)(186003)(426003)(336012)(70206006)(47076005)(36756003)(316002)(7696005)(8936002)(70586007)(6916009)(54906003)(4326008)(8676002)(6666004)(40460700003)(86362001)(508600001)(5660300002)(450100002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:43:44.9318 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ee06f37-dd97-4827-012d-08d9f6eba844 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4908 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Link status change takes time that depends on the HW and the kernel. It was checked immediately after the change was issued at probing. If the port had beed down before probing, a "down" state may be read, while the port would be "up" imminently. After that, DPDK reported the port as "down" mistakenly and "ifconfig $DEV up" did not trigger an LSC event, because from the system's perspective the port was "up" already. Install Netlink event handler at port probe before requesting the port to come up in order to receive LSC event even if it comes up between probe and start. Fixes: b6499434b83e ("net/mlx5: fix link status initialization") Cc: stable@dpdk.org Signed-off-by: Dmitry Kozlyuk Reviewed-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 86dbc870e3..6b1c59e895 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -1645,13 +1645,10 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, /* Bring Ethernet device up. */ DRV_LOG(DEBUG, "port %u forcing Ethernet interface up", eth_dev->data->port_id); + /* Watch LSC interrupts between port probe and port start. */ + priv->sh->port[priv->dev_port - 1].nl_ih_port_id = + eth_dev->data->port_id; mlx5_set_link_up(eth_dev); - /* - * Even though the interrupt handler is not installed yet, - * interrupts will still trigger on the async_fd from - * Verbs context returned by ibv_open_device(). - */ - mlx5_link_update(eth_dev, 0); #ifdef HAVE_MLX5DV_DR_ESWITCH if (!(config->hca_attr.eswitch_manager && config->dv_flow_en && (switch_info->representor || switch_info->master))) -- 2.25.1