[PATCH v2] doc: fix vhost multi-queue reconnection

[PATCH v2] doc: fix vhost multi-queue reconnection

[xuan.ding]

From: Xuan Ding <xuan.ding@intel.com>

Since QEMU 5.2.0 fixes the vhost multi-queue reconnection issue
in commit f66337bdbfda ("vhost-user: save features of multiqueues
if chardev is closed"), this patch removes the previous description
from known issue.

Fixes: b37e95507e1b ("doc: add vhost multi-queue reconnection issue")
Cc: stable@dpdk.org

Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
v2:
* Add fixes in commit title and log.
---
 doc/guides/rel_notes/known_issues.rst | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
index 187d9c942e..a8d1401a71 100644
--- a/doc/guides/rel_notes/known_issues.rst
+++ b/doc/guides/rel_notes/known_issues.rst
@@ -884,24 +884,3 @@ Unsuitable IOVA mode may be picked as the default
 
 **Driver/Module**:
    ALL.
-
-Vhost multi-queue reconnection failed with QEMU version >= 4.2.0
-----------------------------------------------------------------
-
-**Description**
-   It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves
-   acked features for one vhost-net when vhost quits. When vhost reconnects
-   to virtio-net/virtio-pmd in multi-queue situations, the features been
-   set multiple times are not consistent.
-
-**Implication**
-   Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
-
-**Resolution/Workaround**:
-   It is possible to filter the incorrect acked features at vhost-user side.
-
-**Affected Environment/Platform**:
-   ALL.
-
-**Driver/Module**:
-   Virtual Device Poll Mode Driver (PMD).
-- 
2.17.1

Re: [PATCH v2] doc: fix vhost multi-queue reconnection

[Maxime Coquelin]

On 2/24/22 07:28, xuan.ding@intel.com wrote:
> From: Xuan Ding <xuan.ding@intel.com>
> 
> Since QEMU 5.2.0 fixes the vhost multi-queue reconnection issue
> in commit f66337bdbfda ("vhost-user: save features of multiqueues
> if chardev is closed"), this patch removes the previous description
> from known issue.
> 
> Fixes: b37e95507e1b ("doc: add vhost multi-queue reconnection issue")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> v2:
> * Add fixes in commit title and log.
> ---
>   doc/guides/rel_notes/known_issues.rst | 21 ---------------------
>   1 file changed, 21 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
> index 187d9c942e..a8d1401a71 100644
> --- a/doc/guides/rel_notes/known_issues.rst
> +++ b/doc/guides/rel_notes/known_issues.rst
> @@ -884,24 +884,3 @@ Unsuitable IOVA mode may be picked as the default
>   
>   **Driver/Module**:
>      ALL.
> -
> -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0
> -----------------------------------------------------------------
> -
> -**Description**
> -   It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves
> -   acked features for one vhost-net when vhost quits. When vhost reconnects
> -   to virtio-net/virtio-pmd in multi-queue situations, the features been
> -   set multiple times are not consistent.
> -
> -**Implication**
> -   Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
> -
> -**Resolution/Workaround**:
> -   It is possible to filter the incorrect acked features at vhost-user side.
> -
> -**Affected Environment/Platform**:
> -   ALL.
> -
> -**Driver/Module**:
> -   Virtual Device Poll Mode Driver (PMD).

Instead of removing this information, I would rather update it to 
indicate the range of affected QEMU versions.

What do you think?

Thanks,
Maxime

RE: [PATCH v2] doc: fix vhost multi-queue reconnection

[Ding, Xuan]

Hi Maxime,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, March 29, 2022 8:47 PM
> To: Ding, Xuan <xuan.ding@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH v2] doc: fix vhost multi-queue reconnection
> 
> 
> 
> On 2/24/22 07:28, xuan.ding@intel.com wrote:
> > From: Xuan Ding <xuan.ding@intel.com>
> >
> > Since QEMU 5.2.0 fixes the vhost multi-queue reconnection issue in
> > commit f66337bdbfda ("vhost-user: save features of multiqueues if
> > chardev is closed"), this patch removes the previous description from
> > known issue.
> >
> > Fixes: b37e95507e1b ("doc: add vhost multi-queue reconnection issue")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> > ---
> > v2:
> > * Add fixes in commit title and log.
> > ---
> >   doc/guides/rel_notes/known_issues.rst | 21 ---------------------
> >   1 file changed, 21 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/known_issues.rst
> > b/doc/guides/rel_notes/known_issues.rst
> > index 187d9c942e..a8d1401a71 100644
> > --- a/doc/guides/rel_notes/known_issues.rst
> > +++ b/doc/guides/rel_notes/known_issues.rst
> > @@ -884,24 +884,3 @@ Unsuitable IOVA mode may be picked as the
> default
> >
> >   **Driver/Module**:
> >      ALL.
> > -
> > -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0
> > -----------------------------------------------------------------
> > -
> > -**Description**
> > -   It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only
> saves
> > -   acked features for one vhost-net when vhost quits. When vhost
> reconnects
> > -   to virtio-net/virtio-pmd in multi-queue situations, the features been
> > -   set multiple times are not consistent.
> > -
> > -**Implication**
> > -   Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
> > -
> > -**Resolution/Workaround**:
> > -   It is possible to filter the incorrect acked features at vhost-user side.
> > -
> > -**Affected Environment/Platform**:
> > -   ALL.
> > -
> > -**Driver/Module**:
> > -   Virtual Device Poll Mode Driver (PMD).
> 
> Instead of removing this information, I would rather update it to indicate the
> range of affected QEMU versions.
> 
> What do you think?

That's a good idea, so that users can know which versions are affected.
I will update it in next version.

Thanks,
Xuan

> 
> Thanks,
> Maxime

[PATCH v3] doc: fix vhost multi-queue reconnection

[xuan.ding]

From: Xuan Ding <xuan.ding@intel.com>

Since QEMU 5.2.0 fixes the vhost split ring multi-queue reconnection
issue in commit f66337bdbfda ("vhost-user: save features of multiqueues
if chardev is closed"), this patch updates known issue to indicate
the range of affeacted QEMU versions.

Fixes: b37e95507e1b ("doc: add vhost multi-queue reconnection issue")
Cc: stable@dpdk.org

Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
v3:
* Updated affected QEMU versions.

v2:
* Add fixes in commit title and log.
---
 doc/guides/rel_notes/known_issues.rst | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
index 187d9c942e..bd89d58d24 100644
--- a/doc/guides/rel_notes/known_issues.rst
+++ b/doc/guides/rel_notes/known_issues.rst
@@ -885,14 +885,15 @@ Unsuitable IOVA mode may be picked as the default
 **Driver/Module**:
    ALL.
 
-Vhost multi-queue reconnection failed with QEMU version >= 4.2.0
-----------------------------------------------------------------
+Vhost multi-queue reconnection failed with QEMU version 4.2.0 to 5.1.0-rc3
+--------------------------------------------------------------------------
 
 **Description**
    It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves
    acked features for one vhost-net when vhost quits. When vhost reconnects
    to virtio-net/virtio-pmd in multi-queue situations, the features been
-   set multiple times are not consistent.
+   set multiple times are not consistent. QEMU-5.2.0 fixes this issue in commit
+   f66337bdbfda ("vhost-user: save features of multiqueues if chardev is closed").
 
 **Implication**
    Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
-- 
2.17.1

RE: [PATCH v3] doc: fix vhost multi-queue reconnection

[Xia, Chenbo]

> -----Original Message-----
> From: Ding, Xuan <xuan.ding@intel.com>
> Sent: Friday, April 15, 2022 10:08 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Ding, Xuan
> <xuan.ding@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] doc: fix vhost multi-queue reconnection
> 
> From: Xuan Ding <xuan.ding@intel.com>
> 
> Since QEMU 5.2.0 fixes the vhost split ring multi-queue reconnection
> issue in commit f66337bdbfda ("vhost-user: save features of multiqueues
> if chardev is closed"), this patch updates known issue to indicate
> the range of affeacted QEMU versions.
> 
> Fixes: b37e95507e1b ("doc: add vhost multi-queue reconnection issue")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> v3:
> * Updated affected QEMU versions.
> 
> v2:
> * Add fixes in commit title and log.
> ---
>  doc/guides/rel_notes/known_issues.rst | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/known_issues.rst
> b/doc/guides/rel_notes/known_issues.rst
> index 187d9c942e..bd89d58d24 100644
> --- a/doc/guides/rel_notes/known_issues.rst
> +++ b/doc/guides/rel_notes/known_issues.rst
> @@ -885,14 +885,15 @@ Unsuitable IOVA mode may be picked as the default
>  **Driver/Module**:
>     ALL.
> 
> -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0
> -----------------------------------------------------------------
> +Vhost multi-queue reconnection failed with QEMU version 4.2.0 to 5.1.0-
> rc3

So 5.1.0 fixes the problem or not? As 5.1.0 is later than 5.1.0-rc3 but you said
from 5.2.0 it's fixed. And I think we should just mention formal release, not any
rc, qemu users should not use any rc for formal usage.

Thanks,
Chenbo

> +-------------------------------------------------------------------------
> -
> 
>  **Description**
>     It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves
>     acked features for one vhost-net when vhost quits. When vhost
> reconnects
>     to virtio-net/virtio-pmd in multi-queue situations, the features been
> -   set multiple times are not consistent.
> +   set multiple times are not consistent. QEMU-5.2.0 fixes this issue in
> commit
> +   f66337bdbfda ("vhost-user: save features of multiqueues if chardev is
> closed").
> 
>  **Implication**
>     Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
> --
> 2.17.1

RE: [PATCH v3] doc: fix vhost multi-queue reconnection

[Ding, Xuan]

Hi Chenbo,

> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Friday, May 6, 2022 4:41 PM
> To: Ding, Xuan <xuan.ding@intel.com>; maxime.coquelin@redhat.com
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH v3] doc: fix vhost multi-queue reconnection
> 
> > -----Original Message-----
> > From: Ding, Xuan <xuan.ding@intel.com>
> > Sent: Friday, April 15, 2022 10:08 AM
> > To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> > Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Ding, Xuan
> > <xuan.ding@intel.com>; stable@dpdk.org
> > Subject: [PATCH v3] doc: fix vhost multi-queue reconnection
> >
> > From: Xuan Ding <xuan.ding@intel.com>
> >
> > Since QEMU 5.2.0 fixes the vhost split ring multi-queue reconnection
> > issue in commit f66337bdbfda ("vhost-user: save features of
> > multiqueues if chardev is closed"), this patch updates known issue to
> > indicate the range of affeacted QEMU versions.
> >
> > Fixes: b37e95507e1b ("doc: add vhost multi-queue reconnection issue")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> > ---
> > v3:
> > * Updated affected QEMU versions.
> >
> > v2:
> > * Add fixes in commit title and log.
> > ---
> >  doc/guides/rel_notes/known_issues.rst | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/known_issues.rst
> > b/doc/guides/rel_notes/known_issues.rst
> > index 187d9c942e..bd89d58d24 100644
> > --- a/doc/guides/rel_notes/known_issues.rst
> > +++ b/doc/guides/rel_notes/known_issues.rst
> > @@ -885,14 +885,15 @@ Unsuitable IOVA mode may be picked as the
> > default
> >  **Driver/Module**:
> >     ALL.
> >
> > -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0
> > -----------------------------------------------------------------
> > +Vhost multi-queue reconnection failed with QEMU version 4.2.0 to
> > +5.1.0-
> > rc3
> 
> So 5.1.0 fixes the problem or not? As 5.1.0 is later than 5.1.0-rc3 but you said
> from 5.2.0 it's fixed. And I think we should just mention formal release, not
> any rc, qemu users should not use any rc for formal usage.

Thanks for your catch. The tag here is wrong(actually 5.2.0-rc0).
So the actual fixed version is in 5.2.0. I will fix it in next version.

Regards,
Xuan

> 
> Thanks,
> Chenbo
> 
> > +---------------------------------------------------------------------
> > +----
> > -
> >
> >  **Description**
> >     It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only
> saves
> >     acked features for one vhost-net when vhost quits. When vhost
> > reconnects
> >     to virtio-net/virtio-pmd in multi-queue situations, the features been
> > -   set multiple times are not consistent.
> > +   set multiple times are not consistent. QEMU-5.2.0 fixes this issue
> > + in
> > commit
> > +   f66337bdbfda ("vhost-user: save features of multiqueues if chardev
> > + is
> > closed").
> >
> >  **Implication**
> >     Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
> > --
> > 2.17.1

[PATCH v4] doc: fix vhost multi-queue reconnection

[xuan.ding]

From: Xuan Ding <xuan.ding@intel.com>

Since QEMU 5.2.0 fixes the vhost split ring multi-queue reconnection
issue in commit f66337bdbfda ("vhost-user: save features of multiqueues
if chardev is closed"), this patch updates known issue to indicate
the range of affeacted QEMU versions.

Fixes: b37e95507e1b ("doc: add vhost multi-queue reconnection issue")
Cc: stable@dpdk.org

Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
v4:
* Corrected the QEMU fix version.

v3:
* Updated affected QEMU versions.

v2:
* Added fixes in commit title and log.
---
 doc/guides/rel_notes/known_issues.rst | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
index 187d9c942e..570550843a 100644
--- a/doc/guides/rel_notes/known_issues.rst
+++ b/doc/guides/rel_notes/known_issues.rst
@@ -885,14 +885,15 @@ Unsuitable IOVA mode may be picked as the default
 **Driver/Module**:
    ALL.
 
-Vhost multi-queue reconnection failed with QEMU version >= 4.2.0
-----------------------------------------------------------------
+Vhost multi-queue reconnection failed with QEMU version 4.2.0 to 5.1.0
+----------------------------------------------------------------------
 
 **Description**
    It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves
    acked features for one vhost-net when vhost quits. When vhost reconnects
    to virtio-net/virtio-pmd in multi-queue situations, the features been
-   set multiple times are not consistent.
+   set multiple times are not consistent. QEMU-5.2.0 fixes this issue in commit
+   f66337bdbfda ("vhost-user: save features of multiqueues if chardev is closed").
 
 **Implication**
    Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
-- 
2.17.1

RE: [PATCH v4] doc: fix vhost multi-queue reconnection

[Xia, Chenbo]

> -----Original Message-----
> From: Ding, Xuan <xuan.ding@intel.com>
> Sent: Monday, May 9, 2022 12:12 PM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Ding, Xuan
> <xuan.ding@intel.com>; stable@dpdk.org
> Subject: [PATCH v4] doc: fix vhost multi-queue reconnection
> 
> From: Xuan Ding <xuan.ding@intel.com>
> 
> Since QEMU 5.2.0 fixes the vhost split ring multi-queue reconnection
> issue in commit f66337bdbfda ("vhost-user: save features of multiqueues
> if chardev is closed"), this patch updates known issue to indicate
> the range of affeacted QEMU versions.
> 
> Fixes: b37e95507e1b ("doc: add vhost multi-queue reconnection issue")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> v4:
> * Corrected the QEMU fix version.
> 
> v3:
> * Updated affected QEMU versions.
> 
> v2:
> * Added fixes in commit title and log.
> ---
>  doc/guides/rel_notes/known_issues.rst | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/known_issues.rst
> b/doc/guides/rel_notes/known_issues.rst
> index 187d9c942e..570550843a 100644
> --- a/doc/guides/rel_notes/known_issues.rst
> +++ b/doc/guides/rel_notes/known_issues.rst
> @@ -885,14 +885,15 @@ Unsuitable IOVA mode may be picked as the default
>  **Driver/Module**:
>     ALL.
> 
> -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0
> -----------------------------------------------------------------
> +Vhost multi-queue reconnection failed with QEMU version 4.2.0 to 5.1.0
> +----------------------------------------------------------------------
> 
>  **Description**
>     It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only saves
>     acked features for one vhost-net when vhost quits. When vhost
> reconnects
>     to virtio-net/virtio-pmd in multi-queue situations, the features been
> -   set multiple times are not consistent.
> +   set multiple times are not consistent. QEMU-5.2.0 fixes this issue in
> commit
> +   f66337bdbfda ("vhost-user: save features of multiqueues if chardev is
> closed").
> 
>  **Implication**
>     Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
> --
> 2.17.1

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>