From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: yipeng1.wang@intel.com, byron.marohn@intel.com
Cc: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>,
stable@dpdk.org
Subject: [PATCH v3 2/2] efd: fix uninitialized structure
Date: Fri, 25 Feb 2022 09:27:45 +0000 [thread overview]
Message-ID: <20220225092745.883850-2-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <20220225092745.883850-1-pablo.de.lara.guarch@intel.com>
Coverity flags that both elements of efd_online_group_entry
are used uninitialized. This is OK because this structure
is initially used for starting values, so any value is OK.
Coverity ID: 375868
Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")
Cc: pablo.de.lara.guarch@intel.com
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
---
-v3: Fixed RHEL build
-v2: Fixed typo in commit message
---
lib/efd/rte_efd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c
index 560cd78961..bbc6fc585d 100644
--- a/lib/efd/rte_efd.c
+++ b/lib/efd/rte_efd.c
@@ -1162,7 +1162,7 @@ rte_efd_update(struct rte_efd_table * const table, const unsigned int socket_id,
{
uint32_t chunk_id = 0, group_id = 0, bin_id = 0;
uint8_t new_bin_choice = 0;
- struct efd_online_group_entry entry;
+ struct efd_online_group_entry entry = {{0}};
int status = efd_compute_update(table, socket_id, key, value,
&chunk_id, &group_id, &bin_id,
--
2.25.1
next prev parent reply other threads:[~2022-02-25 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 15:48 [PATCH 1/2] test/efd: fix size of constant Pablo de Lara
2022-02-24 15:48 ` [PATCH 2/2] efd: fix uninitialized structure Pablo de Lara
2022-02-24 15:57 ` [PATCH v2 1/2] test/efd: fix size of constant Pablo de Lara
2022-02-24 15:57 ` [PATCH v2 2/2] efd: fix uninitialized structure Pablo de Lara
2022-02-24 17:14 ` Wang, Yipeng1
2022-02-24 17:15 ` [PATCH v2 1/2] test/efd: fix size of constant Wang, Yipeng1
2022-02-25 9:27 ` [PATCH v3 " Pablo de Lara
2022-02-25 9:27 ` Pablo de Lara [this message]
2022-02-27 17:59 ` [PATCH v3 2/2] efd: fix uninitialized structure Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225092745.883850-2-pablo.de.lara.guarch@intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=byron.marohn@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).