From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D15ACA034C for ; Fri, 25 Feb 2022 18:16:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB5AE4114A; Fri, 25 Feb 2022 18:16:30 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 2FB2E410FD for ; Fri, 25 Feb 2022 18:16:29 +0100 (CET) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1110E3F1D9 for ; Fri, 25 Feb 2022 17:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645809389; bh=bQmlr7IBoNLFLwUwSUes6xuTe4e+Vena482GS7X0TR8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=If+OTI4I5kfTV6NGNhSWssU4AZ+ZrAlsJCPJzVoJKHSBPvemrsm9wAxXcgeNt4PWy GQfUxrJrMIZavstbyVFf0N3GyVKNnKiWWKysW4WrYnqA0t02C/eUpN9pvDFpq8/PVP +gtWCizgZ5vXQmVqJfLny0D0YySsnYcnm7khV+xy4muCo3aWsKMFhtTzc1ffsOAcbh byVB0V0PB4Q+B/7aaKE/Z64J9G2m/f6/VCQH/+Qlm0IRbMY63EfF4jo3whHYA54IPz KdNM4bOloIdYBqEUAbMLCR6jFo2/ZqBvXWt8qjjKPNFEsB2BxxyEjt2RJDmbt6b8XZ +lOD61+P8qrEw== Received: by mail-wm1-f71.google.com with SMTP id d8-20020a05600c34c800b0037e3cd6225eso269855wmq.6 for ; Fri, 25 Feb 2022 09:16:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bQmlr7IBoNLFLwUwSUes6xuTe4e+Vena482GS7X0TR8=; b=1ZRp39bHu/FlJFkcGmy6OJo9g43Mj0AYyKDKj4FXFkaQzH0AAfc/M8xkSF+EJOJjON 1X4AcaW+G00X3qnfzhGcsCsVcEcFEQw3dIFSfk7XRQ/qW7kBAIY8GSN0b5nsXsxutoT/ FYgqJ/I0PzcHUAGHTvu0Icw4kaKyBJDSfa7ZT/3aXfDJURlrk0dW4GlcIYFfe3uofnCj yavvSkcmWEiwylNUUghbm9kYIK1dY/yqlCIX8nYNcwB6K6P0XamN1NPwCyCzyNXnsJyx Owml7JInq43DcGbIo4OTGh/C6wMDgAZhML62MwWFcwMycRWPJBYe/vqXKLMhBKS2kMaz wkIg== X-Gm-Message-State: AOAM532S2qsWgkW1HI0JOjl9oNanCote5s2Qu/4N3dUCrqLVjt4ifUzm 8/FNpQCkhI9UYtrI9UGZ9T4bDyItQaZtoATG8dlIVoE6KSpyARI9J7cI3AsIQffek9K0zPTPjZ5 MSWIR1OS5sLUOnaczFvAHV8bt X-Received: by 2002:a05:600c:378b:b0:380:d7b4:c4a1 with SMTP id o11-20020a05600c378b00b00380d7b4c4a1mr3641788wmr.171.1645809388398; Fri, 25 Feb 2022 09:16:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJz98L2jbJ85sFVp8yAdZ5ZxYGfRw+j8ql1tJ+3do1CtEv5lkyI8HxhLBCcMX7okfDzpPB4LRQ== X-Received: by 2002:a05:600c:378b:b0:380:d7b4:c4a1 with SMTP id o11-20020a05600c378b00b00380d7b4c4a1mr3641778wmr.171.1645809388211; Fri, 25 Feb 2022 09:16:28 -0800 (PST) Received: from Keschdeichel.fritz.box (068-133-067-156.ip-addr.inexio.net. [156.67.133.68]) by smtp.gmail.com with ESMTPSA id g20-20020a05600c4ed400b003811fab7f3esm3466378wmq.30.2022.02.25.09.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 09:16:27 -0800 (PST) From: christian.ehrhardt@canonical.com To: Kalesh AP Cc: Ajit Khaparde , Somnath Kotur , dpdk stable Subject: patch 'net/bnxt: fix xstats query' has been queued to stable release 19.11.12 Date: Fri, 25 Feb 2022 18:15:05 +0100 Message-Id: <20220225171550.3499040-12-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.35.0 In-Reply-To: <20220225171550.3499040-1-christian.ehrhardt@canonical.com> References: <20220225171550.3499040-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.12 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/27/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/5b1137059210dfe45dee2c9dc48ec3eaac727719 Thanks. Christian Ehrhardt --- >From 5b1137059210dfe45dee2c9dc48ec3eaac727719 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 4 Jan 2022 14:08:23 +0530 Subject: [PATCH] net/bnxt: fix xstats query [ upstream commit c05c22f9b8032c2974de7042ba8c38fb42ed7c82 ] Fix incorrect memset in bnxt_dev_xstats_get_op. In bnxt_dev_xstats_get_op(), the PMD is not zeroing the whole buffer supplied by the application. This can end up passing junk statistics values to the application when the FW does not support extended stats on a function. Fixed to call memset() with correct size. Fixes: f55e12f33416 ("net/bnxt: support extended port counters") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index b9538bbf35..ca66ce1213 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -546,7 +546,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, (bp->fw_tx_port_stats_ext_size / stat_size)); - memset(xstats, 0, sizeof(*xstats)); + memset(xstats, 0, sizeof(*xstats) * n); count = 0; for (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) { -- 2.35.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-25 16:58:44.752529027 +0100 +++ 0012-net-bnxt-fix-xstats-query.patch 2022-02-25 16:58:44.200990377 +0100 @@ -1 +1 @@ -From c05c22f9b8032c2974de7042ba8c38fb42ed7c82 Mon Sep 17 00:00:00 2001 +From 5b1137059210dfe45dee2c9dc48ec3eaac727719 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c05c22f9b8032c2974de7042ba8c38fb42ed7c82 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 197fd7c02b..208aa5616d 100644 +index b9538bbf35..ca66ce1213 100644 @@ -27 +28 @@ -@@ -741,7 +741,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, +@@ -546,7 +546,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,