From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6934A034C for ; Fri, 25 Feb 2022 18:16:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1A0F41150; Fri, 25 Feb 2022 18:16:47 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id DBAE54114F for ; Fri, 25 Feb 2022 18:16:45 +0100 (CET) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id C1AF43F1D9 for ; Fri, 25 Feb 2022 17:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645809405; bh=AXV4Xw6jzY7hKvm27LdX0NMmmSJwkShpiTE9hLPCIZ4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CKKB1wK54zMOp7boBXoAF14GnG/ftyJ+mHcl9ZyWdtzAkAG8PwutWYVr95iJjd5Db nAbDjudmewP+DYr7rrA3JFBTyXpymiH2ibvTi4aFkuO7BdeETq/oeikoIEjfhBQcV5 k8bAZTfF5FI1iHPJ+/BfdOTF6+dfrOQxYskiej58BNR7hoYEaOzD5qjUO8NvdpbIKJ DPLXXu30Egy+EPgYB61+1NpR+GP22mCseL9XdgaxXc+TL+R4f9qqSgHD0h31IFvI3x 3XfmgIyyX9uLjp1gWFsxKSbmZyc9hQI0dfOjllVCzp6jk4ixagb6aRDBueaGIzytJM QFwfkidv8TYEQ== Received: by mail-wr1-f71.google.com with SMTP id v17-20020adfa1d1000000b001ed9d151569so1081871wrv.21 for ; Fri, 25 Feb 2022 09:16:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AXV4Xw6jzY7hKvm27LdX0NMmmSJwkShpiTE9hLPCIZ4=; b=oHQiaBLF3kKawMQcd8t7yZjpA2z38gtY0+aU3PA9mcUuvFTmxK1FSUblVYTIzWUk16 mryg8pZvn795v0+2E3CLrhHyU1C+e+wAmCYu5ILhAEMjUhVLOKfB+eCVQuD72UmZ7hDF 9U24eTr0rgOoBOyl8eZw/lBPZwLGe+2t3QLLNMnhGlrSG8m7UgevabeC14thJPRKcIdH E6xM7rshiFC66tHesTBhSshWO1uP8JRwVqP2Z7Ex9spdTmXKbdKGndTUKHKq/2zWWpZC h3LXo8LQeqdWZG6y59r5WZ1JVU2szNrmpCVGwrrDIXpVLE9t3FjGk50I9X4rZhoMacpL wlUQ== X-Gm-Message-State: AOAM530oe6Qhccj+Ct0XonsoG5EZ+eUre8kfTWIFMskVBAL7cyacq2dY EEnP4NgIlxqVsiIMO2hzZcVWoVd6Rn4BIrYDFQA1K3Ua/oDfAsCnZNVjwZoFL7i84kdd5/CrPGh y8gd1HLzDW+Z+aK5AaGQYpg4u X-Received: by 2002:a5d:5747:0:b0:1ed:b776:d402 with SMTP id q7-20020a5d5747000000b001edb776d402mr7126598wrw.714.1645809405457; Fri, 25 Feb 2022 09:16:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXktFG6/CJ3w9sTwgIN2y2Lk5Ltz3IrY7GxJPbDOCVVwsBSaJSdi4a2Omy30Jh4eY8bX3/hw== X-Received: by 2002:a5d:5747:0:b0:1ed:b776:d402 with SMTP id q7-20020a5d5747000000b001edb776d402mr7126588wrw.714.1645809405269; Fri, 25 Feb 2022 09:16:45 -0800 (PST) Received: from Keschdeichel.fritz.box (068-133-067-156.ip-addr.inexio.net. [156.67.133.68]) by smtp.gmail.com with ESMTPSA id f12-20020a05600c154c00b0037df2e5d8c9sm3533984wmg.27.2022.02.25.09.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 09:16:44 -0800 (PST) From: christian.ehrhardt@canonical.com To: Yunjian Wang Cc: Qi Zhang , dpdk stable Subject: patch 'net/ice: fix link up when starting device' has been queued to stable release 19.11.12 Date: Fri, 25 Feb 2022 18:15:13 +0100 Message-Id: <20220225171550.3499040-20-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.35.0 In-Reply-To: <20220225171550.3499040-1-christian.ehrhardt@canonical.com> References: <20220225171550.3499040-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.12 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/27/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/5381edac9f1dd70c784a91bd0cf2ea24a26e3b31 Thanks. Christian Ehrhardt --- >From 5381edac9f1dd70c784a91bd0cf2ea24a26e3b31 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Tue, 25 Jan 2022 09:39:07 +0800 Subject: [PATCH] net/ice: fix link up when starting device [ upstream commit 6c76b76dc64183eb2f24a52b90d4ff9feb4872f4 ] Currently, there is a possibility that the link status is not correct after set link up, the device ID is 159b. It would be fixed by calling ice_link_update() while the parameter 'wait_to_complete' is true. It's reasonable to wait for complete right after set link up as it is not in an link status change interrupt handling scenario. Fixes: cf911d90e366 ("net/ice: support link update") Signed-off-by: Yunjian Wang Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 5071eda1c0..f665a89f9c 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -2911,7 +2911,7 @@ ice_dev_start(struct rte_eth_dev *dev) ice_dev_set_link_up(dev); /* Call get_link_info aq commond to enable/disable LSE */ - ice_link_update(dev, 0); + ice_link_update(dev, 1); pf->adapter_stopped = false; -- 2.35.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-25 16:58:45.066726406 +0100 +++ 0020-net-ice-fix-link-up-when-starting-device.patch 2022-02-25 16:58:44.224990398 +0100 @@ -1 +1 @@ -From 6c76b76dc64183eb2f24a52b90d4ff9feb4872f4 Mon Sep 17 00:00:00 2001 +From 5381edac9f1dd70c784a91bd0cf2ea24a26e3b31 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6c76b76dc64183eb2f24a52b90d4ff9feb4872f4 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 6d85e421cf..d01acb8797 100644 +index 5071eda1c0..f665a89f9c 100644 @@ -25 +26 @@ -@@ -3610,7 +3610,7 @@ ice_dev_start(struct rte_eth_dev *dev) +@@ -2911,7 +2911,7 @@ ice_dev_start(struct rte_eth_dev *dev) @@ -28 +29 @@ - /* Call get_link_info aq command to enable/disable LSE */ + /* Call get_link_info aq commond to enable/disable LSE */