patches for DPDK stable branches
 help / color / mirror / Atom feed
From: christian.ehrhardt@canonical.com
To: Xiaoyu Min <jackmin@nvidia.com>
Cc: Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	dpdk stable <stable@dpdk.org>
Subject: patch 'net/mlx5: reject jump to root table' has been queued to stable release 19.11.12
Date: Fri, 25 Feb 2022 18:15:22 +0100	[thread overview]
Message-ID: <20220225171550.3499040-29-christian.ehrhardt@canonical.com> (raw)
In-Reply-To: <20220225171550.3499040-1-christian.ehrhardt@canonical.com>

Hi,

FYI, your patch has been queued to stable release 19.11.12

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/27/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/7e275590e51019b5b34b86c54b0d126523da93ae

Thanks.

Christian Ehrhardt <christian.ehrhardt@canonical.com>

---
From 7e275590e51019b5b34b86c54b0d126523da93ae Mon Sep 17 00:00:00 2001
From: Xiaoyu Min <jackmin@nvidia.com>
Date: Tue, 18 Jan 2022 19:38:50 +0800
Subject: [PATCH] net/mlx5: reject jump to root table

[ upstream commit 87b26522f7ff65375fb1d773a7f93c70bf857b96 ]

Currently root table as destination is not supported.
The jump action which finally be translated to underlying root table in
rdma-core should be rejected.

Fixes: f78f747f41d0 ("net/mlx5: allow jump to group lower than current")

Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow_dv.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index e16a98be3b..6f0876f233 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -3487,7 +3487,7 @@ flow_dv_validate_action_jump(const struct rte_flow_action *action,
 			     const struct rte_flow_attr *attributes,
 			     bool external, struct rte_flow_error *error)
 {
-	uint32_t target_group, table;
+	uint32_t target_group, table = 0;
 	int ret = 0;
 
 	if (action_flags & (MLX5_FLOW_FATE_ACTIONS |
@@ -3515,6 +3515,10 @@ flow_dv_validate_action_jump(const struct rte_flow_action *action,
 					  RTE_FLOW_ERROR_TYPE_ACTION, NULL,
 					  "target group must be other than"
 					  " the current flow group");
+	if (table == 0)
+		return rte_flow_error_set(error, EINVAL,
+					  RTE_FLOW_ERROR_TYPE_ACTION_CONF,
+					  NULL, "root table shouldn't be destination");
 	return 0;
 }
 
-- 
2.35.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-02-25 16:58:45.391847134 +0100
+++ 0029-net-mlx5-reject-jump-to-root-table.patch	2022-02-25 16:58:44.244990416 +0100
@@ -1 +1 @@
-From 87b26522f7ff65375fb1d773a7f93c70bf857b96 Mon Sep 17 00:00:00 2001
+From 7e275590e51019b5b34b86c54b0d126523da93ae Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 87b26522f7ff65375fb1d773a7f93c70bf857b96 ]
+
@@ -11 +12,0 @@
-Cc: stable@dpdk.org
@@ -20 +21 @@
-index 18992b1e26..af90a7fd0a 100644
+index e16a98be3b..6f0876f233 100644
@@ -23 +24 @@
-@@ -4968,7 +4968,7 @@ flow_dv_validate_action_jump(struct rte_eth_dev *dev,
+@@ -3487,7 +3487,7 @@ flow_dv_validate_action_jump(const struct rte_flow_action *action,
@@ -30,3 +31,3 @@
- 	struct flow_grp_info grp_info = {
- 		.external = !!external,
-@@ -4999,6 +4999,10 @@ flow_dv_validate_action_jump(struct rte_eth_dev *dev,
+ 
+ 	if (action_flags & (MLX5_FLOW_FATE_ACTIONS |
+@@ -3515,6 +3515,10 @@ flow_dv_validate_action_jump(const struct rte_flow_action *action,

  parent reply	other threads:[~2022-02-25 17:17 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25 17:14 patch 'net/hns3: fix residual MAC after setting default MAC' " christian.ehrhardt
2022-02-25 17:14 ` patch 'net/hns3: fix secondary process reference count' " christian.ehrhardt
2022-02-25 17:14 ` patch 'net/hns3: fix multi-process action register and unregister' " christian.ehrhardt
2022-02-25 17:14 ` patch 'net/hns3: unregister MP action on close for secondary' " christian.ehrhardt
2022-02-25 17:14 ` patch 'net/ice: build failure with make and GCC > 11' " christian.ehrhardt
2022-02-25 17:14 ` patch 'config/ppc: fix build with GCC >= 10' " christian.ehrhardt
2022-02-25 17:15 ` patch 'maintainers: update for stable branches' " christian.ehrhardt
2022-02-25 17:15 ` patch 'bus/ifpga: remove useless check while browsing devices' " christian.ehrhardt
2022-02-25 17:15 ` patch 'eal/linux: log hugepage create errors with filename' " christian.ehrhardt
2022-02-25 17:15 ` patch 'devtools: fix comment detection in forbidden token check' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/ixgbe: add vector Rx parameter " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/bnxt: fix xstats query' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/bonding: fix mode type mismatch' " christian.ehrhardt
2022-02-25 17:15 ` patch 'app/testpmd: fix dereference before null check' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/cxgbe: fix dangling pointer by mailbox access rework' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/mlx5: fix maximum packet headers size for TSO' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/nfp: remove useless range checks' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/sfc: validate queue span when parsing flow action RSS' " christian.ehrhardt
2022-02-25 17:15 ` patch 'raw/ifpga/base: fix SPI transaction' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/ice: fix link up when starting device' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/bnxt: handle ring cleanup in case of error' " christian.ehrhardt
2022-02-25 17:15 ` patch 'raw/ifpga/base: fix port feature ID' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/memif: remove unnecessary Rx interrupt stub' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/bonding: fix RSS with early configure' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/hns3: fix using enum as boolean' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/virtio: fix Tx queue 0 overriden by queue 128' " christian.ehrhardt
2022-02-25 17:15 ` patch 'vdpa/ifc: fix log info mismatch' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/virtio-user: check FD flags getting failure' " christian.ehrhardt
2022-02-25 17:15 ` christian.ehrhardt [this message]
2022-02-25 17:15 ` patch 'build: fix warning about using -Wextra flag' " christian.ehrhardt
2022-02-25 17:15 ` patch 'kni: fix ioctl signature' " christian.ehrhardt
2022-02-25 17:15 ` patch 'doc: fix KNI PMD name typo' " christian.ehrhardt
2022-02-25 17:15 ` patch 'ring: fix error code when creating ring' " christian.ehrhardt
2022-02-25 17:15 ` patch 'test/mem: fix error check' " christian.ehrhardt
2022-02-25 17:15 ` patch 'bus/dpaa: fix C++ include guard' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/cxgbe: remove useless " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/dpaa2: " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/hns3: fix max packet size rollback in PF' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/hns3: fix RSS key with null' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/ixgbe: check filter init failure' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/bonding: fix promiscuous and allmulticast state' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/bonding: fix reference count on mbufs' " christian.ehrhardt
2022-02-25 17:15 ` patch 'app/testpmd: fix bonding mode set' " christian.ehrhardt
2022-02-25 17:15 ` patch 'stack: fix stubs header export' " christian.ehrhardt
2022-02-25 17:15 ` patch 'ipsec: fix C++ include' " christian.ehrhardt
2022-02-25 17:15 ` patch 'table: " christian.ehrhardt
2022-02-25 17:15 ` patch 'vhost: " christian.ehrhardt
2022-02-25 17:15 ` patch 'test/mbuf: fix mbuf data content check' " christian.ehrhardt
2022-02-25 17:15 ` patch 'ipc: end multiprocess thread during cleanup' " christian.ehrhardt
2022-02-25 17:15 ` patch 'vfio: cleanup the multiprocess sync handle' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/memif: remove pointer deference before null check' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/sfc: do not push fast free offload to default TxQ config' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/sfc: demand Tx fast free offload on EF10 simple datapath' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/iavf: count continuous DD bits for Arm' " christian.ehrhardt
2022-02-25 17:15 ` patch 'net/mlx5: fix committed bucket size' " christian.ehrhardt
2022-02-25 17:15 ` patch 'compress/octeontx: fix null pointer dereference' " christian.ehrhardt
2022-02-25 17:15 ` patch 'raw/ntb: clear all valid doorbell bits on init' " christian.ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220225171550.3499040-29-christian.ehrhardt@canonical.com \
    --to=christian.ehrhardt@canonical.com \
    --cc=jackmin@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).