From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 266E5A0350 for ; Mon, 28 Feb 2022 22:21:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21E17411B8; Mon, 28 Feb 2022 22:21:27 +0100 (CET) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by mails.dpdk.org (Postfix) with ESMTP id 5C42A411AE for ; Mon, 28 Feb 2022 22:21:26 +0100 (CET) Received: by mail-ed1-f50.google.com with SMTP id bq11so19441213edb.2 for ; Mon, 28 Feb 2022 13:21:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/M2IpDte3l395CUUKayPHiDQ1g8vtkH76UqwkQxTy0Q=; b=kUvwCKHlI5xpEMG6QqM3zbC4hnFqQSgbGjSEROTUbCyqJnTAcXjUe8/533Wa9v/axx CIfwgkfRipPgNkc89AcsJyJsbG/Y/Qdeu2iNGRR8gw830IzY+KNpPJqPNkz5B0yGXo8q e8E3i4jIXgaMwbM+LL/1ndEtBwzubUPtiPVaZGjvAcyrltNrTzdx3YgyBzeVQSgIO9wg Qes6PRvQ4TYv1nVOslVsh9hc9ODdSv6x4cuajneQFaczrDFFjmRSvq1et/nYvZGJS7GM iVb5KU9H18KLFejZCks5D9X4vgBGRRgEU3QmXv2odLN6IwTtvoszoywv3sbB8egu/RBa HIkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/M2IpDte3l395CUUKayPHiDQ1g8vtkH76UqwkQxTy0Q=; b=RPowvGyfpQEapEKxda8OeIEhsD9kyCChoIaX6MEVVJAl3QJJKv9vfNi6hDbHV0wJKg ZChTJSt9/JsChMJBe5UYC7umzl+9Em6b0PumKg+bb1JYLvDS7uPmo1oAN6MyuO8+G4bw ISC5f/cmBNDNp3ggdnqKU8+11bKtuYl9Uqs8svnwwurU+mbm5xYRoa7oGu7l3YV0cMJI YwFihnUJoDgfpnhb2GhiH4P8QmZ5J6oKUtpDVmtQZDys5aySjv7iHRHRW19/Cudvf9BW LQGsV8JW94cW9xClpDFnt8zj294hmX+bQ003hXSzPCkaPpRe7uFz4Noaow6Mx+iNZEAI dpqQ== X-Gm-Message-State: AOAM531/7DkavWPW0wpdCWq7B5dFNpv1vAzpWLotEPKgs4lMEpxgTeQ7 nrW9nS1/hfoJLknnImfzfsc= X-Google-Smtp-Source: ABdhPJzy/Kz1KstE3nHUmSOEmUnHLBIWLtd7ZonnV2i/t4120qvBFhYv3e3qSUvLcm+PwRwQ+ZW3BA== X-Received: by 2002:a05:6402:b9c:b0:410:d469:d73d with SMTP id cf28-20020a0564020b9c00b00410d469d73dmr21415328edb.78.1646083286015; Mon, 28 Feb 2022 13:21:26 -0800 (PST) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id z60-20020a509e42000000b00410d28fc82bsm6464096ede.19.2022.02.28.13.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 13:21:25 -0800 (PST) From: luca.boccassi@gmail.com To: Arek Kusztal Cc: Akhil Goyal , dpdk stable Subject: patch 'cryptodev: fix RSA key type name' has been queued to stable release 20.11.5 Date: Mon, 28 Feb 2022 21:20:10 +0000 Message-Id: <20220228212047.3341966-14-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220228212047.3341966-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/7b5609a5a0e790f4d51ac19dc937a9c0ef203f5b Thanks. Luca Boccassi --- >From 7b5609a5a0e790f4d51ac19dc937a9c0ef203f5b Mon Sep 17 00:00:00 2001 From: Arek Kusztal Date: Fri, 18 Feb 2022 07:53:32 +0000 Subject: [PATCH] cryptodev: fix RSA key type name [ upstream commit 3387912f5cacd934594f2c7a0c34eda7279419a8 ] This patch fixes misspelled RTE_RSA_KEY_TYPE_QT, this will prevent checkpach from complaining wherever change to RSA is being made. Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions") Signed-off-by: Arek Kusztal Acked-by: Akhil Goyal --- app/test/test_cryptodev_asym.c | 2 +- app/test/test_cryptodev_rsa_test_vectors.h | 2 +- drivers/crypto/qat/qat_asym.c | 4 ++-- lib/librte_cryptodev/rte_crypto_asym.h | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 85cd076059..af1310d9a2 100644 --- a/app/test/test_cryptodev_asym.c +++ b/app/test/test_cryptodev_asym.c @@ -559,7 +559,7 @@ test_one_case(const void *test_case, int sessionless) status = test_cryptodev_asym_op( &testsuite_params, &tc, test_msg, sessionless, i, - RTE_RSA_KET_TYPE_QT); + RTE_RSA_KEY_TYPE_QT); } if (status) break; diff --git a/app/test/test_cryptodev_rsa_test_vectors.h b/app/test/test_cryptodev_rsa_test_vectors.h index 48a72e1492..04539a1ecf 100644 --- a/app/test/test_cryptodev_rsa_test_vectors.h +++ b/app/test/test_cryptodev_rsa_test_vectors.h @@ -378,7 +378,7 @@ struct rte_crypto_asym_xform rsa_xform_crt = { .data = rsa_e, .length = sizeof(rsa_e) }, - .key_type = RTE_RSA_KET_TYPE_QT, + .key_type = RTE_RSA_KEY_TYPE_QT, .qt = { .p = { .data = rsa_p, diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c index 09d8761c5f..bd0bf5f0cb 100644 --- a/drivers/crypto/qat/qat_asym.c +++ b/drivers/crypto/qat/qat_asym.c @@ -97,7 +97,7 @@ static void qat_clear_arrays_by_alg(struct qat_asym_op_cookie *cookie, qat_clear_arrays(cookie, QAT_ASYM_MODINV_NUM_IN_PARAMS, QAT_ASYM_MODINV_NUM_OUT_PARAMS, alg_size); else if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_RSA) { - if (xform->rsa.key_type == RTE_RSA_KET_TYPE_QT) + if (xform->rsa.key_type == RTE_RSA_KEY_TYPE_QT) qat_clear_arrays_crt(cookie, alg_size); else { qat_clear_arrays(cookie, QAT_ASYM_RSA_NUM_IN_PARAMS, @@ -370,7 +370,7 @@ qat_asym_fill_arrays(struct rte_crypto_asym_op *asym_op, return -(EINVAL); } } - if (xform->rsa.key_type == RTE_RSA_KET_TYPE_QT) { + if (xform->rsa.key_type == RTE_RSA_KEY_TYPE_QT) { qat_req->input_param_count = QAT_ASYM_RSA_QT_NUM_IN_PARAMS; diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h index 9c866f553f..9c5bb9233a 100644 --- a/lib/librte_cryptodev/rte_crypto_asym.h +++ b/lib/librte_cryptodev/rte_crypto_asym.h @@ -146,7 +146,7 @@ enum rte_crypto_rsa_padding_type { enum rte_crypto_rsa_priv_key_type { RTE_RSA_KEY_TYPE_EXP, /**< RSA private key is an exponent */ - RTE_RSA_KET_TYPE_QT, + RTE_RSA_KEY_TYPE_QT, /**< RSA private key is in quintuple format * See rte_crypto_rsa_priv_key_qt */ -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-28 21:17:55.136891942 +0000 +++ 0014-cryptodev-fix-RSA-key-type-name.patch 2022-02-28 21:17:53.832929056 +0000 @@ -1 +1 @@ -From 3387912f5cacd934594f2c7a0c34eda7279419a8 Mon Sep 17 00:00:00 2001 +From 7b5609a5a0e790f4d51ac19dc937a9c0ef203f5b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3387912f5cacd934594f2c7a0c34eda7279419a8 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ - lib/cryptodev/rte_crypto_asym.h | 2 +- + lib/librte_cryptodev/rte_crypto_asym.h | 2 +- @@ -23 +24 @@ -index 7cda8bb081..573af2a537 100644 +index 85cd076059..af1310d9a2 100644 @@ -26 +27 @@ -@@ -549,7 +549,7 @@ test_one_case(const void *test_case, int sessionless) +@@ -559,7 +559,7 @@ test_one_case(const void *test_case, int sessionless) @@ -49 +50 @@ -index f46eefd4b3..27ce0337a7 100644 +index 09d8761c5f..bd0bf5f0cb 100644 @@ -70,5 +71,5 @@ -diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h -index 2eb0f001e3..cd24d4b07b 100644 ---- a/lib/cryptodev/rte_crypto_asym.h -+++ b/lib/cryptodev/rte_crypto_asym.h -@@ -145,7 +145,7 @@ enum rte_crypto_rsa_padding_type { +diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h +index 9c866f553f..9c5bb9233a 100644 +--- a/lib/librte_cryptodev/rte_crypto_asym.h ++++ b/lib/librte_cryptodev/rte_crypto_asym.h +@@ -146,7 +146,7 @@ enum rte_crypto_rsa_padding_type {