From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CDF4A0350 for ; Mon, 28 Feb 2022 22:21:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5249940140; Mon, 28 Feb 2022 22:21:40 +0100 (CET) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by mails.dpdk.org (Postfix) with ESMTP id DF05C40140 for ; Mon, 28 Feb 2022 22:21:38 +0100 (CET) Received: by mail-ej1-f51.google.com with SMTP id a8so27470009ejc.8 for ; Mon, 28 Feb 2022 13:21:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j+xu83bSSyF7RRP2inGWpWTn9KmFdS6fQ1BZR60J4UE=; b=Hx6qIPBaZnXGcGicE4+uTFL/A72lD2LcE2GVD16GW5DMU/3gSrBOQVfT3gWtuylT2V dMqNhP31WryG86AuvxjA9RWEUFfo0uRyTep0JfcOFMHCV7Q/GNuV+btfC1HxMAVp4gFm zvRqjB7Bc77WWv54SH6F2gt01XHz0xWJfmWAPwbTatg0ltmfRPzhCkblNIh7IzsZ23mX fN/AMnlBpY7c/5FAo07nAPukmIaogJ9Jcuc3Z1M+0tjU9HClk6UstMErPAZVhUlvH0iV 4M/FVOg01iylE+nXPqKhDVmAqcMzuh1DGgZzHkJd+Ve1X/AUvytNR6sap04cOBb+r+By lbuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j+xu83bSSyF7RRP2inGWpWTn9KmFdS6fQ1BZR60J4UE=; b=0VeG7NzJ1n+Ga2/YTkgkosn9Pi13tJYR8TkvWne1E3q116zL9HZJriUEZBmIZqJeou 7X75dShl5ZTgSbrZV5CT9Ye55V1WDAnDSUvIfMoza49iKgbSCQS0FAtnatn9irTv7MDl /CIJ2pTHCZrKj1Aq/wQweBimBwfEYzcJ8vfINMbObY255o3kdnsIBEfflt41sYsl6Evh dBQdVS2IKOsBOm+VLehodUNZbpMXNzCt99/LHI+O7cm27vAjnvldF5T7v86Afy2hcWY5 BIvxKdA0Culflz8c43/NJasBRvifU7nc93tjNC/Pz2VNS90JqLW/O3n/C5xlWx/dc3m4 3s9g== X-Gm-Message-State: AOAM532gZcFdB4Q16yQG830TD2yi0oFGsJ9XbHdybf+stcd8Mpl3vXPa KQ0zo9gl4TGhz4ynkM4OiPevRHKzLS5tCA== X-Google-Smtp-Source: ABdhPJyLReLDNM0wX03QuHDdwma8dpK/kUQj2VhO2NV8eZopfRL8V25PTyH8C5ggjhAmKhqH+u58aA== X-Received: by 2002:a17:906:b005:b0:6b4:8861:597b with SMTP id v5-20020a170906b00500b006b48861597bmr16348140ejy.238.1646083298595; Mon, 28 Feb 2022 13:21:38 -0800 (PST) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id go41-20020a1709070da900b006d643bdd4d4sm4337130ejc.56.2022.02.28.13.21.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 13:21:37 -0800 (PST) From: luca.boccassi@gmail.com To: Brian Dooley Cc: Akhil Goyal , dpdk stable Subject: patch 'examples/l2fwd-crypto: fix port mask overflow' has been queued to stable release 20.11.5 Date: Mon, 28 Feb 2022 21:20:12 +0000 Message-Id: <20220228212047.3341966-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220228212047.3341966-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/ced86386114936f7692ebaef28f054c6510b4767 Thanks. Luca Boccassi --- >From ced86386114936f7692ebaef28f054c6510b4767 Mon Sep 17 00:00:00 2001 From: Brian Dooley Date: Mon, 21 Feb 2022 18:06:58 +0000 Subject: [PATCH] examples/l2fwd-crypto: fix port mask overflow [ upstream commit aaf4ac404362752e9c8effa4641bb480187d04ec ] Coverity flags an issue with 32-bit value. If max ethports value is configured with a value larger than 32 there will be an issue. Coverity issue: 375863 Unintentional integer overflow Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") Signed-off-by: Brian Dooley Acked-by: Akhil Goyal --- examples/l2fwd-crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 05f953e242..c1e26f5dd4 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -2636,7 +2636,7 @@ initialize_ports(struct l2fwd_crypto_options *options) last_portid = portid; } - l2fwd_enabled_port_mask |= (1 << portid); + l2fwd_enabled_port_mask |= (1ULL << portid); enabled_portcount++; } -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-28 21:17:55.296068342 +0000 +++ 0016-examples-l2fwd-crypto-fix-port-mask-overflow.patch 2022-02-28 21:17:53.840929230 +0000 @@ -1 +1 @@ -From aaf4ac404362752e9c8effa4641bb480187d04ec Mon Sep 17 00:00:00 2001 +From ced86386114936f7692ebaef28f054c6510b4767 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit aaf4ac404362752e9c8effa4641bb480187d04ec ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 4d9f8861af..bbdb263143 100644 +index 05f953e242..c1e26f5dd4 100644 @@ -23 +24 @@ -@@ -2719,7 +2719,7 @@ initialize_ports(struct l2fwd_crypto_options *options) +@@ -2636,7 +2636,7 @@ initialize_ports(struct l2fwd_crypto_options *options)