From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A488A0350 for ; Mon, 28 Feb 2022 22:21:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23ECA411B5; Mon, 28 Feb 2022 22:21:59 +0100 (CET) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id 8A3E0411AB for ; Mon, 28 Feb 2022 22:21:57 +0100 (CET) Received: by mail-wr1-f42.google.com with SMTP id r10so17458994wrp.3 for ; Mon, 28 Feb 2022 13:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=trMrcrzoEUGDOPjWmpEglVPtjCL7U+/Dod5lFfDBAf4=; b=Ajku/e2Myf6a/Q1fwIVNSw3aRt34pCrcJU7ANnSwY2KEg/s8gXmbSeOKypFvblNKY+ XBr4rFcvF2A7mFLl8lADYEI8hQpWaCCfQIOMI1b1I4oSHePi1ZiK4py63YJzpS624i4G mAJ9sGfch40L0vzqfPuLyazF6Zd8BaCw1RcK01xLJ6OeC7a/4wkGej7ihRDNfsZfZW4X CUCaW3O3skCPwQkemtNiHYQVSQfN19BMk3X+A4StjCj19Vyt2T6KNXzSMNVwnXfaJCII o/cWjl4MRq2Lxj2CAz+yF/+Ei4ZXrSwQPlnndlVbPvIwJG48gf/EbcwZzcOpsB4Q+3ud Cbsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=trMrcrzoEUGDOPjWmpEglVPtjCL7U+/Dod5lFfDBAf4=; b=hGWmg1v2xnFK630zbNZcIRJa6hQKHRfW5nyC1JMNkfJAr13/w5VQx5SP2LII+sT1An OgO90PkqKzrBpm/UPcYRob/yyuuu3oiMY/9T6hxGuqjPs9AcFKX+MCiwuG8IUrEXImeR wocJ/hFynN0VBSK8TZ4EYqYpMcj/+azyfyOeNiXpU0PNgGtm4aJw2bJmFrWvnhZiaP7O AaDj5nnptj0WYqz6cO9LbIOLSJYBLIvwVbZhUNb38NulegwpVaFcvUuzONsOpRfvLt4U nGZpgFu8cAckOsX2I5V/dEarsHzEDTRhrODdlvYDs9k3pIthTb7AUKuxNLQB1Ex/tL0L SlJA== X-Gm-Message-State: AOAM530GBxMAf9h/fglevSLWuvTzY8+d/cIUufSD6JobrqspDLY0tR3G H7dRyFYPmKiXOnF/x9AwBlo= X-Google-Smtp-Source: ABdhPJxrKnL8reZxfS6R/Yb8+LXSX6RoqUf29jKWr6E58Q0od1SyreE1pnv1S4iI5WLFn7lkqwkuXQ== X-Received: by 2002:adf:fbd0:0:b0:1e6:8ec3:570 with SMTP id d16-20020adffbd0000000b001e68ec30570mr18175785wrs.396.1646083317257; Mon, 28 Feb 2022 13:21:57 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id p30-20020a1c545e000000b003811f9102c0sm692002wmi.32.2022.02.28.13.21.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 13:21:56 -0800 (PST) From: luca.boccassi@gmail.com To: Yunjian Wang Cc: Haiyue Wang , dpdk stable Subject: patch 'net/ixgbe: reset security context pointer on close' has been queued to stable release 20.11.5 Date: Mon, 28 Feb 2022 21:20:19 +0000 Message-Id: <20220228212047.3341966-23-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220228212047.3341966-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/f85bba14cc776268d0e7540256b85df822c74c7e Thanks. Luca Boccassi --- >From f85bba14cc776268d0e7540256b85df822c74c7e Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Tue, 15 Feb 2022 21:01:51 +0800 Subject: [PATCH] net/ixgbe: reset security context pointer on close [ upstream commit 848a37cead7bd604d51b5f04507fea3e59e9088e ] When ixgbe_dev_close() is cleaning up, it does not correctly set the security_ctx variable to NULL, which will lead to wild pointer. Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") Signed-off-by: Yunjian Wang Acked-by: Haiyue Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 0853ae05d6..c741698d70 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -3055,6 +3055,7 @@ ixgbe_dev_close(struct rte_eth_dev *dev) #ifdef RTE_LIB_SECURITY rte_free(dev->security_ctx); + dev->security_ctx = NULL; #endif return ret; -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-28 21:17:55.831962002 +0000 +++ 0023-net-ixgbe-reset-security-context-pointer-on-close.patch 2022-02-28 21:17:53.884930196 +0000 @@ -1 +1 @@ -From 848a37cead7bd604d51b5f04507fea3e59e9088e Mon Sep 17 00:00:00 2001 +From f85bba14cc776268d0e7540256b85df822c74c7e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 848a37cead7bd604d51b5f04507fea3e59e9088e ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 3d799d2187..7643842560 100644 +index 0853ae05d6..c741698d70 100644 @@ -22 +23 @@ -@@ -3038,6 +3038,7 @@ ixgbe_dev_close(struct rte_eth_dev *dev) +@@ -3055,6 +3055,7 @@ ixgbe_dev_close(struct rte_eth_dev *dev)