From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55169A0350 for ; Mon, 28 Feb 2022 22:22:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DDB540140; Mon, 28 Feb 2022 22:22:02 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id CA7FD40140 for ; Mon, 28 Feb 2022 22:21:58 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id r187-20020a1c2bc4000000b003810e6b192aso241396wmr.1 for ; Mon, 28 Feb 2022 13:21:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MZ7LM9n1E/RzRLNWbyWF79ifdkukwQhW7NX0dMcwIWM=; b=q0iyq5qZVvwDeL99fcM04v1CbOdawAaJ3H4NsaEyGnRQ0PAOIuKFPX3//BP/C+kzce JWhnZuHpph8gTI8Uy7frbEVXj/MP+hvJGPyUS+LaiEZ1KuoU8DuJcK+6W/r0rYqtpLCL fbNhEylaqqHdj3Y/zN0TBDekUPm20D+Pwqruub9guJFbHrGVm8WYDHaHHJaB7Bgky00I EzyuEZlzP65Ay8uotIFLalTCXIJITCCb33E4iFdCCOAmCBxhaEBbRN3gslWg0hWo6Fg4 pfHS5X1ZOYNy/QBlDxR3zuAkvRm3+zOFBYGwHI9vsRQiV8eMzsJl1T/hNiRbgdyqzFEX 5LTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MZ7LM9n1E/RzRLNWbyWF79ifdkukwQhW7NX0dMcwIWM=; b=eoenAM31rww1KJHX+BZTNijskk8jaCTFNj1D87nqZf26qBOngJGV63vjbR4LMdjSaC +u4fvWv48QTWn4WMJ8u3oZG/nR1PWq+4iVnDIfwHBTkBqIROQhFlJynRfT9tDCtjJqx/ nPBweN+HSvKoENbYBsP+3sLNzlYdsFx98K2YKYbM3+x+3fBe5iNfPwcg3pPO7vX3V2Un 3rG+7r9mgUCDZGUY+TN2/xXQGvsXfjtUt3Ug3od5QQF/GYe5fo2VbBDFIWEI47EYYz0C s9MQDIZi+mFimz8ixa+Z9CoG7l26or8gf4cs19urFV7Fsyi6aEZIJalfpXzoTDXLosHr nMYQ== X-Gm-Message-State: AOAM533dHqaEpwMnIkgS1xl1cJcdoHN4uLY3kXco8UVjCS6FShikptiS YgD4xA/Gv5GHObOxZO385IU= X-Google-Smtp-Source: ABdhPJymZPKTaCF+NGmOI1llIQJqmc27mjGZPu7xBoKrSPFEo8ievvM/U4LESlx3v4rwrEVvAxsTeg== X-Received: by 2002:a05:600c:2905:b0:381:67e2:3992 with SMTP id i5-20020a05600c290500b0038167e23992mr5430890wmd.182.1646083318557; Mon, 28 Feb 2022 13:21:58 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id v20-20020a7bcb54000000b0037fa63db8aasm549489wmj.5.2022.02.28.13.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 13:21:57 -0800 (PST) From: luca.boccassi@gmail.com To: "Min Hu (Connor)" Cc: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: check starting port is not in bonding' has been queued to stable release 20.11.5 Date: Mon, 28 Feb 2022 21:20:20 +0000 Message-Id: <20220228212047.3341966-24-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220228212047.3341966-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/85ec94182b8437f701a82109ab0c3bdf6096cd0f Thanks. Luca Boccassi --- >From 85ec94182b8437f701a82109ab0c3bdf6096cd0f Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 17 Feb 2022 19:36:55 +0800 Subject: [PATCH] app/testpmd: check starting port is not in bonding [ upstream commit d8c079a572f3b76ca22fbfe665fb2e5e578ba881 ] In bond, start or stop slave port should be operated by bonding port. This patch add port_is_bonding_slave in start_port function. Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in bonding") Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit --- app/test-pmd/testpmd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 7e4b96d442..1a7488d8dc 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2442,6 +2442,13 @@ start_port(portid_t pid) if (pid != pi && pid != (portid_t)RTE_PORT_ALL) continue; + if (port_is_bonding_slave(pi)) { + fprintf(stderr, + "Please remove port %d from bonded device.\n", + pi); + continue; + } + need_check_link_status = 0; port = &ports[pi]; if (rte_atomic16_cmpset(&(port->port_status), RTE_PORT_STOPPED, -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-28 21:17:55.918679778 +0000 +++ 0024-app-testpmd-check-starting-port-is-not-in-bonding.patch 2022-02-28 21:17:53.892930370 +0000 @@ -1 +1 @@ -From d8c079a572f3b76ca22fbfe665fb2e5e578ba881 Mon Sep 17 00:00:00 2001 +From 85ec94182b8437f701a82109ab0c3bdf6096cd0f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d8c079a572f3b76ca22fbfe665fb2e5e578ba881 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 6d2e52c790..fe2ce19f99 100644 +index 7e4b96d442..1a7488d8dc 100644 @@ -22 +23 @@ -@@ -2726,6 +2726,13 @@ start_port(portid_t pid) +@@ -2442,6 +2442,13 @@ start_port(portid_t pid) @@ -35 +36 @@ - if (port->port_status == RTE_PORT_STOPPED) + if (rte_atomic16_cmpset(&(port->port_status), RTE_PORT_STOPPED,