From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D899A0350 for ; Mon, 28 Feb 2022 22:22:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5679C411AB; Mon, 28 Feb 2022 22:22:16 +0100 (CET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id CDE974067B for ; Mon, 28 Feb 2022 22:22:14 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id bg31-20020a05600c3c9f00b00381590dbb33so237297wmb.3 for ; Mon, 28 Feb 2022 13:22:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Nm3IWaM04VIlkh5rwFCTU/33hDfyh/8tWJV95g02O2E=; b=jcEqHj9nK2Hm+PkRsuR4M8TViqDsVDYEbL7T2ixiscxoBjFMeMoaAlUb1NnBQiIksW C8lpio4CoTihYz8HWd4umabUHDhY8TqdzjxqvBLmUkgRBKB7Gp6/kEY9TzufmlmrQkK8 gBDvO9YvFQMT75doz2aCbg+qLpLMPZDmszsAXuVWbpH1ws/NauqpP/IMucPQERVLTwcF dLvgWkpIuWBhxBCXLYIuEdxUhweqFFuAxVqlHK7jBEWJLVZJJ4/1bFabACxhM7GUz81S Jne7s1jKKbdPWeW+zThvq15fK7oTXylgEF72YhjVR1AE698pDDGtF38pCMgFcz+vGgdT fU6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Nm3IWaM04VIlkh5rwFCTU/33hDfyh/8tWJV95g02O2E=; b=jAts1mLZ9ztPM6B2+gSxNlaI1M9z5MWVuJjz9EBP37MCCtSg72YKqqIbH/S+pKxRh3 wj+P2XcAyoR/kAuEH/1x7BysJgi/WR0catMVtoM3TtdqknSvWYvqNLBXzCPTGZTPYyHW MfmCFe9xmwSXBigoIWoX1E4FMElSaqEkOZRKDULra2LtXvdkC0TUDfmEZlWM4wypxvYF NRQUqdmgL+Ia5AuoRu35nQo200/ZeKLgDygN2SGmaGSJ3R1+IVfy3jSRAADpPPCRsBwy rY8ESqaIEHSCx2iHvYiu2sMZTC4SDfE/LGDW6atO92GUzn7rkUcvl9eDEzR/DNNN8gB2 JMQw== X-Gm-Message-State: AOAM531ER56raQYhI1o2wTO8ae7hCtF3RWALhw4OVjfPZMqfsiLdYjVT 8oojbGm3mk2BnCUbbB5LqBs= X-Google-Smtp-Source: ABdhPJzuVeWneW9ub2RAgSOZls6ZEfPCCFBv0r1pD2WnGnl6uQrmEoJhNH3pjzBk2JcIJBmBMZ7kwQ== X-Received: by 2002:a05:600c:4ec6:b0:352:cc24:1754 with SMTP id g6-20020a05600c4ec600b00352cc241754mr14493231wmq.184.1646083334553; Mon, 28 Feb 2022 13:22:14 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id r42-20020a05600c322a00b00380dc2e0d63sm506485wmp.1.2022.02.28.13.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 13:22:13 -0800 (PST) From: luca.boccassi@gmail.com To: Michal Wilczynski Cc: Haiyue Wang , dpdk stable Subject: patch 'net/ice: fix overwriting of LSE bit by DCF' has been queued to stable release 20.11.5 Date: Mon, 28 Feb 2022 21:20:25 +0000 Message-Id: <20220228212047.3341966-29-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220228212047.3341966-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/7eaca36d9c661619bbd62e2ef50899a366b56296 Thanks. Luca Boccassi --- >From 7eaca36d9c661619bbd62e2ef50899a366b56296 Mon Sep 17 00:00:00 2001 From: Michal Wilczynski Date: Fri, 18 Feb 2022 12:57:19 +0100 Subject: [PATCH] net/ice: fix overwriting of LSE bit by DCF [ upstream commit ea9fac93e1ca1f0684b2ccdad9467a7760b4a3eb ] After enabling DCF on a VF, the ice driver stops receiving link updates on it's Admin Receive Queue. During the init of DCF ice_aqc_opc_get_link_status command is send to the firmware without LSE (Link Status Event) bit set. This prevents the ice driver from receiving up/down events, and correspondingly updating netdev. Fixes: 0b02c9519432 ("net/ice: handle PF initialization by DCF") Signed-off-by: Michal Wilczynski Acked-by: Haiyue Wang --- drivers/net/ice/ice_dcf_parent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c index ad94953932..c7c1111a67 100644 --- a/drivers/net/ice/ice_dcf_parent.c +++ b/drivers/net/ice/ice_dcf_parent.c @@ -220,7 +220,7 @@ ice_dcf_init_parent_hw(struct ice_hw *hw) goto err_unroll_alloc; /* Initialize port_info struct with link information */ - status = ice_aq_get_link_info(hw->port_info, false, NULL, NULL); + status = ice_aq_get_link_info(hw->port_info, true, NULL, NULL); if (status) goto err_unroll_alloc; -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-28 21:17:56.291916369 +0000 +++ 0029-net-ice-fix-overwriting-of-LSE-bit-by-DCF.patch 2022-02-28 21:17:53.920930984 +0000 @@ -1 +1 @@ -From ea9fac93e1ca1f0684b2ccdad9467a7760b4a3eb Mon Sep 17 00:00:00 2001 +From 7eaca36d9c661619bbd62e2ef50899a366b56296 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ea9fac93e1ca1f0684b2ccdad9467a7760b4a3eb ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 0c8c2ed6c7..2f96dedcce 100644 +index ad94953932..c7c1111a67 100644 @@ -26 +27 @@ -@@ -340,7 +340,7 @@ ice_dcf_init_parent_hw(struct ice_hw *hw) +@@ -220,7 +220,7 @@ ice_dcf_init_parent_hw(struct ice_hw *hw)