From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBCB0A0350 for ; Mon, 28 Feb 2022 22:22:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2F05411C3; Mon, 28 Feb 2022 22:22:32 +0100 (CET) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mails.dpdk.org (Postfix) with ESMTP id 3DF3A40140 for ; Mon, 28 Feb 2022 22:22:32 +0100 (CET) Received: by mail-wr1-f47.google.com with SMTP id b5so17491746wrr.2 for ; Mon, 28 Feb 2022 13:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HHUgKasAZoDWUyyA7+gERRaNWxDXhWByciDUYYQJsYQ=; b=HUNERmLhLGiMn5Nef+0E8nWAoACx6SdAl04g3oSsWXJ5C9rTWhMmJs149Uq981yN38 TYIN6kb465F2rYb58VzMDC2NQGeZo0HpjhUZQNs6YvrRP1Y5D29n+LpqNcpnpNnvx60c h5CSeHXAgukuYL8JKv9/eIfwdY75VsumXeM6ajJ5Jp9pWN/+IGRGj/BJJjrpIaOdfBy4 yBqx9MCp0VP0ANWtYQgYBoXwosFrs4UBOP8+NXHU/ge7hQ8zKMvPnRxHDEqvwGGClRqR fMOYfuQytBxvcjtQERjl+x6B6oOOFhUmJq0iDG+HyMTZ2mhFsBMvPVXtxNi1mVXNAw1Y RT1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HHUgKasAZoDWUyyA7+gERRaNWxDXhWByciDUYYQJsYQ=; b=1HSNMKNwpFo+ju4jfGE9BcETxecGY+iz4a5FyViAj3ZQKDMEA5D14vX0Phk9Dt1l/q gqA8L5YkuMbDXF4FZVgD8LslRhsFFKN4lYOovfKNZSFkH7FHP8Ph0TMuzcC8CjgxrgHd uy/N1vwL7rOG0h00ilBOLRJ4Tc0FJAFBKr81R6Gz1o7xAK1RNabFnwqRxiBqLYugcqlA gjDCz2xMJ+dTqQoY6Rt8/5BLIH8RcgYKtK3MNQiGegmGM5Gj/byZBYoxufYkL7BzTSnE LX9iw3U6YqeyLgDvgRzP85dfez6tscWirX9gaFuY3f31tWIPvnm2zrRVPQPlFfN/LxL7 BszA== X-Gm-Message-State: AOAM53139dlHIpE0JzxkyNflrkD/R0XsP4/MMuwYL6380VuPHydLyAhd +xAOc9m7mK7Lvuv9iMUJ68H4VnwCfxcIn+It X-Google-Smtp-Source: ABdhPJyGQnq5girhh7vpsCqebI8eW5UhtTQgWf67SQKWz9IrynsM2tUzzzt0j3kpU5vtDtdK163A6w== X-Received: by 2002:adf:fa48:0:b0:1f0:d71:f9a with SMTP id y8-20020adffa48000000b001f00d710f9amr48067wrr.50.1646083351963; Mon, 28 Feb 2022 13:22:31 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id v124-20020a1cac82000000b0037c3d08e0e7sm526575wme.29.2022.02.28.13.22.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 13:22:31 -0800 (PST) From: luca.boccassi@gmail.com To: Michal Krawczyk Cc: Artur Rojek , Dawid Gorecki , Igor Chauskin , Shai Brandes , dpdk stable Subject: patch 'net/ena: remove unused offload variables' has been queued to stable release 20.11.5 Date: Mon, 28 Feb 2022 21:20:31 +0000 Message-Id: <20220228212047.3341966-35-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220228212047.3341966-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/39f6adbf547a9c624360ad612c0b9522f1520afd Thanks. Luca Boccassi --- >From 39f6adbf547a9c624360ad612c0b9522f1520afd Mon Sep 17 00:00:00 2001 From: Michal Krawczyk Date: Wed, 23 Feb 2022 13:19:27 +0100 Subject: [PATCH] net/ena: remove unused offload variables [ upstream commit fa11980449c225a217bf6923e79924edf991cb27 ] Those variables are being set, but never read. As they seem to be leftover from the old offloads API and don't have any purpose right now, they are simply being removed. Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API") Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 --- drivers/net/ena/ena_ethdev.h | 5 ----- 2 files changed, 8 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 207709c0ca..3359ca79d2 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2023,9 +2023,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev) */ dev->data->scattered_rx = 1; - adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads; - adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads; - return 0; } diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h index e344941ef7..7bb3ff2b9e 100644 --- a/drivers/net/ena/ena_ethdev.h +++ b/drivers/net/ena/ena_ethdev.h @@ -246,11 +246,6 @@ struct ena_adapter { struct ena_driver_stats *drv_stats; enum ena_adapter_state state; - uint64_t tx_supported_offloads; - uint64_t tx_selected_offloads; - uint64_t rx_supported_offloads; - uint64_t rx_selected_offloads; - bool link_status; enum ena_regs_reset_reason_types reset_reason; -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-28 21:17:56.780596435 +0000 +++ 0035-net-ena-remove-unused-offload-variables.patch 2022-02-28 21:17:53.980932299 +0000 @@ -1 +1 @@ -From fa11980449c225a217bf6923e79924edf991cb27 Mon Sep 17 00:00:00 2001 +From 39f6adbf547a9c624360ad612c0b9522f1520afd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fa11980449c225a217bf6923e79924edf991cb27 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 2de2dcf12f..de5fdb8f1d 100644 +index 207709c0ca..3359ca79d2 100644 @@ -27 +28 @@ -@@ -2015,9 +2015,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev) +@@ -2023,9 +2023,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev) @@ -29 +30 @@ - adapter->tx_cleanup_stall_delay = adapter->missing_tx_completion_to / 2; + dev->data->scattered_rx = 1; @@ -38 +39 @@ -index f47ba3fb02..4dfa604d51 100644 +index e344941ef7..7bb3ff2b9e 100644 @@ -41 +42 @@ -@@ -278,11 +278,6 @@ struct ena_adapter { +@@ -246,11 +246,6 @@ struct ena_adapter {