From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43F56A0350 for ; Mon, 28 Feb 2022 22:22:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25A2C40140; Mon, 28 Feb 2022 22:22:49 +0100 (CET) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id B955A40140 for ; Mon, 28 Feb 2022 22:22:45 +0100 (CET) Received: by mail-wr1-f48.google.com with SMTP id d17so17403829wrc.9 for ; Mon, 28 Feb 2022 13:22:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4d4VCx5UK8zzygpoVsexDx3d5DjzAMd9vPsVrtFhDBs=; b=FynsYtjjZplBKSkSYXAD0rSciBGDWjLhuSVyTfCuAVZocN/GFYrr/gQATW9ajBmSpo Y5d6lg1bQZzSs7sxK4EKMlEpkGARpdbvSI8YT5UgHtOHILxbjEJvKfJBSc6SERxtMflr PpmgB5Ryd4sRcoLl+WFEAjOEbzgpdS1vLs2JOJpr6gHLBD5HfIp/dO1NKi5Kh9/zJdyu PQYtHNwPbt68Cctp5A8DVoxizZKziDfgmLa3zC5W7kVuvaCfotVdH18V271N6PsC/0nj s4A6GPp5y6J4qZcSj728AinJ7/mlm8jG7p6q4mBl9GRIMTxT4mSdjXm/5ZsmvWQd7Kyk 8y2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4d4VCx5UK8zzygpoVsexDx3d5DjzAMd9vPsVrtFhDBs=; b=MrWxyFSjRhBsc90S1ikN86osBCt55tF4eMuA2/Gni6hkbmo/rOPhBVus35CrFDaIe8 fe7/11vpQHFgdE64a0egEDFzAG6THdYhzM17CGzELv4zrMSFSI7C459S6vPHQV63n0WU KEIdVUZ81hNm0lV2bXo41D9QjZYWzoN8/oFTeiXkvLgfHr59wMs9qI3fqnAWbizJdAgM Qhn6JiGbuhO+5DlOsV9z/lqiwZEUBcI2C2KQz75acPvp4aveLLb6FDaQzRddyprK1Bfk aWYV/72X3+PQE8VJ8r5FMTMpblqqjWM7w/zrZA266RI9Jru64IZ+xDVl+Mxk9xfFrXFN GdDQ== X-Gm-Message-State: AOAM533LDHdmmSHC0UuOMnN2KucYwKJNDm7zymSTcbY+y/VVKVVq2NMp BpMN5daZj+2hZuMqbw5e0O60UIc335pb9sIt X-Google-Smtp-Source: ABdhPJxsSJoPW4whzBbdpuWlZaQ4mhLoavYL4unxmm/LEyPYhaboAb0PxXceMeOzRFztTHmoYvsRIw== X-Received: by 2002:adf:e28f:0:b0:1ef:9b69:9981 with SMTP id v15-20020adfe28f000000b001ef9b699981mr6774792wri.478.1646083365484; Mon, 28 Feb 2022 13:22:45 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id c11-20020a05600c0a4b00b0037c91e085ddsm713950wmq.40.2022.02.28.13.22.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 13:22:45 -0800 (PST) From: luca.boccassi@gmail.com To: Michal Krawczyk Cc: Dawid Gorecki , Shai Brandes , dpdk stable Subject: patch 'net/ena: fix meta descriptor DF flag setup' has been queued to stable release 20.11.5 Date: Mon, 28 Feb 2022 21:20:34 +0000 Message-Id: <20220228212047.3341966-38-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220228212047.3341966-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/abbaa0b9d15ab2e0598877bdea27ac0e00766413 Thanks. Luca Boccassi --- >From abbaa0b9d15ab2e0598877bdea27ac0e00766413 Mon Sep 17 00:00:00 2001 From: Michal Krawczyk Date: Wed, 23 Feb 2022 13:19:40 +0100 Subject: [PATCH] net/ena: fix meta descriptor DF flag setup [ upstream commit 022fb61b62623868db2ec9dbe5b1ee43a4d6cbfb ] Whenever Tx checksum offload is being used, the meta descriptor content is taken into consideration. Setting DF field properly in the meta descriptor may have huge impact on the performance both for the IPv4 and IPv6 packets. The requirements for the df field are as below: * No offload used - value doesn't matter * IPv4 - 0 or 1, depending on the DF flag in the IPv4 header * IPv6 - 1 Setting DF to 0 causes the packet to enter the slow-path in the HW and as a result can noticeable impact the performance. Moreover, as 'true' may not always be mapped to 1 depending on it's definition for the given platform/compiler, for safety DF field is being set explicitly to 1. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 13154602a2..f17679e3f8 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -374,6 +374,8 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, if (mbuf->ol_flags & PKT_TX_IPV6) { ena_tx_ctx->l3_proto = ENA_ETH_IO_L3_PROTO_IPV6; + /* For the IPv6 packets, DF always needs to be true. */ + ena_tx_ctx->df = 1; } else { ena_tx_ctx->l3_proto = ENA_ETH_IO_L3_PROTO_IPV4; @@ -381,7 +383,7 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, if (mbuf->packet_type & (RTE_PTYPE_L4_NONFRAG | RTE_PTYPE_INNER_L4_NONFRAG)) - ena_tx_ctx->df = true; + ena_tx_ctx->df = 1; } /* check if L4 checksum is needed */ -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-28 21:17:57.004018379 +0000 +++ 0038-net-ena-fix-meta-descriptor-DF-flag-setup.patch 2022-02-28 21:17:54.000932737 +0000 @@ -1 +1 @@ -From 022fb61b62623868db2ec9dbe5b1ee43a4d6cbfb Mon Sep 17 00:00:00 2001 +From abbaa0b9d15ab2e0598877bdea27ac0e00766413 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 022fb61b62623868db2ec9dbe5b1ee43a4d6cbfb ] + @@ -24 +25,0 @@ -Cc: stable@dpdk.org @@ -34 +35 @@ -index 0ca4269522..53a8071968 100644 +index 13154602a2..f17679e3f8 100644 @@ -37 +38 @@ -@@ -624,6 +624,8 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, +@@ -374,6 +374,8 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, @@ -39 +40 @@ - if (mbuf->ol_flags & RTE_MBUF_F_TX_IPV6) { + if (mbuf->ol_flags & PKT_TX_IPV6) { @@ -46 +47 @@ -@@ -631,7 +633,7 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, +@@ -381,7 +383,7 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf,