From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1F28A0350 for ; Mon, 28 Feb 2022 22:22:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A130B40140; Mon, 28 Feb 2022 22:22:59 +0100 (CET) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by mails.dpdk.org (Postfix) with ESMTP id 1F53740140 for ; Mon, 28 Feb 2022 22:22:59 +0100 (CET) Received: by mail-ej1-f48.google.com with SMTP id qa43so914004ejc.12 for ; Mon, 28 Feb 2022 13:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e70qT20squtn4bv3ZyYv56sw8Q8eWEvdNQcGSe6UDRU=; b=RXv5HkQcsALKN+T27FKWFnbXPcKZLVr1S4PUBm/HcB72smOs1iIYyfgBNTtJitSDmg e/XTe24OooJ6F/CHiepymG4DfSCZAV2COC/BhukvZ7GxL5xkAbu1ycd2NTQNuOzssR7B JPlKE+oCzKRkVabIy7wN68EFyksyjKp+tNZa6fQFkpWSM6YkrI0Ogy555TEsfEpTAlHR zotO/qrY5JkRHYkcn72ILPT1JIVLpLOS208uXFNYnHpcALZAi1yrHP+7K4D0k2XcrJs0 lqtc0b1w97jcg4+Ctak9BJtcYkYRI2I8Z1qKPouEpCRSSzZIyGm1ZHQn59hY9oMvYtg7 9//w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e70qT20squtn4bv3ZyYv56sw8Q8eWEvdNQcGSe6UDRU=; b=3i92riQaoc4p0Xgoi4PgV/CGBu6VcuqAFqQ9uA6/Z6Is8rMcYjTT+qohjq96gV9d67 RhGVwPdh5pXFXgJfuFlOxcTZzIJMPQY8FIEguqPJafKyf5657i6gXPAqKNbPB+Pe2UTl 7mGcqgFirCWynXvAjrw5fFxK5jXr4lQRTfCwxyOa5xMyOUb/9pl7MTpbP04mCvngWWqq rz+cP6jATQXq6Tc4NIcAT8DJ+m3vtLIfjvJEJP9xorLyp5RaORmQDDcutv75ihcnZU1+ XlFrAzMn4ys5HM1BGRFacjW+vdgmojICa+2085Rwpw1KpeoBweDOEFzlpM+7VJn6yxMp lvzg== X-Gm-Message-State: AOAM5320CDL0RfPtIuF7pT3Oi5lRqfxljbteesA6ZLlk9SGovZtIGibs u13TU73vF88H0BCS5l8anfdlOvLkNK8V+4Uv X-Google-Smtp-Source: ABdhPJxd3Sf3m+icexamJ6ItpqdTrePQMq5sB4hBifx4GfiWj6C5gu3iiHtxzc2WRF5t2cWvmMZuZw== X-Received: by 2002:a17:906:3515:b0:6cf:1189:c512 with SMTP id r21-20020a170906351500b006cf1189c512mr16822394eja.161.1646083378793; Mon, 28 Feb 2022 13:22:58 -0800 (PST) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id q1-20020a50c341000000b00412ea00941dsm6418151edb.18.2022.02.28.13.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 13:22:58 -0800 (PST) From: luca.boccassi@gmail.com To: Yajun Wu Cc: Matan Azrad , dpdk stable Subject: patch 'common/mlx5: fix queue pair ack timeout configuration' has been queued to stable release 20.11.5 Date: Mon, 28 Feb 2022 21:20:37 +0000 Message-Id: <20220228212047.3341966-41-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220228212047.3341966-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/15f171576e7dcd16ee8f599edd8c46ec4d4e3e17 Thanks. Luca Boccassi --- >From 15f171576e7dcd16ee8f599edd8c46ec4d4e3e17 Mon Sep 17 00:00:00 2001 From: Yajun Wu Date: Mon, 14 Feb 2022 08:03:19 +0200 Subject: [PATCH] common/mlx5: fix queue pair ack timeout configuration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 05b54bf0892dcd1e3698ba86a297722b7566cc10 ] VDPA driver creates two QPs(1 queue pair include 1 send queue and 1 receive queue) per virtio queue to get traffic events from NIC to SW. Two QPs(called FW QP and SW QP) are created as loopback QP and FW QP'SQ is connected to SW QP'RQ internally. When packet receive or send out, HW will send WQE by FW QP'SQ, then SW will get CQE from the CQ of SW QP. With large scale and heavy traffic, the SQ's request may fail to get ACK from RQ HW, because HW is busy. SQ will retry the request with qpc.retry_count times and each time wait for 4.096 uS *2^(ack_timeout) for the response. If still can’t get RQ’s HW response, SQ will go to an error state. 16 is experienced value. It should not be too high or too low. Too high will make QP waits too long in case it’s packet drop. Too low will cause QP to go to an error state(retry-exceeded) easily. Fixes: 15c3807e86ab ("common/mlx5: support DevX QP operations") Signed-off-by: Yajun Wu Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index e6aebf4156..ef82981927 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -1975,7 +1975,7 @@ mlx5_devx_cmd_modify_qp_state(struct mlx5_devx_obj *qp, uint32_t qp_st_mod_op, case MLX5_CMD_OP_RTR2RTS_QP: qpc = MLX5_ADDR_OF(rtr2rts_qp_in, &in, qpc); MLX5_SET(rtr2rts_qp_in, &in, qpn, qp->id); - MLX5_SET(qpc, qpc, primary_address_path.ack_timeout, 14); + MLX5_SET(qpc, qpc, primary_address_path.ack_timeout, 16); MLX5_SET(qpc, qpc, log_ack_req_freq, 0); MLX5_SET(qpc, qpc, retry_count, 7); MLX5_SET(qpc, qpc, rnr_retry, 7); -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-28 21:17:57.220077698 +0000 +++ 0041-common-mlx5-fix-queue-pair-ack-timeout-configuration.patch 2022-02-28 21:17:54.012933001 +0000 @@ -1 +1 @@ -From 05b54bf0892dcd1e3698ba86a297722b7566cc10 Mon Sep 17 00:00:00 2001 +From 15f171576e7dcd16ee8f599edd8c46ec4d4e3e17 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 05b54bf0892dcd1e3698ba86a297722b7566cc10 ] + @@ -29 +30,0 @@ -Cc: stable@dpdk.org @@ -38 +39 @@ -index 2e807a0829..7732613c69 100644 +index e6aebf4156..ef82981927 100644 @@ -41 +42 @@ -@@ -2279,7 +2279,7 @@ mlx5_devx_cmd_modify_qp_state(struct mlx5_devx_obj *qp, uint32_t qp_st_mod_op, +@@ -1975,7 +1975,7 @@ mlx5_devx_cmd_modify_qp_state(struct mlx5_devx_obj *qp, uint32_t qp_st_mod_op,