From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71F56A0350 for ; Mon, 28 Feb 2022 22:23:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C7F9411AB; Mon, 28 Feb 2022 22:23:17 +0100 (CET) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by mails.dpdk.org (Postfix) with ESMTP id 3F74140140 for ; Mon, 28 Feb 2022 22:23:16 +0100 (CET) Received: by mail-ed1-f49.google.com with SMTP id s24so19431130edr.5 for ; Mon, 28 Feb 2022 13:23:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m4mypPzpmgdx7J6J8yzeQENW8U1ImRla5rlzkl0fg0s=; b=Qv71USSo+HrUQq08xGPhRV9hdvZ5qCLuH63NaSuCfAkx4IRF+IOueVCivfiIICqx2o 45speNLTs52ntQ27dcn7yRMC0CRqRH1WprpYU2xPST6h+U9YrJ4uQLdC1g9ezbW4Qpyu apk+db5xUwTfTMM3PwdgTLjz6ol4BYFt0vkc64i9Lq8HBrLoCd5LZ8P/GVi97Mc4Olpq hE+UQXk/aVzMmKAWsRcsiRmCH1zBJqYaQj6Yqa3Vgo5P8GTSlZJ6c80GvURRHIP7rQKC 91cJ8onHwZ1pq/ky9SdCpZkzWvUL743lpu5ulqzvRNBDj8/h3nhB1UNy5gkINxM/Xl8x R4nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m4mypPzpmgdx7J6J8yzeQENW8U1ImRla5rlzkl0fg0s=; b=zFNNdE3xSwrpptt8XMdpmioIrt6v5VYai/8gIIBe+kUYKEp47pEqEHXpLbLNd75jlu Kotw8FoE8stTDEb169YtXZSIoruskuNFGSSiMmWmw36IXtNnUy56PD2zbY9kLbwwmBUD 7UozjEcmM9OI7pXXlBxbIixP2i4pWXvCzKZDeQuoZr+gQGol+N/JkiQ2KSN9Jrumih/2 JpdvtvWeLVfCeUp/9dZDQGp35ER4fh9/JPEC4mOtSZAhQZOwxwscmQV71cNBcrhx3oq8 2dznsLTaXjykrKRxxs51AjDy04U5Jf/tiw562pNL09OJNrUJ6fSkFVLItsrVSzLc/51y 5i8w== X-Gm-Message-State: AOAM532W5S/NKoB+1vFSXOuKYZBIHvcSz+5isMDRIwmpa8i26qSkgE7Z qYuYczXNhUQF3b131JARGqwuAm31lVkB4g+J X-Google-Smtp-Source: ABdhPJxEx66Wgx3I97JOAngvagv2vxyPsJOwE8gmITPsWZK6ZqBPJ3tvmBWYsSfePPP0FKxEUldGgA== X-Received: by 2002:aa7:c948:0:b0:413:2bed:e82e with SMTP id h8-20020aa7c948000000b004132bede82emr21720470edt.394.1646083395926; Mon, 28 Feb 2022 13:23:15 -0800 (PST) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id v10-20020a170906380a00b006a68610908asm4696018ejc.24.2022.02.28.13.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 13:23:15 -0800 (PST) From: luca.boccassi@gmail.com To: Pablo de Lara Cc: Yipeng Wang , dpdk stable Subject: patch 'test/efd: fix sockets mask size' has been queued to stable release 20.11.5 Date: Mon, 28 Feb 2022 21:20:43 +0000 Message-Id: <20220228212047.3341966-47-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220228212047.3341966-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/5cd3c071a3b084f79d6f6d5e51fac386b198ea7f Thanks. Luca Boccassi --- >From 5cd3c071a3b084f79d6f6d5e51fac386b198ea7f Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Fri, 25 Feb 2022 09:27:44 +0000 Subject: [PATCH] test/efd: fix sockets mask size [ upstream commit 3b0e34e80b55bbd683f4aa8257e25cbea029489b ] Constant value 1 has a size of 32 bits, and shifting it more than 32 bits to the left overflows. 1ULL is needed to be able to get a 64-bit value. Coverity ID: 375846 Fixes: 8751a7e9832b ("efd: allow more CPU sockets in table creation") Signed-off-by: Pablo de Lara Acked-by: Yipeng Wang --- app/test/test_efd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_efd.c b/app/test/test_efd.c index 180dc4748e..97498d57aa 100644 --- a/app/test/test_efd.c +++ b/app/test/test_efd.c @@ -98,7 +98,7 @@ static inline uint8_t efd_get_all_sockets_bitmask(void) unsigned int next_lcore = rte_get_main_lcore(); const int val_true = 1, val_false = 0; for (i = 0; i < rte_lcore_count(); i++) { - all_cpu_sockets_bitmask |= 1 << rte_lcore_to_socket_id(next_lcore); + all_cpu_sockets_bitmask |= 1ULL << rte_lcore_to_socket_id(next_lcore); next_lcore = rte_get_next_lcore(next_lcore, val_false, val_true); } -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-28 21:17:57.733537014 +0000 +++ 0047-test-efd-fix-sockets-mask-size.patch 2022-02-28 21:17:54.060934052 +0000 @@ -1 +1 @@ -From 3b0e34e80b55bbd683f4aa8257e25cbea029489b Mon Sep 17 00:00:00 2001 +From 5cd3c071a3b084f79d6f6d5e51fac386b198ea7f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3b0e34e80b55bbd683f4aa8257e25cbea029489b ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 7bea674086..fa29e8f97a 100644 +index 180dc4748e..97498d57aa 100644 @@ -23 +24 @@ -@@ -107,7 +107,7 @@ static inline uint64_t efd_get_all_sockets_bitmask(void) +@@ -98,7 +98,7 @@ static inline uint8_t efd_get_all_sockets_bitmask(void)