From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E2B7A0350 for ; Mon, 28 Feb 2022 22:23:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88DFB40140; Mon, 28 Feb 2022 22:23:21 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id 5029C40140 for ; Mon, 28 Feb 2022 22:23:17 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id k29-20020a05600c1c9d00b003817fdc0f00so235333wms.4 for ; Mon, 28 Feb 2022 13:23:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P9z9FK+4KyaJ/TXrJX+8fCG9ld5lRsCndu/wjBH2yic=; b=equhwBvoGA4mtH8eUWHbgEgGtWm8hxu9JTQlblOWF1BgKzPHRLFQnM2ATgM9vDtN5X oB0KEtB5Z7WJzR6kRz9rQtNFu/DBxFN0P4OQxjtCUODMJiHDovb06RptVeO3PV3UhJFM IDYeOc4ZKIG0hKL8C6Gw6z5XUReLIvSjalk6t8Ruju+lQv0idX6dl1XLBOM86WH9eUe5 inAP1DSp8XacX7hDnSuhiCI8FCxFnxhFi2HCF9ZNL6lFSjHtYWJeIG4jIU+xCGG/KNSV oWVOFK0itk/lLICfhwC8lpyecE6i+VZsKZRpqkWnCm1SG7enYp46xAlvq8UbX5J4WVNc L0Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P9z9FK+4KyaJ/TXrJX+8fCG9ld5lRsCndu/wjBH2yic=; b=ctbmtnHDIXcRG01iLMqCJaROd7CO7wFWnMP7VGCBNt57HH2NJGSkGz16DwfDjAWHdv u7FTQESvZ+729+EE2WuNwStXjUB0DR9Wokz86Egh1xxZJpujtllFZTCAgE46L3MWFBzn t7fFEhrlFMVaB28jyVM7xTtSfasCeqgJLflcx5rrKXCJYGmqKaOlPH0Ysw5nI9Qjt1Q3 R9BF8uyMmbWbcjXRlRmFvzspgsyF3uH/DAs76oq/Jf9BjWiqRzxZMvmzufKGLhg+KYaI /B4KGpsyqzKo9P86eHMon3X34pt3LvcfEdOjDbSOZwW84VHKBRHOrhktUV0mTDNYHIXN bPQA== X-Gm-Message-State: AOAM532c8EWWT6VL9wKFufhcGh00dJqItvQNVR7CKVVbq94aHY4tJ2nD bzfSVkWtBT+mK3uuCHbZ42s= X-Google-Smtp-Source: ABdhPJypKlxYEGCgDGfk4GEpoPq9AfbSORtXfXxARhb38WfjO49Uqqk4DZYLTLEUrMaOGa5VGN/PrA== X-Received: by 2002:a05:600c:147:b0:380:f51a:334e with SMTP id w7-20020a05600c014700b00380f51a334emr14769180wmm.132.1646083397011; Mon, 28 Feb 2022 13:23:17 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id x18-20020a1c7c12000000b0037c94766961sm508341wmc.20.2022.02.28.13.23.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 13:23:16 -0800 (PST) From: luca.boccassi@gmail.com To: Pablo de Lara Cc: Yipeng Wang , dpdk stable Subject: patch 'efd: fix uninitialized structure' has been queued to stable release 20.11.5 Date: Mon, 28 Feb 2022 21:20:44 +0000 Message-Id: <20220228212047.3341966-48-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220228212047.3341966-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/02/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/ffc6e4ea387b2dc7f2662b507dcd0abbd6caafdd Thanks. Luca Boccassi --- >From ffc6e4ea387b2dc7f2662b507dcd0abbd6caafdd Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Fri, 25 Feb 2022 09:27:45 +0000 Subject: [PATCH] efd: fix uninitialized structure [ upstream commit ecda2c40ac549f2ebd1e8be6bf0a96c4aba6bf36 ] Coverity flags that both elements of efd_online_group_entry are used uninitialized. This is OK because this structure is initially used for starting values, so any value is OK. Coverity ID: 375868 Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Signed-off-by: Pablo de Lara Acked-by: Yipeng Wang --- lib/librte_efd/rte_efd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c index 77f46809f8..ae9fb43404 100644 --- a/lib/librte_efd/rte_efd.c +++ b/lib/librte_efd/rte_efd.c @@ -1165,7 +1165,7 @@ rte_efd_update(struct rte_efd_table * const table, const unsigned int socket_id, { uint32_t chunk_id = 0, group_id = 0, bin_id = 0; uint8_t new_bin_choice = 0; - struct efd_online_group_entry entry; + struct efd_online_group_entry entry = {{0}}; int status = efd_compute_update(table, socket_id, key, value, &chunk_id, &group_id, &bin_id, -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-02-28 21:17:57.811242463 +0000 +++ 0048-efd-fix-uninitialized-structure.patch 2022-02-28 21:17:54.064934139 +0000 @@ -1 +1 @@ -From ecda2c40ac549f2ebd1e8be6bf0a96c4aba6bf36 Mon Sep 17 00:00:00 2001 +From ffc6e4ea387b2dc7f2662b507dcd0abbd6caafdd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ecda2c40ac549f2ebd1e8be6bf0a96c4aba6bf36 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - lib/efd/rte_efd.c | 2 +- + lib/librte_efd/rte_efd.c | 2 +- @@ -20,5 +21,5 @@ -diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c -index 560cd78961..bbc6fc585d 100644 ---- a/lib/efd/rte_efd.c -+++ b/lib/efd/rte_efd.c -@@ -1162,7 +1162,7 @@ rte_efd_update(struct rte_efd_table * const table, const unsigned int socket_id, +diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c +index 77f46809f8..ae9fb43404 100644 +--- a/lib/librte_efd/rte_efd.c ++++ b/lib/librte_efd/rte_efd.c +@@ -1165,7 +1165,7 @@ rte_efd_update(struct rte_efd_table * const table, const unsigned int socket_id,