From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7601CA034F for ; Tue, 1 Mar 2022 11:46:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DD4B407FF; Tue, 1 Mar 2022 11:46:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 62EDE426DE for ; Tue, 1 Mar 2022 11:46:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OEWaKV/JypYPCPD5i9yzQBzYcuan0dvyrjAE612ckg0=; b=BaQwswkSiSQVOV3Cv3rOrJ1EiQZ/JsjG4IJhL0hsK4JdvNFyRv+L7V8lVXlrm5dKoAPJ9B qSaH5d0M1oGdHJk11Y1r948UfmJJkOuCn1kfaT2KR/N99076e4r9tVLjUK4+5dHZ/AfGas X+h7ONlIokalcDduZ6WkObROZ7QKwUo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-623-DUikCN5ONgi8VsCRmj1L3g-1; Tue, 01 Mar 2022 05:46:18 -0500 X-MC-Unique: DUikCN5ONgi8VsCRmj1L3g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53D06801AB2; Tue, 1 Mar 2022 10:46:15 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C261721DF; Tue, 1 Mar 2022 10:46:14 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: David Hunt , dpdk stable Subject: patch 'distributor: fix potential overflow' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:42:56 +0000 Message-Id: <20220301104300.334382-100-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/32f77d388449d619264babe3e64d0aeca0a25c58 Thanks. Kevin --- >From 32f77d388449d619264babe3e64d0aeca0a25c58 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Thu, 17 Feb 2022 15:02:39 +0000 Subject: [PATCH] distributor: fix potential overflow [ upstream commit 9699b09803b799ddc11abedffb17af059c992e9a ] Coverity flags the fact that the tag values used in distributor are 32-bit, which means that when we use bit-manipulation to convert a tag match/no-match to a bit in an array, we need to typecast to a 64-bit type before shifting past 32 bits. Coverity issue: 375808 Fixes: 08ccf3faa6a9 ("distributor: new packet distributor library") Signed-off-by: Bruce Richardson Acked-by: David Hunt --- lib/distributor/rte_distributor_single.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/distributor/rte_distributor_single.c b/lib/distributor/rte_distributor_single.c index b653620688..60ca86152f 100644 --- a/lib/distributor/rte_distributor_single.c +++ b/lib/distributor/rte_distributor_single.c @@ -248,6 +248,5 @@ rte_distributor_process_single(struct rte_distributor_single *d, */ for (i = 0; i < d->num_workers; i++) - match |= (!(d->in_flight_tags[i] ^ new_tag) - << i); + match |= ((uint64_t)!(d->in_flight_tags[i] ^ new_tag) << i); /* Only turned-on bits are considered as match */ -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:04.099678834 +0000 +++ 0100-distributor-fix-potential-overflow.patch 2022-03-01 10:41:01.484244135 +0000 @@ -1 +1 @@ -From 9699b09803b799ddc11abedffb17af059c992e9a Mon Sep 17 00:00:00 2001 +From 32f77d388449d619264babe3e64d0aeca0a25c58 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9699b09803b799ddc11abedffb17af059c992e9a ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index de90aa8bb5..2c77ac454a 100644 +index b653620688..60ca86152f 100644 @@ -25 +26 @@ -@@ -246,6 +246,5 @@ rte_distributor_process_single(struct rte_distributor_single *d, +@@ -248,6 +248,5 @@ rte_distributor_process_single(struct rte_distributor_single *d,