From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58A09A034F for ; Tue, 1 Mar 2022 11:46:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 531A7426DE; Tue, 1 Mar 2022 11:46:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AD4D9407FF for ; Tue, 1 Mar 2022 11:46:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pjbRnXJ7KXO4Ky/lTIh/AywyQNq0s2MDNM0VeFRCgDc=; b=YQZubNLz6GNgwg32Vx3UR84OGj0We0uhRytEHmuoKsgHh3e2ZBrhJPUlPiWGaokd61u8RO PQN0XCL2/V+PqHVC/voAfYMmI/e06E5p7FyguaoftL8Dai2En9Cy8FZDHSdv9IMs4F05Nq GcmCb8XtRCXxRf7Vcj96ib2nmL8XJYM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-608-t0aTQafZPuqBcmrG3WioDQ-1; Tue, 01 Mar 2022 05:46:19 -0500 X-MC-Unique: t0aTQafZPuqBcmrG3WioDQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 333A08031E1; Tue, 1 Mar 2022 10:46:18 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C735721DF; Tue, 1 Mar 2022 10:46:16 +0000 (UTC) From: Kevin Traynor To: Madhuker Mythri Cc: Gaetan Rivet , dpdk stable Subject: patch 'devargs: fix crash with uninitialized parsing' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:42:58 +0000 Message-Id: <20220301104300.334382-102-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d3e4a2c2e6c897b944c459c8b09e9f4ceab4e956 Thanks. Kevin --- >From d3e4a2c2e6c897b944c459c8b09e9f4ceab4e956 Mon Sep 17 00:00:00 2001 From: Madhuker Mythri Date: Mon, 14 Feb 2022 22:38:11 +0530 Subject: [PATCH] devargs: fix crash with uninitialized parsing [ upstream commit 356a2aa054a9e803782ee8380a7ab1a53aecd1e3 ] The function rte_devargs_parse() previously was safe to call with non-initialized devargs structure as parameter. When adding the support for the global device syntax, this assumption was broken. Restore it by forcing memset as part of the call itself. Bugzilla ID: 933 Fixes: b344eb5d941a ("devargs: parse global device syntax") Signed-off-by: Madhuker Mythri Signed-off-by: Gaetan Rivet --- lib/eal/common/eal_common_devargs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index 8c7650cf6c..184fe676aa 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -192,4 +192,5 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev) if (da == NULL) return -EINVAL; + memset(da, 0, sizeof(*da)); /* First parse according global device syntax. */ -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:04.137334324 +0000 +++ 0102-devargs-fix-crash-with-uninitialized-parsing.patch 2022-03-01 10:41:01.485244135 +0000 @@ -1 +1 @@ -From 356a2aa054a9e803782ee8380a7ab1a53aecd1e3 Mon Sep 17 00:00:00 2001 +From d3e4a2c2e6c897b944c459c8b09e9f4ceab4e956 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 356a2aa054a9e803782ee8380a7ab1a53aecd1e3 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 8da3ba3879..d5833af373 100644 +index 8c7650cf6c..184fe676aa 100644 @@ -27 +28 @@ -@@ -190,4 +190,5 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev) +@@ -192,4 +192,5 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)