From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4A82A034F for ; Tue, 1 Mar 2022 11:43:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99C35407FF; Tue, 1 Mar 2022 11:43:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A6962426E2 for ; Tue, 1 Mar 2022 11:43:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UmfvIAAC5vH5rSPCmnGhlYx3p35xJZLVaXfrl5V2OQs=; b=VoEgjvIGRG0A4t93ZRs0tTpSvKGg1XVArFGK9IE/wcjKzPkQ53E6mRr8kYt+ipg7s3W2HW uOB7y6UXY7kfFKoDhLJLVjcMiEt6OceSn7gPLkjucXCO/p69ebQYkIW+EdyJOFUdMS1LeW nHthxS+XWAM2GIAlZ5PSrhKk05tcMwk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-323-NidF21J0OSCgIMx_JqqnIw-1; Tue, 01 Mar 2022 05:43:39 -0500 X-MC-Unique: NidF21J0OSCgIMx_JqqnIw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5A401868335; Tue, 1 Mar 2022 10:43:37 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E19D6FB19; Tue, 1 Mar 2022 10:43:36 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Conor Walsh , Kevin Laatz , dpdk stable Subject: patch 'test/dma: fix missing checks for device capacity' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:41:31 +0000 Message-Id: <20220301104300.334382-15-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/ebc0188ccb8bca848a75ec0e1a268829ca92319c Thanks. Kevin --- >From ebc0188ccb8bca848a75ec0e1a268829ca92319c Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Wed, 16 Feb 2022 16:06:07 +0000 Subject: [PATCH] test/dma: fix missing checks for device capacity [ upstream commit 727e6b784087306801d487590e03d00b4e6e2485 ] For some DMA HW devices, e.g. those using the idxd driver, the maximum burst size is configurable, which can lead to test failures if the value is set too small. Add explicit check for this to give reasonable error messages for devices which need their config adjusted. Fixes: 1b86a66a30c2 ("test/dma: add more comprehensive copy tests") Fixes: 8fa5d2683940 ("test/dma: add burst capacity test") Signed-off-by: Bruce Richardson Reviewed-by: Conor Walsh Reviewed-by: Kevin Laatz --- app/test/test_dmadev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c index b206db27ae..e40c29c23b 100644 --- a/app/test/test_dmadev.c +++ b/app/test/test_dmadev.c @@ -775,4 +775,7 @@ test_dmadev_instance(int16_t dev_id) ERR_RETURN("Error with rte_dma_stats_get()\n"); + if (rte_dma_burst_capacity(dev_id, vchan) < 32) + ERR_RETURN("Error: Device does not have sufficient burst capacity to run tests"); + if (stats.completed != 0 || stats.submitted != 0 || stats.errors != 0) ERR_RETURN("Error device stats are not all zero: completed = %"PRIu64", " @@ -796,5 +799,8 @@ test_dmadev_instance(int16_t dev_id) /* run some burst capacity tests */ - if (runtest("burst capacity", test_burst_capacity, 1, dev_id, vchan, CHECK_ERRS) < 0) + if (rte_dma_burst_capacity(dev_id, vchan) < 64) + printf("DMA Dev %u: insufficient burst capacity (64 required), skipping tests\n", + dev_id); + else if (runtest("burst capacity", test_burst_capacity, 1, dev_id, vchan, CHECK_ERRS) < 0) goto err; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:01.818237132 +0000 +++ 0015-test-dma-fix-missing-checks-for-device-capacity.patch 2022-03-01 10:41:01.251244087 +0000 @@ -1 +1 @@ -From 727e6b784087306801d487590e03d00b4e6e2485 Mon Sep 17 00:00:00 2001 +From ebc0188ccb8bca848a75ec0e1a268829ca92319c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 727e6b784087306801d487590e03d00b4e6e2485 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index db5aff701c..2b097e0f47 100644 +index b206db27ae..e40c29c23b 100644 @@ -26 +27 @@ -@@ -776,4 +776,7 @@ test_dmadev_instance(int16_t dev_id) +@@ -775,4 +775,7 @@ test_dmadev_instance(int16_t dev_id) @@ -34 +35 @@ -@@ -797,5 +800,8 @@ test_dmadev_instance(int16_t dev_id) +@@ -796,5 +799,8 @@ test_dmadev_instance(int16_t dev_id)